Adom Gantt

@@ -2257,7 +2257,7 @@ function buildRowDom(r,idx){     bDiv.className='bar-row ms-row';     const x=toX(r.date);     const hit=document.createElement('div');hit.className='ms-hit';hit.style.left=x+'px';-    hit.dataset.msi=String(items.filter(q=>q.type==='milestone').indexOf(r));+    hit.dataset.msuid=r.uid||'';     hit.dataset.title=r.name;hit.dataset.dates=fmt(r.date);hit.dataset.body=r.description||'';hit.dataset.prov=provLabel(r);     const d=document.createElement('div');d.className='ms-diamond';d.style.left=x+'px';     bDiv.appendChild(hit);bDiv.appendChild(d);@@ -2266,7 +2266,7 @@ function buildRowDom(r,idx){     const ln=document.createElement('div');ln.className='ms-line';ln.style.left=x+'px';     ln.style.color=phaseColor(r.phase);     const cap=document.createElement('div');cap.className='ms-cap';cap.textContent=r.name.replace(/^M(\d+):\s*/,'M$1 ');-    cap.dataset.msi=String(items.filter(q=>q.type==='milestone').indexOf(r));+    cap.dataset.msuid=r.uid||'';     cap.dataset.title=r.name;cap.dataset.dates=fmt(r.date);cap.dataset.body=r.description||'';cap.dataset.prov=provLabel(r);     ln.appendChild(cap);msLineEls.push(ln);     r._msEl=d;r._msHit=hit;r._msLine=ln;@@ -2277,7 +2277,7 @@ function buildRowDom(r,idx){     r._nameSpan=lDiv.querySelector('.row-name');     const sk=statusOf(r);const tg=sk?`<span class="tag ${statusTagFor(sk)}">${esc(statusTextFor(sk))}</span>`:'';     r._nameSpan.innerHTML=esc(r.name)+tg;-    bDiv.className='bar-row';const x1=toX(r.start),x2=toX(r.end),b=document.createElement('div');b.className='bar'+(r.striped?' bar-striped':'');b.style.left=x1+'px';b.style.width=Math.max(x2-x1,6)+'px';b.style.background=phaseColor(r.phase);b.dataset.title=r.name;b.dataset.dates=fmt(r.start)+' → '+fmt(r.end);b.dataset.body=r.description||'';b.dataset.prov=provLabel(r);b.dataset.id=r.id;b.dataset.idx=idx;+    bDiv.className='bar-row';const x1=toX(r.start),x2=toX(r.end),b=document.createElement('div');b.className='bar'+(r.striped?' bar-striped':'');b.style.left=x1+'px';b.style.width=Math.max(x2-x1,6)+'px';b.style.background=phaseColor(r.phase);b.dataset.title=r.name;b.dataset.dates=fmt(r.start)+' → '+fmt(r.end);b.dataset.body=r.description||'';b.dataset.prov=provLabel(r);b.dataset.id=r.id;     const nt=document.createElement('div');nt.className='bar-note';nt.textContent=r.note||'';b.appendChild(nt);r._noteEl=nt;     b.appendChild(Object.assign(document.createElement('div'),{className:'drag-handle left'}));b.appendChild(Object.assign(document.createElement('div'),{className:'drag-handle right'}));bDiv.appendChild(b);barEls[r.id]={bar:b,idx,row:bDiv};}   r._lDiv=lDiv;r._bDiv=bDiv;r._itemIdx=idx;labelsEl.appendChild(lDiv);bars.appendChild(bDiv);@@ -2748,7 +2748,7 @@ bars.addEventListener('click',e=>{   }   const msHit=e.target.closest('.ms-hit, .ms-cap');   if(msHit){-    const mr=msByIndex(+msHit.dataset.msi);+    const mr=rowByUid(msHit.dataset.msuid);     // A modifier on a milestone builds the set, the same gesture as on a bar. A     // plain click still opens its editor, because that is what a plain click on a     // milestone has always meant and one is not a selection.@@ -2758,7 +2758,7 @@ bars.addEventListener('click',e=>{       if(selected.size>1)openBatchEditor(); else closeEditor();       return;     }-    clearSelection(); openMilestoneEditor(+msHit.dataset.msi); e.stopPropagation(); return;+    clearSelection(); openMilestoneEditor(msHit.dataset.msuid); e.stopPropagation(); return;   }   const bar=e.target.closest('.bar[data-id]');   if(bar&&!e.target.classList.contains('drag-handle')){@@ -2775,8 +2775,8 @@ document.addEventListener('click',e=>{if(!e.target.closest('.editor')&&!e.target }  // ── Milestone editor ──-function openMilestoneEditor(i){-  const r=msByIndex(i);if(!r)return;+function openMilestoneEditor(uid){+  const r=rowByUid(uid);if(!r||r.type!=='milestone')return;   closeEditor();   editorEl.innerHTML=`<div class="drag-bar"></div>     <div class="de-row"><div style="flex:1"><label>milestone</label>@@ -2890,7 +2890,6 @@ function openBatchEditor(){   wireBatchCopy(); } -function msByIndex(i){return items.filter(r=>r.type==='milestone')[i];} function updateMilestone(r){   if(!r||!r._msEl)return;   const x=toX(r.date);@@ -2958,8 +2957,8 @@ bars.addEventListener('mousedown',e=>{   const hit=e.target.closest('.ms-hit, .ms-cap');   if(!hit)return;   e.preventDefault();hideTip();-  const r=msByIndex(+hit.dataset.msi);-  if(!r)return;+  const r=rowByUid(hit.dataset.msuid);+  if(!r||r.type!=='milestone')return;   snapshotMs(r);   dragState={kind:'ms',r,startX:e.clientX,origLeft:toX(r.date)};   document.body.style.cursor='ew-resize';@@ -4069,12 +4068,17 @@ function provLabel(r){ const p=provOf(r); return p?p.label:''; } // url, so a hand-written provenance stays hand-written. function provValue(r){ const p=provOf(r); return p ? (p.url?{label:p.label,url:p.url}:p.label) : ''; } function provSig(r){ const p=provOf(r); return p ? p.label+'\u0001'+p.url : ''; }-function msIndexOf(r){return items.filter(q=>isMs(q)).indexOf(r);}-function rowKey(r){return isMs(r)?('m:'+msIndexOf(r)):('t:'+r.id);}+// A table row's key. The milestone half used to be `m:<index into the filtered+// milestone list>`, computed when the table rendered and resolved whenever it was+// read: the same stale-position bug the caps had, one row over. `focusedKey`+// outlives a render, so a reorder between the two could hand a keystroke to the+// wrong milestone. Both halves are durable now, and neither is a position.+function rowKey(r){return isMs(r)?('m:'+(r.uid||'')):('t:'+r.id);} function rowItem(key){   if(!key)return null;   if(key.charAt(0)==='t')return items.find(r=>r.id===key.slice(2));-  return msByIndex(+key.slice(2));+  const r=rowByUid(key.slice(2));+  return (r&&isMs(r))?r:null; } // Re-render the chart's own label row, so a status changed in the table is // already true on the chart when you toggle back.