Adom Gantt

@@ -121,18 +121,19 @@ function appendLog(events, actor) { // against, and nothing ever says it was invented. A 400 that names the offending // rows is fixable in a minute and cannot quietly become someone's deadline. const DATE_RE = /^\d{4}-\d{1,2}(-\d{1,2})?$/;+// The same rule the viewer applies in gantt.html: a task needs a start and an end,+// a milestone needs a date, a group needs neither.+function rowDatesOk(r) {+  if (!r || r.type === 'group') return true;+  if (r.type === 'milestone') return DATE_RE.test(String(r.date || ''));+  return DATE_RE.test(String(r.start || '')) && DATE_RE.test(String(r.end || ''));+} function assertDates(items) {   const bad = [];   (items || []).forEach((r, i) => {-    if (!r || r.type === 'group') return;-    const who = r.id || r.name || r.label || `row ${i + 1}`;-    if (r.type === 'milestone') {-      if (!DATE_RE.test(String(r.date || ''))) bad.push(`${who} (milestone needs a date)`);-      return;-    }-    if (!DATE_RE.test(String(r.start || '')) || !DATE_RE.test(String(r.end || ''))) {-      bad.push(`${who} (task needs a start and an end)`);-    }+    if (rowDatesOk(r)) return;+    const who = (r && (r.id || r.name || r.label)) || `row ${i + 1}`;+    bad.push(`${who} (${r && r.type === 'milestone' ? 'milestone needs a date' : 'task needs a start and an end'})`);   });   if (bad.length) {     const shown = bad.slice(0, 10).join('; ');@@ -740,7 +741,16 @@ function importJiraCSV(body) {  function generateSVG() {   const data = mergedData();-  const { project, phases, items } = data;+  const { project, phases } = data;++  // Imports reject undateable rows, but a hand-edited data file never goes through+  // an importer, and this path used to 500 on one while the viewer and the other+  // three exports all coped. Drop what cannot be drawn, same rule as the viewer,+  // and say so in a comment rather than silently shipping a shorter chart.+  const allItems = data.items || [];+  const items = allItems.filter(rowDatesOk);+  const dropped = allItems.filter(r => !rowDatesOk(r))+    .map((r, i) => (r && (r.id || r.name || r.label)) || `row ${i + 1}`);    const COL = 66;   const ROW_H = 34;@@ -758,12 +768,21 @@ function generateSVG() {     if (r.date && r.date > maxDate) maxDate = r.date;   });   phases.forEach(p => {+    // A phase with no usable start/end is the same class of hand-edit as a+    // dateless row, and split() on it threw from the same function.+    if (!p || !DATE_RE.test(String(p.start || '')) || !DATE_RE.test(String(p.end || ''))) return;     const ps = p.start + '-01';     const [ey, em] = p.end.split('-').map(Number);     const pe = `${ey}-${String(em).padStart(2, '0')}-28`;     if (ps < minDate) minDate = ps;     if (pe > maxDate) maxDate = pe;   });+  // Nothing in the file carried a date. Draw an empty month rather than a chart+  // with a negative width.+  if (minDate > maxDate) {+    const now = new Date();+    minDate = maxDate = `${now.getFullYear()}-${String(now.getMonth() + 1).padStart(2, '0')}-01`;+  }    const [minY, minM] = minDate.split('-').map(Number);   const [maxY, maxM] = maxDate.split('-').map(Number);@@ -785,7 +804,12 @@ function generateSVG() {    const esc = s => String(s).replace(/&/g, '&amp;').replace(/</g, '&lt;').replace(/>/g, '&gt;').replace(/"/g, '&quot;'); -  let svg = `<svg xmlns="http://www.w3.org/2000/svg" width="${totalW}" height="${totalH}" viewBox="0 0 ${totalW} ${totalH}">+  // "--" cannot appear inside an XML comment, and these names come from the file.+  const dropNote = dropped.length+    ? `\n<!-- ${dropped.length} row(s) left out: no usable date. ${esc(dropped.slice(0, 12).join(', ')).replace(/-{2,}/g, '-')}${dropped.length > 12 ? `, and ${dropped.length - 12} more` : ''} -->`+    : '';++  let svg = `<svg xmlns="http://www.w3.org/2000/svg" width="${totalW}" height="${totalH}" viewBox="0 0 ${totalW} ${totalH}">${dropNote} <defs>   <style>     .bg { fill: #0d1117; }