Closed bug report

Settings: horizontal rules land mid-section and never at section boundaries — 'Check now' reads as belonging to Adom Desktop, not Updater

Drew Owens · 1mo ago ·closed by John Lauer

ah 0.1.302 (build 458c3221-dirty) · Windows 11 · Settings window, "Hydrogen Desktop" → Updater / Adom Desktop region

The problem

In the Settings window, the 1px horizontal rules are drawn between control rows inside a section, but never at a section boundary. The result is that the strongest visual break in any given stretch of the page lands in the middle of a section, while the actual section boundary is marked by nothing but whitespace. A human reading top-to-bottom cannot tell which heading a control belongs to.

Screenshot attached. Reading down that region, here is what is actually rendered:

  [ Launch Hydrogen Desktop automatically ]  Default: On
──────────────────────────────────────────────  ← rule (row break, correct)
  Shutdown WSL On Exit ....................... Default: Off
──────────────────────────────────────────────  ← rule (row break, correct)
  Assisted Signin ............................ Default: Off
                                                ← NO RULE — but this IS the section boundary
  ## Updater                                   (heading)
  Hydrogen Desktop keeps itself current ...    (section prose)
──────────────────────────────────────────────  ← rule MID-SECTION (this is the loud one)
  Check Now   [ Check now ]
  No updates found. You are on 0.1.302.
                                                ← NO RULE — section boundary again
  ## Adom Desktop                              (heading)

Why it is confusing

"Check Now" is orphaned. It sits below the only horizontal rule in that whole stretch and above the "Adom Desktop" heading with only whitespace between them. Every grouping cue on the page says it belongs to Adom Desktop. It belongs to Updater, which is above the rule. That is exactly backwards, and "Check now" is a button people press — pressing the wrong app's update check is a real misread, not a cosmetic one.

The same failure repeats at the "Assisted Signin" → "Updater" boundary: the Updater heading has no rule above it, so "Assisted Signin" and the Updater prose visually run together as one block.

What I expect

Two different breaks should not look the same, and the stronger one should be the section break:

  1. Every section heading gets a rule above it (or equivalent separation — a full-width rule, or generous top margin plus a rule; something that reads as "new section starts here"). Right now section boundaries carry zero separator.
  2. Row dividers inside a section stay subtler than the section break — lighter, or inset from the card edge rather than full-bleed, so a divider can never be mistaken for a section boundary.
  3. No rule between a section's prose and its first control row. The Updater paragraph and the "Check Now" row are one section; the rule currently sitting between them is the whole cause of the orphaning.

The settings-layout skill already calls for dividers "between" control rows; the gap is that it says nothing about marking the section boundary, and the current implementation gives the section boundary less visual weight than a row boundary. Whatever the fix, the invariant worth encoding is: section break > row break, always, and a section never opens with a rule below its heading.

Repro

  1. Open Settings (Hydrogen Desktop → Updater in the sidebar).
  2. Scroll so the Assisted Signin row, the Updater section and the top of Adom Desktop are all visible.
  3. Ask someone who has not seen the page before which section the "Check now" button belongs to.

settings-screen

5 Replies

John Lauer · 1mo ago

Verified against the current Windows build (1.0.143+, Settings window on ConfRoomROG, jumped to the exact Updater / Dock Bar region): this does not reproduce there. The settings were redesigned into bordered cards (2026-08-03): each subsection is one elevated card with its heading INSIDE the card, so Check Now sits visibly inside the Updater card above its row divider, and every section boundary is a card gap with borders on both sides, a much stronger break than any row divider. Your report matches the pre-card layout.

One thing that needs your confirmation: 'ah 0.1.302 (build 458c3221)' does not match any current Windows release (they are 1.0.14x). That version pattern looks like the macOS build, which has its own settings implementation and repo. If you are on the Mac app, this belongs with the hydrogen-mac thread and I will make sure it gets there; if you are on Windows, please update to 1.0.145 (the updater will offer it) and tell me if you still see bare rules at section boundaries.

Drew Owens · 1mo ago

I'm on windows build, clicking "Check now" claims I am on latest version.

Also, would be great in general to have an update prompt banner appear like in Adom Bridge so I don't have to manually check

Drew Owens · 1mo ago

Historically, I have always had to manually download latest version from wiki and install that way, i.e. I have never been able to update from within the Hydrogen app

John Lauer · 1mo ago

Triaged with John today: fix now. The rules move to section boundaries (and off the rows inside a section) so a control reads under its own heading. On your two follow-ups: in-app updates have worked since the banner fixes in #68 (1.0.281), so a newer build shows a bar in the title bar and one click installs it; "Check now" in Settings is no longer something to know about (#73). If you are still on a manual-download build, the next install puts you on the banner path.

John Lauer · 1mo ago

Correction to my note above: no code change is needed. This was fixed on 3 August, when the Settings window moved to one bordered card per subsection (the same commit that added the Adom Studio scheme rows). Rules now only separate rows inside a card, and a section boundary is a card edge plus the gap to the next card, so "Check now" sits visibly inside Updater. Your report was against 0.1.302, a build from before that change; the current insiders build is 1.0.385.

Attached: the Updater card on arav-rog running 1.0.385, captured just now.

Closing. Reopen if you see a mid-section rule on 1.0.3xx or later.

settings-arav-updater

Log in to reply.