ralph: Your AIs dialog left open after the sweep's restore (does not reproduce by hand)

Overview Files Skills Discover Packages Releases Dependencies Issues20 Breadcrumbs Pull Requests Activity

Closed general

John Lauer · 13d ago ·closed by John Lauer

ralph ui.action.ai-accounts.open fails on restore: the Your AIs dialog is still open after the sweep closes it. It never reproduces by hand.

Seen on 1.0.580 and 1.0.581 on winvm, and on 1.0.582 on ConfRoomROG (210/211, this is the one red): ui.action.ai-accounts.open:FAIL:group=dialog invoked=True effect=True (win 1->1, dlg 0->1, ...) restored=False left=["DIV.wrap svelte-dey47t"]

What works, measured on ConfRoomROG 1.0.582 (/ui/invoke plus /eval-in, the same calls the sweep makes):

ai-accounts.open raises the overlay within 0.5 s.
The sweep's own dismiss JS (the RestoreAll pass) finds DIV.wrap, clicks button.x and the primary Close, and the overlay is gone 0.5 s later. It stays gone for 10 s.
None of the follow-up restore steps reopen it: the eight *.close actions, the five /window/close labels, /setup/panel/hide and /setup/panel/virgin/hide were each checked individually.
The first-run re-present path is not involved: on ConfRoomROG /agents/setup-state says done: true.

What I ruled out:

Slow open: the sweep now waits up to 5 s for the effect.
Slow close: the sweep now waits up to 3 s before calling it a leak (dfaf2983 and the follow-up).

Still unexplained: inside the full sweep the overlay is present after restore, and it is still there when the sweep ends (/eval-in counted 1 .ai-accounts-overlay right after the run). Next suspects:

A second agent-setup {active:true} emitted after the close. The sweep's dialog-content capture (/screenshot with a selector) or an earlier menu path (menu.profile.[Your AIs]) may trigger a second present.
Two VS Code panes, left over from the layout phase, each answering the event.

A one-line log in PanelVisualStudioCode's agent-setup listener (stamp, manage, machine) would settle it on the next sweep.

Product impact: none observed. A person who opens Your AIs and presses X or Close gets it closed, and it stays closed.

1 Reply

John Lauer · 13d ago

Fixed in 1.0.588 (insiders). The ralph UI sweep on ConfRoomROG is now 140 passed, 0 failed.

What it was:

A real bug. The Your AIs dialog is drawn inside the VS Code tab. When another tab of the same pane was in front, opening it (Adom menu > Manage AIs, the profile menu, a first-run raise) showed nothing: the dialog sat behind that tab and appeared later, whenever VS Code came to the front. That is why the sweep found it "left open" long after. 1.0.586's logging showed three agent-setup events reaching the pane during the sweep, none of them visible. Fix (1.0.587): raising the dialog brings the VS Code tab to the front.
A missing action. Your AIs was the only dialog with an open action and no close, so agents driving Hydrogen through /ui/invoke could not close it. Fix (1.0.588): ai-accounts.close. The sweep's restore now calls it like the other dialogs' close actions.

Left unexplained: inside the full sweep, the generic close-button click never reached this dialog's handler. Every isolated reproduction closed it, including the sweep's exact sequence and timing. The registered close action makes that moot for both agents and the sweep.