← All Pull Requests

Package and install the shared hero and LED skills from PR1 #2

Open opened by John Lauer 2026-09-17

Ship the new hero and LED skills from PR1 in the package's explicit file allowlist, register both skill names, and copy the shared tools directory into the installed EDA skillpack. Without this companion change a source merge could appear complete while the installed package omitted the new skills or generator.

Depends on https://wiki.adom.inc/adom/eda-engineering/prs/1; merge both before publishing. Validation: ran install.sh with EDA_SKILL_INSTALL_ROOT=/tmp/astra-eda-hero-install and verified both standalone skills plus eda-engineering/tools/component-reference-overlay.py in the Codex and Claude trees. The user's live skill directories were not replaced by this test.

Diff Skip to comments

--- a/package.json+++ b/package.json@@ -1,162 +1,168 @@⋯ 131 unchanged lines ⋯     "skills/eda-pour-planning-measurement/SKILL.md",     "skills/eda-thermal-bottlenecks/SKILL.md",     "skills/eda-visible-routing/SKILL.md",-    "uninstall.sh"+    "uninstall.sh",+    "skills/eda-component-hero/SKILL.md",+    "skills/eda-led-appearance/SKILL.md",+    "tools/component-reference-overlay.py"   ],   "dependencies": {},   "confirmed_user_skills": [⋯ 13 unchanged lines ⋯     "eda-placement-routing-review",     "eda-pour-planning-measurement",     "eda-thermal-bottlenecks",-    "eda-visible-routing"+    "eda-visible-routing",+    "eda-component-hero",+    "eda-led-appearance"   ],   "scripts": {     "install": "./install.sh",⋯ 1 unchanged line ⋯   },   "name": "eda-engineering" }+--- a/install.sh+++ b/install.sh@@ -1,27 +1,28 @@⋯ 10 unchanged lines ⋯ for eda_agent_skills in "$eda_claude_skills" "$eda_codex_skills"; do   mkdir -p "$eda_agent_skills/eda-engineering"   cp "$eda_package_root/SKILL.md" "$eda_agent_skills/eda-engineering/SKILL.md"-  for eda_resource in references skills docs; do+  for eda_resource in references skills docs tools; do     if [ -d "$eda_package_root/$eda_resource" ]; then       mkdir -p "$eda_agent_skills/eda-engineering/$eda_resource"       cp -R "$eda_package_root/$eda_resource/." "$eda_agent_skills/eda-engineering/$eda_resource/"⋯ 7 unchanged lines ⋯   done   printf 'Installed EDA Skillpack into %s\n' "$eda_agent_skills" done+

Comments

No comments yet.

Log in to comment.