← Commit history

Ship 1.9.45: icon-generation token in the AUMID forces a taskbar button rebuild so stale white tiles repaint

John Lauer ·ca626a64f5 · ·parent bbcf7fc
4 files changed +19−8
adom-bridge-puppeteer-manifest.json+4−4
@@ -1,10 +1,10 @@ {   "manifest_version": 1,   "name": "puppeteer",-  "version": "1.9.44",-  "url": "https://wiki.adom.inc/download/adom/adom-desktop-puppeteer-bridge/1.9.44/adom-bridge-puppeteer-v1.9.44.zip",-  "sha256": "ff00ff9ec8fa0be1f6bc4a29a79e28a4fad9dcd34e8de24a66e8776119ce46ff",-  "size": 293536,+  "version": "1.9.45",+  "url": "https://wiki.adom.inc/download/adom/adom-desktop-puppeteer-bridge/1.9.45/adom-bridge-puppeteer-v1.9.45.zip",+  "sha256": "ced15249096d2a68d2d8db3485195f344aecb159c7ce7d2dd53892a1c0b93d67",+  "size": 293875,   "verbPrefixes": [     "browser_",     "desktop_recorder_",
src/BRIDGE_VERSION+1−1
@@ -1 +1 @@-1.9.44+1.9.45
src/bridge.json+1−1
@@ -2,7 +2,7 @@   "manifest_version": 1,   "name": "puppeteer",   "displayName": "Puppeteer (Chrome for Testing + Native)",-  "version": "1.9.44",+  "version": "1.9.45",   "description": "Drives a browser ALREADY on the machine \u2014 installed Chrome, else Microsoft Edge (every Windows PC ships with Edge) \u2014 launched with a FRESH isolated profile, so the common case has NO ~150 MB Chrome-for-Testing download and it never touches the user's real tabs/logins. Binds its local server to LOOPBACK (127.0.0.1) only, so no Windows Firewall 'allow Node through the firewall' prompt ever pops. Chrome for Testing is fetched only as a LAST RESORT if the machine has no Chromium browser at all. SPAWN-VERIFIED fallback: pup tries each detected browser (Chrome \u2192 Edge \u2192 CfT) and actually launches it, falling through to the next if one won't start (and handling browsers like Edge that relaunch onto another PID), so a corrupt/partial install never hard-fails an open. The browser that launches is cached as the default (persisted across restarts) so it isn't re-probed each time. On spawn the bridge SELF-WARMS: detects browsers + disk, and only if the box has no Chrome/Edge and no cached CfT does it background-fetch CfT so the first open is instant. browser_use pins a specific browser (chrome | edge | cft | auto); {browser:'chrome',install:true} downloads & installs REAL Google Chrome (user-scoped, no admin) on an Edge-only box. browser_readiness (READ-ONLY) reports which browser will be used + the full candidate list + the default + free disk. Every failure returns a specific errorCode + _hint (chrome_install_no_disk, chrome_download_network, chrome_install_permission, chrome_stable_not_detected, \u2026). Launches with FULL browser permissions by default for full debug (strictPermissions:true opts out). Headful automation: open/close windows+tabs, navigate, screenshot, eval JS, record. pup is a GENERIC, non-profile browser only \u2014 every session is a fresh isolated Chrome/Edge process, never the user's real signed-in browser; profile defaults to sessionId. To drive the user's REAL Chrome/Edge (their profile, cookies, SSO), use the Adom browser EXTENSION's nbrowser_* verbs \u2014 a separate bridge, not pup's job.",   "homepage": "https://wiki.adom.inc/adom/adom-desktop",   "author": "Adom Inc.",
src/server.js+13−2
@@ -1715,6 +1715,17 @@ let _jumplistSupported = null;   // null = unprobed (desktop_set_window_jumplist //   web      globe                anything else on the internet //   mixed    stacked windows      tabs spanning more than one category const PUP_ICON_DEFAULT = 'adom-pup-browser3.ico';+// v1.9.45 — ICON GENERATION. BUMP THIS whenever the icon FILES or the AUMID branding mechanism+// change, and every live window gets a freshly-painted taskbar button.+//+// WHY it must exist: Win11 bakes a taskbar button's tile when the button is CREATED and never+// re-reads it (AD's measurement, WIN11_TASKBAR_ICON.md Part 7). A window keeps one appId for its+// whole life, so fixing what an appId RESOLVES TO cannot repair a button that already exists. That+// is exactly what happened in 1.9.44: writing IconResource fixed every FUTURE button but left the+// already-created ones white, because their tiles were baked while the AUMID was still unbranded.+// Folding a generation token into the appId turns an icon change into a NEW appId, which forces the+// shell to create a NEW button, which is the ONLY thing that repaints. Cost is one button rebuild.+const PUP_ICON_GEN = 'i2'; const PUP_CAT_ICONS = {   wiki: 'pup-cat-wiki9.ico',   'wiki-in': 'pup-cat-wiki-in9.ico',@@ -1811,7 +1822,7 @@ async function stampPupIdentity(sessionId) {     // wins here; GROUPED mode keeps the stable pinnable Adom.Pup.     const grouped = pupSettings().taskbarGrouping === 'grouped';     const cat = pupCategory(sessionId) || 'plain';-    const appId = grouped ? PUP_APP_ID : `${PUP_APP_ID}.${sessionId}.${cat}`;+    const appId = grouped ? PUP_APP_ID : `${PUP_APP_ID}.${sessionId}.${cat}.${PUP_ICON_GEN}`;     const sess = sessions.get(sessionId);     const prevAppId = sess && sess._curAppId;     // Register the NEW appId BEFORE stamping (AD's verified order) so the fresh button resolves@@ -1922,7 +1933,7 @@ function pruneStaleAumids() {       if (!m) continue;       const appId = m[1], rest = m[2];       if (appId === PUP_APP_ID) continue;                 // the pinnable launcher stays-      const sid = rest.replace(/\.(wiki-in|wiki|app|web|mixed|plain)$/, '');+      const sid = rest.replace(/\.i\d+$/, '').replace(/\.(wiki-in|wiki|app|web|mixed|plain)$/, '');       if (live.has(sid)) continue;       try {         execFileSync('reg', ['delete', `HKCU\\Software\\Classes\\AppUserModelId\\${appId}`, '/f'],