Pup - the AI's own browser

@@ -1861,6 +1861,9 @@ async function stampPupIdentity(sessionId) { const _registeredPupAumids = new Set(); async function registerPupAumid(appId, sessionId) {   if (_identitySupported === false || appId === PUP_APP_ID || _registeredPupAumids.has(appId)) return;+  // v1.9.44: write IconResource FIRST, before the button can possibly exist. AD's registration does+  // not write it (see writeAumidIcon), and an AUMID with no icon is what paints white.+  writeAumidIcon(appId, pupIconPath(sessionId));   try {     const r = await chrome.adCommand('desktop_register_app_identity', {       appId, displayName: PUP_DISPLAY_NAME, iconPath: pupIconPath(sessionId), shortcut: false,@@ -1871,6 +1874,65 @@ async function registerPupAumid(appId, sessionId) {     console.log(`[identity] registered AUMID ${appId} (registry-only, icon=${pupCategory(sessionId) || 'plain'})`);   } catch (e) {} }+// v1.9.44 — WHY THE TASKBAR ICON GOES WHITE, and the fix. READ BEFORE TOUCHING ICON CODE.+//+// MEASURED on John's box: 129 of 129 HKCU AppUserModelId\Adom.Pup.* keys had IconResource = NULL.+// AD's desktop_register_app_identity ACCEPTS an iconPath but only materialises it when it also+// builds a Start Menu shortcut; with shortcut:false (our per-session path) the AUMID key is created+// with a DisplayName and NO IconResource at all. So the registry branded nothing, ever.+//+// Everything still LOOKED right because the per-window Relaunch* properties that+// desktop_set_window_identity sets do brand the button. But those are a RACE against Win11 baking+// the tile at button-creation time. Win the race -> correct icon. Lose it -> Windows has nothing to+// resolve for that AUMID and paints the GENERIC WHITE DOCUMENT. That is why the icon was white on+// ONE window (a long-lived session whose button predated its stamp) and correct on its siblings —+// it was never a category or icon-file problem, it was an unbranded AUMID plus a lost race.+//+// FIX: write IconResource into HKCU ourselves. HKCU needs no UAC, this bridge already runs ON the+// desktop (no AD roundtrip, no shell-approval prompt), and a registry value is not a race — it is+// there before and after the button exists. Keep the Relaunch* props too; they are what repaint a+// LIVE category flip. Belt and braces.+//+// If icons go white again, check IconResource FIRST (see pup-bridge-debug -> "white taskbar icon").+function writeAumidIcon(appId, iconPath) {+  if (process.platform !== 'win32' || !appId || !iconPath) return false;+  try {+    if (!fs.existsSync(iconPath)) { console.log(`[identity] icon MISSING on disk: ${iconPath}`); return false; }+    const key = `HKCU\\Software\\Classes\\AppUserModelId\\${appId}`;+    // ",0" selects the first frame. reg.exe is used directly (not PowerShell) — no window, no profile+    // load, ~10ms, and it creates the key if the AD registration has not landed yet.+    execFileSync('reg', ['add', key, '/v', 'IconResource', '/t', 'REG_SZ', '/d', `${iconPath},0`, '/f'],+      { encoding: 'utf8', timeout: 5000, windowsHide: true, stdio: 'ignore' });+    return true;+  } catch (e) { console.log(`[identity] IconResource write failed for ${appId}: ${e.message}`); return false; }+}+// v1.9.44: the AUMID keys LEAKED. A new key is minted per session per category, but only the+// immediately-superseded one is unregistered, and only in-process — so every bridge restart orphaned+// its whole set (129 keys had accumulated). Sweep on startup: drop any Adom.Pup.<sid>.* key whose+// <sid> is not a live session. Never touch the pinnable base id.+function pruneStaleAumids() {+  if (process.platform !== 'win32') return;+  try {+    const out = execFileSync('reg', ['query', 'HKCU\\Software\\Classes\\AppUserModelId'],+      { encoding: 'utf8', timeout: 8000, windowsHide: true });+    const live = new Set(sessions.keys());+    let dropped = 0;+    for (const line of out.split(/\r?\n/)) {+      const m = line.match(/\\(Adom\.Pup\.(.+))$/);+      if (!m) continue;+      const appId = m[1], rest = m[2];+      if (appId === PUP_APP_ID) continue;                 // the pinnable launcher stays+      const sid = rest.replace(/\.(wiki-in|wiki|app|web|mixed|plain)$/, '');+      if (live.has(sid)) continue;+      try {+        execFileSync('reg', ['delete', `HKCU\\Software\\Classes\\AppUserModelId\\${appId}`, '/f'],+          { encoding: 'utf8', timeout: 5000, windowsHide: true, stdio: 'ignore' });+        dropped++;+      } catch (e) {}+    }+    if (dropped) console.log(`[identity] pruned ${dropped} stale Adom.Pup.* AUMID key(s) from HKCU`);+  } catch (e) {}+} async function unregisterPupAumid(appId) {   if (process.platform !== 'win32' || !appId || appId === PUP_APP_ID) return;   _registeredPupAumids.delete(appId);@@ -7224,6 +7286,9 @@ server.listen(PORT, BIND_HOST, async () => {     console.error('Session recovery failed:', e.message);   } +  // v1.9.44: sweep orphaned AUMID keys AFTER recovery, so live sessions are known and kept.+  try { pruneStaleAumids(); } catch (e) {}+   // Periodic cleanup: every 5 minutes, remove stale session files with dead PIDs   setInterval(async () => {     const files = listSessionFiles();