← Commit history

Fix my own 1.9.119 zombie test: '0 tabs' was the wrong condition. Killing a window's Chrome outright does NOT empty the session's tabs array (it still holds dead page handles), so the gate skipped precisely the zombie it was written to catch — verified by killing a window's Chrome and watching the session stay listed with tabCount 1 and no cleanup report. The test is now whether EVERY tab page reports closed/detached, which together with the existing dead-CDP-port check is a definitive zombie. Deliberately conservative: if any tab still reports open the session is left alone, because wrongly dropping a live session is far worse than a lingering dead one. The report-once queue itself was verified working in the same test (a delivered report was gone from the following call).

John Lauer ·572d59bdd2 ·3mo ago ·parent b6e1cdd
4 files changed +17−7
adom-bridge-puppeteer-manifest.json+4−4
@@ -1,10 +1,10 @@ {   "manifest_version": 1,   "name": "puppeteer",-  "version": "1.9.119",-  "url": "https://wiki.adom.inc/download/adom/adom-desktop-puppeteer-bridge/1.9.119/adom-bridge-puppeteer-v1.9.119.zip",-  "sha256": "5aa1c58f7dc91e9f6f12e21b87d90dec27a51e13793b3ceb6fabd85157635598",-  "size": 386733,+  "version": "1.9.120",+  "url": "https://wiki.adom.inc/download/adom/adom-desktop-puppeteer-bridge/1.9.120/adom-bridge-puppeteer-v1.9.120.zip",+  "sha256": "15db3a156a7f79368a845c99a4da103ce91f07502ea604e4521515c9e5176336",+  "size": 387067,   "verbPrefixes": [     "browser_",     "desktop_recorder_",
src/BRIDGE_VERSION+1−1
@@ -1 +1 @@-1.9.119+1.9.120
src/bridge.json+1−1
@@ -2,7 +2,7 @@   "manifest_version": 1,   "name": "puppeteer",   "displayName": "Puppeteer (Chrome for Testing + Native)",-  "version": "1.9.119",+  "version": "1.9.120",   "description": "Drives a browser ALREADY on the machine \u2014 installed Chrome, else Microsoft Edge (every Windows PC ships with Edge) \u2014 launched with a FRESH isolated profile, so the common case has NO ~150 MB Chrome-for-Testing download and it never touches the user's real tabs/logins. Binds its local server to LOOPBACK (127.0.0.1) only, so no Windows Firewall 'allow Node through the firewall' prompt ever pops. Chrome for Testing is fetched only as a LAST RESORT if the machine has no Chromium browser at all. SPAWN-VERIFIED fallback: pup tries each detected browser (Chrome \u2192 Edge \u2192 CfT) and actually launches it, falling through to the next if one won't start (and handling browsers like Edge that relaunch onto another PID), so a corrupt/partial install never hard-fails an open. The browser that launches is cached as the default (persisted across restarts) so it isn't re-probed each time. On spawn the bridge SELF-WARMS: detects browsers + disk, and only if the box has no Chrome/Edge and no cached CfT does it background-fetch CfT so the first open is instant. browser_use pins a specific browser (chrome | edge | cft | auto); {browser:'chrome',install:true} downloads & installs REAL Google Chrome (user-scoped, no admin) on an Edge-only box. browser_readiness (READ-ONLY) reports which browser will be used + the full candidate list + the default + free disk. Every failure returns a specific errorCode + _hint (chrome_install_no_disk, chrome_download_network, chrome_install_permission, chrome_stable_not_detected, \u2026). Launches with FULL browser permissions by default for full debug (strictPermissions:true opts out). Headful automation: open/close windows+tabs, navigate, screenshot, eval JS, record. pup is a GENERIC, non-profile browser only \u2014 every session is a fresh isolated Chrome/Edge process, never the user's real signed-in browser; profile defaults to sessionId. To drive the user's REAL Chrome/Edge (their profile, cookies, SSO), use the Adom browser EXTENSION's nbrowser_* verbs \u2014 a separate bridge, not pup's job. macOS (v1.9.74+): full parity with mac-native mechanics \u2014 background-by-default is the app-level hide (windows stay drivable/screenshottable while hidden), raise/lower map to unhide+activate/hide, browser_alert_window posts a native toast whose click focuses the window, browser_use {browser:'chrome',install:true} installs Chrome from the official dmg, and taskbar identity/badging remains Windows-only.",   "homepage": "https://wiki.adom.inc/adom/adom-desktop",   "author": "Adom Inc.",
src/server.js+11−1
@@ -3435,8 +3435,18 @@ async function reclaimUnmanagedWindows() {       // a Chrome killed outright (the bridge-restart tree kill) never emits one, so the session sat       // with 0 tabs and no flag and was never dropped. Zero tabs plus a dead port IS a zombie,       // however it got that way. (A session mid-launch has no tabs yet, so respect _launchInFlight.)-      if ((s.tabs || []).length) continue;+      // v1.9.120: "0 tabs" is NOT the test. Killing Chrome outright does not empty s.tabs — the array+      // still holds now-dead page handles — so my 1.9.119 gate skipped exactly the zombie it was meant+      // to catch (verified: killed a window's Chrome, the session stayed listed with tabCount 1).+      // The real test is whether every tab page is CLOSED/detached; that plus a dead CDP port below is+      // a definitive zombie. Conservative on purpose: if ANY tab still reports open we leave it alone,+      // because wrongly dropping a live session is far worse than a lingering dead one.       if (_launchInFlight.has(s.profileName)) continue;+      let anyTabOpen = false;+      for (const t of (s.tabs || [])) {+        try { if (t && t.page && !t.page.isClosed()) { anyTabOpen = true; break; } } catch (e) { /* detached = closed */ }+      }+      if (anyTabOpen) continue;       let port = null;       try { port = parseInt(fs.readFileSync(path.join(PROFILES_DIR, s.profileName, 'DevToolsActivePort'), 'utf8').trim().split('\n')[0], 10) || null; } catch (e) {}       const alive = port && await fetch(`http://127.0.0.1:${port}/json/version`).then(r => r && r.ok).catch(() => false);