Pup - the AI's own browser

@@ -260,6 +260,30 @@ const _launchInFlight = new Map(); // implies "retry and it's yours". Cleared on close. Ownership is still self-reported attribution, never // authorization — it exists to stop threads trampling each other, not to secure anything. const _sessionOwnerClaims = new Map();   // sessionId -> owner string+// v1.9.119 (John's design) — CLEANUP REPORT QUEUE. pup should tidy up on its own AND tell somebody it+// did. Silent janitorial work is invisible: John found four zombie sessions cluttering every thread's+// browser_list_windows and had to ask about them. So each cleanup is recorded here and attached to the+// NEXT verb response as `_cleanupReport`, then DROPPED (report-once). The thread that receives it is+// whichever one happens to call next, which is usually NOT the thread whose window was cleaned — that is+// accepted by design: it may be irrelevant to that caller and it can ignore it, but it reaches the user+// eventually, which beats never surfacing at all. Capped so a storm cannot bloat a response.+const _cleanupReports = [];+const CLEANUP_REPORT_MAX = 12;+function recordCleanup(msg) {+  try {+    if (!msg) return;+    _cleanupReports.push(String(msg).slice(0, 240));+    while (_cleanupReports.length > CLEANUP_REPORT_MAX) _cleanupReports.shift();+    console.log(`[janitor] ${msg}`);+  } catch (e) {}+}+function drainCleanupReports() {+  if (!_cleanupReports.length) return null;+  const items = _cleanupReports.splice(0, _cleanupReports.length);+  return `pup CLEANED UP after itself since your last call (reported once, then forgotten — it may not `+    + `concern YOUR windows, in which case ignore it, but please surface it to the user if it looks `+    + `relevant): ${items.map((m, i) => `(${i + 1}) ${m}`).join('  ')}`;+}   // ── Tab helpers ────────────────────────────────────────────────────@@ -1544,7 +1568,9 @@ async function reapOrphanPupChromes() {   if (orphans.length) { await _taskkillPids(orphans.map(p => p.pid)); await new Promise(r => setTimeout(r, 350)); }   let remaining = (await _psProcs(where)).filter(isOrphan);   if (remaining.length) { await _taskkillPids(remaining.map(p => p.pid)); await new Promise(r => setTimeout(r, 300)); remaining = (await _psProcs(where)).filter(isOrphan); }-  if (killed || remaining.length) console.log(`[reap-orphan] killed ${killed} orphan pup process(es), remaining ${remaining.length} (spared ${liveDirs.size} live profile(s))`);+  if (killed || remaining.length) {+    recordCleanup(`reaped ${killed} orphaned pup browser process(es) that no live session owned${remaining.length ? ` (${remaining.length} survived and may still be using CPU)` : ''} — ${liveDirs.size} live profile(s) were spared`);+  }   return { killed, remaining: remaining.length }; } @@ -3405,12 +3431,17 @@ async function reclaimUnmanagedWindows() {     // Chrome is truly gone, drop the session AND unregister its AUMID so no stale taskbar identity is     // left; if its Chrome is alive, Part B below reconnects and rescanProfile reattaches it by title.     for (const [sid, s] of [...sessions]) {-      if (!s._lostBrowser || (s.tabs || []).length) continue;+      // v1.9.119: do NOT require _lostBrowser. That flag is only set when a DISCONNECT EVENT fires;+      // a Chrome killed outright (the bridge-restart tree kill) never emits one, so the session sat+      // with 0 tabs and no flag and was never dropped. Zero tabs plus a dead port IS a zombie,+      // however it got that way. (A session mid-launch has no tabs yet, so respect _launchInFlight.)+      if ((s.tabs || []).length) continue;+      if (_launchInFlight.has(s.profileName)) continue;       let port = null;       try { port = parseInt(fs.readFileSync(path.join(PROFILES_DIR, s.profileName, 'DevToolsActivePort'), 'utf8').trim().split('\n')[0], 10) || null; } catch (e) {}       const alive = port && await fetch(`http://127.0.0.1:${port}/json/version`).then(r => r && r.ok).catch(() => false);       if (alive) continue; // Part B will reconnect + rescanProfile reattaches this same session-      console.log(`[reclaim] zombie session "${sid}" (_lostBrowser, 0 tabs, Chrome gone) — dropping it and its taskbar identity`);+      recordCleanup(`dropped zombie session "${sid}" (0 tabs, its Chrome was gone) and unregistered its taskbar identity — it had been showing up in browser_list_windows for every thread`);       try { if (s._curAppId && s._curAppId !== PUP_APP_ID) await unregisterPupAumid(s._curAppId); } catch (e) {}       sessions.delete(sid);       try { deleteSessionFile(sid); } catch (e) {}@@ -6015,6 +6046,14 @@ function maybeAttachBugInvite(obj, verb) {     let mode = 'on';     try { mode = (pupSettings().reportIssues === 'off') ? 'off' : 'on'; } catch (e) {}     if (mode === 'off') return;+    // v1.9.119: hand over any pending janitorial report. Verb-scoped for the same reason the invite is:+    // AD's /health poll and its statusVerb probe would otherwise consume it before any AI saw it.+    try {+      if (!isProbe && obj._cleanupReport === undefined) {+        const rep = drainCleanupReports();+        if (rep) obj._cleanupReport = rep;+      }+    } catch (e) {}     const isError = obj.success === false || !!obj.errorCode || (!!obj.error && obj.error !== '');     // A FAILURE always earns the invitation, even on a probe — that is the highest-value moment.     if (isError) { obj._reportIssues = bugReportInvite(true); return; }@@ -6091,7 +6130,7 @@ function sendJSON(res, obj, status = 200) {               touched = true;             }           } catch (e) {}-          for (const k of ['_reportIssues', '_hint', '_next', 'related', 'pitfalls']) {+          for (const k of ['_reportIssues', '_cleanupReport', '_hint', '_next', 'related', 'pitfalls']) {             if (obj[k] !== undefined && inner[k] === undefined) { inner[k] = obj[k]; touched = true; }           }           if (touched) obj.output = JSON.stringify(inner);