← Commit history

Keep the log janitor (dedupe plus quieter drag and overlay lines) and record why the bridge owns log VOLUME while AD owns the file and its rotation

John Lauer ·4b7d495ec5 ·3mo ago ·parent 036a403
4 files changed +15−9
adom-bridge-puppeteer-manifest.json+4−4
@@ -1,10 +1,10 @@ {   "manifest_version": 1,   "name": "puppeteer",-  "version": "1.9.72",-  "url": "https://wiki.adom.inc/download/adom/adom-desktop-puppeteer-bridge/1.9.72/adom-bridge-puppeteer-v1.9.72.zip",-  "sha256": "fea6b7c819a9a97e7d5cea8b14b54b171a74915be90f9f3a7e3e0fc7419b6936",-  "size": 308544,+  "version": "1.9.73",+  "url": "https://wiki.adom.inc/download/adom/adom-desktop-puppeteer-bridge/1.9.73/adom-bridge-puppeteer-v1.9.73.zip",+  "sha256": "599c867cc6738caf228089e64f3b32359d6325629674feef39c95db85e80cd20",+  "size": 308819,   "verbPrefixes": [     "browser_",     "desktop_recorder_",
src/BRIDGE_VERSION+1−1
@@ -1 +1 @@-1.9.72+1.9.73
src/bridge.json+1−1
@@ -2,7 +2,7 @@   "manifest_version": 1,   "name": "puppeteer",   "displayName": "Puppeteer (Chrome for Testing + Native)",-  "version": "1.9.72",+  "version": "1.9.73",   "description": "Drives a browser ALREADY on the machine \u2014 installed Chrome, else Microsoft Edge (every Windows PC ships with Edge) \u2014 launched with a FRESH isolated profile, so the common case has NO ~150 MB Chrome-for-Testing download and it never touches the user's real tabs/logins. Binds its local server to LOOPBACK (127.0.0.1) only, so no Windows Firewall 'allow Node through the firewall' prompt ever pops. Chrome for Testing is fetched only as a LAST RESORT if the machine has no Chromium browser at all. SPAWN-VERIFIED fallback: pup tries each detected browser (Chrome \u2192 Edge \u2192 CfT) and actually launches it, falling through to the next if one won't start (and handling browsers like Edge that relaunch onto another PID), so a corrupt/partial install never hard-fails an open. The browser that launches is cached as the default (persisted across restarts) so it isn't re-probed each time. On spawn the bridge SELF-WARMS: detects browsers + disk, and only if the box has no Chrome/Edge and no cached CfT does it background-fetch CfT so the first open is instant. browser_use pins a specific browser (chrome | edge | cft | auto); {browser:'chrome',install:true} downloads & installs REAL Google Chrome (user-scoped, no admin) on an Edge-only box. browser_readiness (READ-ONLY) reports which browser will be used + the full candidate list + the default + free disk. Every failure returns a specific errorCode + _hint (chrome_install_no_disk, chrome_download_network, chrome_install_permission, chrome_stable_not_detected, \u2026). Launches with FULL browser permissions by default for full debug (strictPermissions:true opts out). Headful automation: open/close windows+tabs, navigate, screenshot, eval JS, record. pup is a GENERIC, non-profile browser only \u2014 every session is a fresh isolated Chrome/Edge process, never the user's real signed-in browser; profile defaults to sessionId. To drive the user's REAL Chrome/Edge (their profile, cookies, SSO), use the Adom browser EXTENSION's nbrowser_* verbs \u2014 a separate bridge, not pup's job.",   "homepage": "https://wiki.adom.inc/adom/adom-desktop",   "author": "Adom Inc.",
src/server.js+9−3
@@ -10,9 +10,15 @@ const { execSync, execFileSync, execFile } = require('child_process'); // v1.8.29: run a PowerShell script file with NO console window (windowsHide) and no cmd // shell (execFileSync directly), so pup's window-management PS never flashes a terminal on // the user's screen. -WindowStyle Hidden is belt-and-suspenders. Sync variant returns stdout.-// v1.9.71 — LOG JANITOR. The bridge writes NO log file of its own; AD captures our stdout into-// bridge-stdout.log, so rotation is AD's. What IS ours is the VOLUME, and adding a per-verb audit-// line made that our problem. Collapse consecutive identical lines into one + a repeat count, so a+// v1.9.71 — LOG JANITOR (bridge owns VOLUME; AD owns the FILE).+// Deliberate split, revisited in v1.9.73 and kept:+//   - AD spawns us and captures our stdout, so the FILE and its rotation are AD's. A bridge+//     cannot rotate a file another process opened, and every bridge (incl. third-party ones)+//     needs bounded logs — that has to be a platform guarantee, not per-author boilerplate.+//   - What IS ours is how much we EMIT. A tidy platform cannot save us from being a firehose.+// We briefly wrote our own rotated pup.log and reverted it: two log files means two sources of+// truth and double the disk for the same bytes, and it papered over an AD-side bug worth fixing+// properly (bridge_log_read interleaves AD lifecycle lines with the bridge's own output). Collapse consecutive identical lines into one + a repeat count, so a // retry loop or a chatty page costs 2 lines instead of 200. Only exact repeats are collapsed, so no // distinct event is ever lost. const _origConsoleLog = console.log.bind(console);