← Commit history

Log the missing-favicon case once per session instead of on every tab-badge update

John Lauer ·036a4032d5 ·3mo ago ·parent c6300c4
4 files changed +10−7
adom-bridge-puppeteer-manifest.json+4−4
@@ -1,10 +1,10 @@ {   "manifest_version": 1,   "name": "puppeteer",-  "version": "1.9.71",-  "url": "https://wiki.adom.inc/download/adom/adom-desktop-puppeteer-bridge/1.9.71/adom-bridge-puppeteer-v1.9.71.zip",-  "sha256": "168b25f1f593b0a0b9ab0dc4a1168943a120912c0c865f067bcd4aca69a10d87",-  "size": 308371,+  "version": "1.9.72",+  "url": "https://wiki.adom.inc/download/adom/adom-desktop-puppeteer-bridge/1.9.72/adom-bridge-puppeteer-v1.9.72.zip",+  "sha256": "fea6b7c819a9a97e7d5cea8b14b54b171a74915be90f9f3a7e3e0fc7419b6936",+  "size": 308544,   "verbPrefixes": [     "browser_",     "desktop_recorder_",
src/BRIDGE_VERSION+1−1
@@ -1 +1 @@-1.9.71+1.9.72
src/bridge.json+1−1
@@ -2,7 +2,7 @@   "manifest_version": 1,   "name": "puppeteer",   "displayName": "Puppeteer (Chrome for Testing + Native)",-  "version": "1.9.71",+  "version": "1.9.72",   "description": "Drives a browser ALREADY on the machine \u2014 installed Chrome, else Microsoft Edge (every Windows PC ships with Edge) \u2014 launched with a FRESH isolated profile, so the common case has NO ~150 MB Chrome-for-Testing download and it never touches the user's real tabs/logins. Binds its local server to LOOPBACK (127.0.0.1) only, so no Windows Firewall 'allow Node through the firewall' prompt ever pops. Chrome for Testing is fetched only as a LAST RESORT if the machine has no Chromium browser at all. SPAWN-VERIFIED fallback: pup tries each detected browser (Chrome \u2192 Edge \u2192 CfT) and actually launches it, falling through to the next if one won't start (and handling browsers like Edge that relaunch onto another PID), so a corrupt/partial install never hard-fails an open. The browser that launches is cached as the default (persisted across restarts) so it isn't re-probed each time. On spawn the bridge SELF-WARMS: detects browsers + disk, and only if the box has no Chrome/Edge and no cached CfT does it background-fetch CfT so the first open is instant. browser_use pins a specific browser (chrome | edge | cft | auto); {browser:'chrome',install:true} downloads & installs REAL Google Chrome (user-scoped, no admin) on an Edge-only box. browser_readiness (READ-ONLY) reports which browser will be used + the full candidate list + the default + free disk. Every failure returns a specific errorCode + _hint (chrome_install_no_disk, chrome_download_network, chrome_install_permission, chrome_stable_not_detected, \u2026). Launches with FULL browser permissions by default for full debug (strictPermissions:true opts out). Headful automation: open/close windows+tabs, navigate, screenshot, eval JS, record. pup is a GENERIC, non-profile browser only \u2014 every session is a fresh isolated Chrome/Edge process, never the user's real signed-in browser; profile defaults to sessionId. To drive the user's REAL Chrome/Edge (their profile, cookies, SSO), use the Adom browser EXTENSION's nbrowser_* verbs \u2014 a separate bridge, not pup's job.",   "homepage": "https://wiki.adom.inc/adom/adom-desktop",   "author": "Adom Inc.",
src/server.js+4−1
@@ -2631,7 +2631,10 @@ async function applyAppOverlay(session, sessionId) {         session._faviconRetried = true;         setTimeout(() => { applyAppOverlay(session, sessionId).catch(() => {}); }, 2500);       }-      console.log(`[overlay] "${sessionId}" no favicon on the active tab (retry ${session._faviconRetried ? 'queued' : 'done'})`);+      // v1.9.71: log the missing-favicon case ONCE per session. It was emitted on every tab-badge+      // update, so a faviconless page produced a line per verb — non-consecutive, so the dedupe+      // collapser could not catch it. The fact is static per page; repeating it says nothing new.+      if (!session._noFavLogged) { session._noFavLogged = true; console.log(`[overlay] "${sessionId}" no favicon on the active tab (retry ${session._faviconRetried ? 'queued' : 'done'})`); }       session._appOverlay = false;       return false;     }