← Commit history

Notch margin symmetry (John: 2px cutout on the left of the overlay but only 1px below - unprofessional). The inner (bottom-left) corner radius curved the notch inward where the favicon's bottom-left sits, eating the bottom margin while the straight left edge kept its full margin. Dropped the inner-corner radius to near-sharp (rx 11% -> 2%) so both the left and bottom cutouts are uniform straight edges = even margin around the overlay. Bumped PUP_ICON_GEN i4->i5 so live buttons re-stamp with the new geometry.

John Lauer ·3581702879 ·3mo ago ·parent 7b5287a
4 files changed +13−8
adom-bridge-puppeteer-manifest.json+4−4
@@ -1,10 +1,10 @@ {   "manifest_version": 1,   "name": "puppeteer",-  "version": "1.9.332",-  "url": "https://wiki.adom.inc/download/adom/adom-desktop-puppeteer-bridge/1.9.332/adom-bridge-puppeteer-v1.9.332.zip",-  "sha256": "e557e82becc721a1d7d7fc0c66bf7337c88f79ec6d1b6fd68f0179441008a27b",-  "size": 625463,+  "version": "1.9.333",+  "url": "https://wiki.adom.inc/download/adom/adom-desktop-puppeteer-bridge/1.9.333/adom-bridge-puppeteer-v1.9.333.zip",+  "sha256": "4fd2876b09e03a059339ddf191fcf664a3fd6af63f4016304d45fa9dfc4ecf3c",+  "size": 625701,   "verbPrefixes": [     "browser_",     "desktop_recorder_",
src/BRIDGE_VERSION+1−1
@@ -1 +1 @@-1.9.332+1.9.333
src/bridge.json+1−1
@@ -2,7 +2,7 @@   "manifest_version": 1,   "name": "puppeteer",   "displayName": "Puppeteer (Chrome for Testing + Native)",-  "version": "1.9.332",+  "version": "1.9.333",   "description": "Drives a browser ALREADY on the machine \u2014 installed Chrome, else Microsoft Edge (every Windows PC ships with Edge) \u2014 launched with a FRESH isolated profile, so the common case has NO ~150 MB Chrome-for-Testing download and it never touches the user's real tabs/logins. Binds its local server to LOOPBACK (127.0.0.1) only, so no Windows Firewall 'allow Node through the firewall' prompt ever pops. Chrome for Testing is fetched only as a LAST RESORT if the machine has no Chromium browser at all. SPAWN-VERIFIED fallback: pup tries each detected browser (Chrome \u2192 Edge \u2192 CfT) and actually launches it, falling through to the next if one won't start (and handling browsers like Edge that relaunch onto another PID), so a corrupt/partial install never hard-fails an open. The browser that launches is cached as the default (persisted across restarts) so it isn't re-probed each time. On spawn the bridge SELF-WARMS: detects browsers + disk, and only if the box has no Chrome/Edge and no cached CfT does it background-fetch CfT so the first open is instant. browser_use pins a specific browser (chrome | edge | cft | auto); {browser:'chrome',install:true} downloads & installs REAL Google Chrome (user-scoped, no admin) on an Edge-only box. browser_readiness (READ-ONLY) reports which browser will be used + the full candidate list + the default + free disk. Every failure returns a specific errorCode + _hint (chrome_install_no_disk, chrome_download_network, chrome_install_permission, chrome_stable_not_detected, \u2026). Launches with FULL browser permissions by default for full debug (strictPermissions:true opts out). Headful automation: open/close windows+tabs, navigate, screenshot, eval JS, record. pup is a GENERIC, non-profile browser only \u2014 every session is a fresh isolated Chrome/Edge process, never the user's real signed-in browser; profile defaults to sessionId. To drive the user's REAL Chrome/Edge (their profile, cookies, SSO), use the Adom browser EXTENSION's nbrowser_* verbs \u2014 a separate bridge, not pup's job. macOS (v1.9.74+): full parity with mac-native mechanics \u2014 background-by-default is the app-level hide (windows stay drivable/screenshottable while hidden), raise/lower map to unhide+activate/hide, browser_alert_window posts a native toast whose click focuses the window, browser_use {browser:'chrome',install:true} installs Chrome from the official dmg, and taskbar identity/badging remains Windows-only.",   "homepage": "https://wiki.adom.inc/adom/adom-desktop",   "author": "Adom Inc.",
src/server.js+7−2
@@ -2986,7 +2986,7 @@ const PUP_ICON_DEFAULT = 'pup-cat-default9.ico'; // already-created ones white, because their tiles were baked while the AUMID was still unbranded. // Folding a generation token into the appId turns an icon change into a NEW appId, which forces the // shell to create a NEW button, which is the ONLY thing that repaints. Cost is one button rebuild.-const PUP_ICON_GEN = 'i4';   // i4: NOTCHED tiles (square notch + baked Adom-mark fallback). BUMPED because the+const PUP_ICON_GEN = 'i5';   // i5: near-sharp square notch (even L-margin around the overlay). BUMPED because the // icon FILES changed — the AUMID appId carries this token, so a new gen forces Windows to CREATE A NEW // BUTTON that reads the new (notched) icon. Same-appId re-stamps do NOT repaint a baked Win11 tile, which // is why the notch never appeared on the live button until this bump. (i3 = pre-notch PNG-frame icons.)@@ -3055,7 +3055,12 @@ function pupIconPath(sessionId) { // that by extending the mask rect PAST the top/right edges (`over`) so those corners fall off-canvas // and only the inner (bottom-left) corner shows the radius — instead of a rounded-rect that rounds all // four corners into a blob.-const NOTCH = { frac: 0.50, over: 0.16, rx: 0.11 };   // square side = 50% of tile; inner-corner radius 11% of tile+// v1.9.333 (John: "2px cutout on the LEFT of the overlay but only 1px BELOW it — unprofessional").+// The inner (bottom-left) corner radius curved the notch inward exactly where the favicon's bottom-left+// sits, eating the BOTTOM margin while the straight LEFT edge kept its full margin → the asymmetry. A+// near-sharp inner corner makes both the left and bottom cutouts uniform straight edges, so the margin+// around the overlay is even. (rx 0.02 ≈ a hair of anti-alias softening, effectively square at 16px.)+const NOTCH = { frac: 0.50, over: 0.16, rx: 0.02 };   // square side = 50% of tile; inner corner near-sharp for an EVEN margin const _NOTCH_CACHE = path.join(os.tmpdir(), 'pup-notched-icons', PUP_ICON_GEN + '-sq2');   // -sq2: square notch + baked Adom-mark fallback let _notchDone = false; function notchedIconPath(origPath) {