← Commit history

Fix: the 'Switch to logged-in view' jump-list task did nothing. browser_wiki_set_view short-circuited with unchanged:true (only bringToFront) whenever pup BELIEVED the window was already in the requested view — but the task promises a harmless reload and pup's view belief is unreliable (default-authed may not have actually signed in; cookies expire). Now a real USER click (caller aiThread user-taskbar-menu) ALWAYS re-asserts the view via the mint/navigate path (a genuine reload that guarantees signed-in), instead of skipping. Programmatic same-view calls still short-circuit.

John Lauer ·7b5287a2dc ·3mo ago ·parent 4cc722d
4 files changed +23−11
adom-bridge-puppeteer-manifest.json+4−4
@@ -1,10 +1,10 @@ {   "manifest_version": 1,   "name": "puppeteer",-  "version": "1.9.331",-  "url": "https://wiki.adom.inc/download/adom/adom-desktop-puppeteer-bridge/1.9.331/adom-bridge-puppeteer-v1.9.331.zip",-  "sha256": "9ed6588907fc68956e81444971277e55ec05c7d5982edeb3ed7e0d9eba78d693",-  "size": 625022,+  "version": "1.9.332",+  "url": "https://wiki.adom.inc/download/adom/adom-desktop-puppeteer-bridge/1.9.332/adom-bridge-puppeteer-v1.9.332.zip",+  "sha256": "e557e82becc721a1d7d7fc0c66bf7337c88f79ec6d1b6fd68f0179441008a27b",+  "size": 625463,   "verbPrefixes": [     "browser_",     "desktop_recorder_",
src/BRIDGE_VERSION+1−1
@@ -1 +1 @@-1.9.331+1.9.332
src/bridge.json+1−1
@@ -2,7 +2,7 @@   "manifest_version": 1,   "name": "puppeteer",   "displayName": "Puppeteer (Chrome for Testing + Native)",-  "version": "1.9.331",+  "version": "1.9.332",   "description": "Drives a browser ALREADY on the machine \u2014 installed Chrome, else Microsoft Edge (every Windows PC ships with Edge) \u2014 launched with a FRESH isolated profile, so the common case has NO ~150 MB Chrome-for-Testing download and it never touches the user's real tabs/logins. Binds its local server to LOOPBACK (127.0.0.1) only, so no Windows Firewall 'allow Node through the firewall' prompt ever pops. Chrome for Testing is fetched only as a LAST RESORT if the machine has no Chromium browser at all. SPAWN-VERIFIED fallback: pup tries each detected browser (Chrome \u2192 Edge \u2192 CfT) and actually launches it, falling through to the next if one won't start (and handling browsers like Edge that relaunch onto another PID), so a corrupt/partial install never hard-fails an open. The browser that launches is cached as the default (persisted across restarts) so it isn't re-probed each time. On spawn the bridge SELF-WARMS: detects browsers + disk, and only if the box has no Chrome/Edge and no cached CfT does it background-fetch CfT so the first open is instant. browser_use pins a specific browser (chrome | edge | cft | auto); {browser:'chrome',install:true} downloads & installs REAL Google Chrome (user-scoped, no admin) on an Edge-only box. browser_readiness (READ-ONLY) reports which browser will be used + the full candidate list + the default + free disk. Every failure returns a specific errorCode + _hint (chrome_install_no_disk, chrome_download_network, chrome_install_permission, chrome_stable_not_detected, \u2026). Launches with FULL browser permissions by default for full debug (strictPermissions:true opts out). Headful automation: open/close windows+tabs, navigate, screenshot, eval JS, record. pup is a GENERIC, non-profile browser only \u2014 every session is a fresh isolated Chrome/Edge process, never the user's real signed-in browser; profile defaults to sessionId. To drive the user's REAL Chrome/Edge (their profile, cookies, SSO), use the Adom browser EXTENSION's nbrowser_* verbs \u2014 a separate bridge, not pup's job. macOS (v1.9.74+): full parity with mac-native mechanics \u2014 background-by-default is the app-level hide (windows stay drivable/screenshottable while hidden), raise/lower map to unhide+activate/hide, browser_alert_window posts a native toast whose click focuses the window, browser_use {browser:'chrome',install:true} installs Chrome from the official dmg, and taskbar identity/badging remains Windows-only.",   "homepage": "https://wiki.adom.inc/adom/adom-desktop",   "author": "Adom Inc.",
src/server.js+17−5
@@ -10898,11 +10898,23 @@ const server = http.createServer(async (req, res) => {           const owner = session.owner || null;           const publicProfile = session._publicProfile || sessionId;           if (curView === view) {-            // Already in the requested view — just surface it (user clicked to see this window).-            session._foreground = true;-            try { await session.page.bringToFront(); } catch (e) {}-            sendJSON(res, { success: true, output: JSON.stringify({ ok: true, view, unchanged: true, url }) });-            return;+            // v1.9.332 (John clicked "Switch to logged-in view" and "it did nothing"). pup BELIEVED the+            // window was already in this view, so it only brought it to front — no reload. But the task+            // PROMISES a "harmless reload", and pup's view belief is unreliable (a cookie expired, another+            // window flipped auth, or the initial default-authed never actually signed the page in). So a+            // real USER click ALWAYS re-asserts the requested view: it falls through to the mint/navigate+            // path below, which is a genuine reload that GUARANTEES the page is in that view (for authed it+            // re-mints + navigates, i.e. actually signs it in). Only a PROGRAMMATIC same-view call short-+            // circuits with bringToFront.+            const _userClick = _callerThread === 'user-taskbar-menu' || ((args.caller && args.caller.aiThread) === 'user-taskbar-menu');+            if (!_userClick) {+              session._foreground = true;+              try { await session.page.bringToFront(); } catch (e) {}+              sendJSON(res, { success: true, output: JSON.stringify({ ok: true, view, unchanged: true, url }) });+              return;+            }+            console.log(`[wikiview] "${sessionId}" user clicked "${view}" while pup thought it was already ${curView} — re-asserting the view (harmless reload), NOT skipping (this is why the click "did nothing")`);+            // fall through to the switch logic below, which navigates/asserts the requested view           }           // v1.9.63 — IN-PLACE view switch, no close-and-relaunch.           //