← Commit history

Recovered windows restore their persisted OS handle on the rescan adoption path too (not just recoverSessions), so a multi-window-profile window that lost its handle to a respawn goes green from the saved handle instead of red now that the wiggle is gone

John Lauer ·1192e30638 ·3mo ago ·parent 08efd83
4 files changed +12−6
adom-bridge-puppeteer-manifest.json+4−4
@@ -1,10 +1,10 @@ {   "manifest_version": 1,   "name": "puppeteer",-  "version": "1.9.309",-  "url": "https://wiki.adom.inc/download/adom/adom-desktop-puppeteer-bridge/1.9.309/adom-bridge-puppeteer-v1.9.309.zip",-  "sha256": "ce1111f7883b300f168ad67a2c97e103e3a9041d842b055327d2b445a4edc78f",-  "size": 727873,+  "version": "1.9.310",+  "url": "https://wiki.adom.inc/download/adom/adom-desktop-puppeteer-bridge/1.9.310/adom-bridge-puppeteer-v1.9.310.zip",+  "sha256": "68fa6ddf42258aed0a5adeeb1a848975b6e2a5bf70088b9d7b205811fea3c598",+  "size": 728030,   "verbPrefixes": [     "browser_",     "desktop_recorder_",
src/BRIDGE_VERSION+1−1
@@ -1 +1 @@-1.9.309+1.9.310
src/bridge.json+1−1
@@ -2,7 +2,7 @@   "manifest_version": 1,   "name": "puppeteer",   "displayName": "Puppeteer (Chrome for Testing + Native)",-  "version": "1.9.309",+  "version": "1.9.310",   "description": "Drives a browser ALREADY on the machine \u2014 installed Chrome, else Microsoft Edge (every Windows PC ships with Edge) \u2014 launched with a FRESH isolated profile, so the common case has NO ~150 MB Chrome-for-Testing download and it never touches the user's real tabs/logins. Binds its local server to LOOPBACK (127.0.0.1) only, so no Windows Firewall 'allow Node through the firewall' prompt ever pops. Chrome for Testing is fetched only as a LAST RESORT if the machine has no Chromium browser at all. SPAWN-VERIFIED fallback: pup tries each detected browser (Chrome \u2192 Edge \u2192 CfT) and actually launches it, falling through to the next if one won't start (and handling browsers like Edge that relaunch onto another PID), so a corrupt/partial install never hard-fails an open. The browser that launches is cached as the default (persisted across restarts) so it isn't re-probed each time. On spawn the bridge SELF-WARMS: detects browsers + disk, and only if the box has no Chrome/Edge and no cached CfT does it background-fetch CfT so the first open is instant. browser_use pins a specific browser (chrome | edge | cft | auto); {browser:'chrome',install:true} downloads & installs REAL Google Chrome (user-scoped, no admin) on an Edge-only box. browser_readiness (READ-ONLY) reports which browser will be used + the full candidate list + the default + free disk. Every failure returns a specific errorCode + _hint (chrome_install_no_disk, chrome_download_network, chrome_install_permission, chrome_stable_not_detected, \u2026). Launches with FULL browser permissions by default for full debug (strictPermissions:true opts out). Headful automation: open/close windows+tabs, navigate, screenshot, eval JS, record. pup is a GENERIC, non-profile browser only \u2014 every session is a fresh isolated Chrome/Edge process, never the user's real signed-in browser; profile defaults to sessionId. To drive the user's REAL Chrome/Edge (their profile, cookies, SSO), use the Adom browser EXTENSION's nbrowser_* verbs \u2014 a separate bridge, not pup's job. macOS (v1.9.74+): full parity with mac-native mechanics \u2014 background-by-default is the app-level hide (windows stay drivable/screenshottable while hidden), raise/lower map to unhide+activate/hide, browser_alert_window posts a native toast whose click focuses the window, browser_use {browser:'chrome',install:true} installs Chrome from the official dmg, and taskbar identity/badging remains Windows-only.",   "homepage": "https://wiki.adom.inc/adom/adom-desktop",   "author": "Adom Inc.",
src/server.js+6
@@ -1509,6 +1509,12 @@ async function rescanProfile(browser, profileName, { adoptOrphans = false } = {}     if (!session) {       session = createSession(profileName);       session._sessionId = sessionId; // v1.8.43: for AD taskbar/flash titleContains resolution+      // v1.9.310: restore the PERSISTED OS handle on this adoption path too. Without the width-wiggle,+      // a re-adopted window on a MULTI-window profile has no way to re-derive its handle — but the+      // window kept the SAME hwnd across the respawn, so the persisted value is still correct (and+      // hwndBelongsToPup validates it before any use). This is what keeps recovered windows GREEN+      // instead of red after the wiggle removal. recoverSessions already did this; rescan now matches.+      try { const _sf = readSessionFile(sessionId); if (_sf && _sf._hwnd) session._hwnd = Number(_sf._hwnd); } catch (e) {}       sessions.set(sessionId, session);     } else if (session.profileName !== profileName) {       // SessionId collision across profiles — shouldn't happen in practice