Pup - the AI's own browser

@@ -3572,7 +3572,7 @@ async function setSessionProgress(sessionId, busy) {   if (process.platform !== 'win32') return;   try {     await chrome.adCommand('desktop_taskbar', {-      titleContains: `(${TITLE_LABEL}: ${sessionId}`,+      ...(await windowTarget(sessions.get(sessionId), sessionId)),       progress: busy ? { state: 'indeterminate' } : { state: 'none' },     }, { timeoutMs: 4000 });   } catch (e) {}@@ -3731,7 +3731,7 @@ async function updateThumbnailTooltip(session, sessionId) {   if (session._thumbTip === tip) return;   // idempotent: only push real changes   try {     const r = await chrome.adCommand('desktop_taskbar', {-      titleContains: `(${TITLE_LABEL}: ${sessionId}`, thumbnailTooltip: tip,+      ...(await windowTarget(sessions.get(sessionId), sessionId)), thumbnailTooltip: tip,     }, { timeoutMs: 5000, caller: sessionCaller(session) });     const raw = r && (typeof r.output === 'string' ? r.output : JSON.stringify(r.output || ''));     if (_isUnknownVerb(r, raw) || /unknown (arg|field)|unexpected (arg|field)/i.test(raw || '')) {@@ -3794,8 +3794,8 @@ async function updateTabCountBadge(session, sessionId) {       else if (totalTabs >= 2) icon = tabBadgeIcon(totalTabs); // single window: plain tab count       for (const [sid2] of sessions) {         const args2 = icon-          ? { titleContains: `(${TITLE_LABEL}: ${sid2}`, overlay: { icon, tooltip: `Adom Pup — ${wins} window${wins === 1 ? '' : 's'}, ${totalTabs} tab${totalTabs === 1 ? '' : 's'}` } }-          : { titleContains: `(${TITLE_LABEL}: ${sid2}`, overlay: { badge: 'none' } };+          ? { ...(await windowTarget(sessions.get(sid2), sid2)), overlay: { icon, tooltip: `Adom Pup — ${wins} window${wins === 1 ? '' : 's'}, ${totalTabs} tab${totalTabs === 1 ? '' : 's'}` } }+          : { ...(await windowTarget(sessions.get(sid2), sid2)), overlay: { badge: 'none' } };         try { await chrome.adCommand('desktop_taskbar', args2, { timeoutMs: 5000 }); } catch (e) {}       }       return;@@ -3813,12 +3813,12 @@ async function updateTabCountBadge(session, sessionId) {       if (!icon) return;       session._overlayDesc = `count:${count} (no favicon on the active tab, so the tab-count badge)`;       await chrome.adCommand('desktop_taskbar', {-        titleContains: `(${TITLE_LABEL}: ${sessionId}`,+        ...(await windowTarget(sessions.get(sessionId), sessionId)),         overlay: { icon, tooltip: `Adom Pup — ${count} tabs` },       }, { timeoutMs: 5000 });     } else {       await chrome.adCommand('desktop_taskbar', {-        titleContains: `(${TITLE_LABEL}: ${sessionId}`,+        ...(await windowTarget(sessions.get(sessionId), sessionId)),         overlay: { badge: 'none' },       }, { timeoutMs: 5000 });     }@@ -4950,6 +4950,22 @@ async function enumChromeWidgetWindows() {     return rows;   } catch (e) { return []; } }+// v1.9.309 (John: "how many times did you say you couldn't look up a window by title... you keep+// duct-taping it instead of a permanent solution"). He counted right — 23 call sites resolved a+// window by its "(ai-thread: X)" TITLE, and that same unreliable lookup independently broke the+// overlay, the park, the flash, and the AUMID stamp. THE PERMANENT FIX: one way to name a session's+// OS window for every AD window verb — its HANDLE. windowTarget() resolves + validates the hwnd+// (read-only; it never resizes anything) and returns { hwnd }. Every operation spreads this, so hwnd+// is primary everywhere; titleContains remains ONLY as a last-ditch fallback for a window we somehow+// never got a handle for. As birth-time capture + persistence cover every window, the fallback goes+// cold and title stops mattering for targeting at all.+async function windowTarget(session, sessionId) {+  try {+    if (session && !session._hwnd) { await resolveSessionHwndByBounds(session, sessionId); }+    if (session && session._hwnd && await hwndBelongsToPup(session._hwnd, session)) return { hwnd: Number(session._hwnd) };+  } catch (e) {}+  return { titleContains: `(${TITLE_LABEL}: ${sessionId}` };+} async function resolveSessionHwndByBounds(session, sessionId) {   if (process.platform !== 'win32' || !session) return null;   let _releaseWiggle = null;   // v1.9.291: hoisted so the outer catch can always release the lock@@ -5675,7 +5691,7 @@ async function badgePupTaskbar(sessionId) {   // silently never appeared and every later attempt was debounced away.   try {     const r = await chrome.adCommand('desktop_taskbar', {-      titleContains: `(${TITLE_LABEL}: ${sessionId}`,+      ...(await windowTarget(sessions.get(sessionId), sessionId)),       overlay: { icon, tooltip: 'Adom pup — driven from the cloud' },     }, { timeoutMs: 6000 });     const raw = r && (typeof r.output === 'string' ? r.output : JSON.stringify(r.output || r));@@ -6318,7 +6334,7 @@ async function parkSessionWindowDirect(page, sessionId) {         // At launch, foreground is NOT a user signal (post-restart reassignment), so pup always         // forces. On AD 1.9.114 the arg is ignored (skip-on-foreground) and the wasForeground         // fallback below covers it; that fallback auto-obsoletes as desktops update.-        const r = await chrome.adCommand('desktop_set_window_state', { titleContains: `(${TITLE_LABEL}: ${sessionId}`, state: 'bottom', force: true }, { timeoutMs: 5000 , caller: sessionCaller(sessions.get(sessionId))});+        const r = await chrome.adCommand('desktop_set_window_state', { ...(await windowTarget(sessions.get(sessionId), sessionId)), state: 'bottom', force: true }, { timeoutMs: 5000 , caller: sessionCaller(sessions.get(sessionId))});         if (r && r.success === false) return { ok: false, err: r.error || 'error' };         const raw = r && (typeof r.output === 'string' ? r.output : JSON.stringify(r.output || ''));         const o = raw ? JSON.parse(raw) : {};@@ -6438,7 +6454,7 @@ async function reassertBottomAfterNav(sessionId) {     }   } catch (e) {}   try {-    await chrome.adCommand('desktop_set_window_state', { titleContains: `(${TITLE_LABEL}: ${sessionId}`, state: 'bottom', force: false }, { timeoutMs: 5000 , caller: sessionCaller(sessions.get(sessionId))});+    await chrome.adCommand('desktop_set_window_state', { ...(await windowTarget(sessions.get(sessionId), sessionId)), state: 'bottom', force: false }, { timeoutMs: 5000 , caller: sessionCaller(sessions.get(sessionId))});   } catch (e) {} } @@ -10196,7 +10212,7 @@ const server = http.createServer(async (req, res) => {           // force:false touches nothing but z, and respects a user-held window.           if (!foreground && sized) {             try {-              await chrome.adCommand('desktop_set_window_state', { titleContains: `(${TITLE_LABEL}: ${sessionId}`, state: 'bottom', force: false }, { timeoutMs: 5000 , caller: sessionCaller(sessions.get(sessionId))});+              await chrome.adCommand('desktop_set_window_state', { ...(await windowTarget(sessions.get(sessionId), sessionId)), state: 'bottom', force: false }, { timeoutMs: 5000 , caller: sessionCaller(sessions.get(sessionId))});             } catch (e) {}           }           // v1.8.26: record whether this window is meant to be on screen — gates every@@ -11055,7 +11071,7 @@ const server = http.createServer(async (req, res) => {                   id: toastId, level: 'info', scenario: 'reminder',                   title: 'A pup window wants your attention',                   body: `Session "${sid}" has something to show — click to bring it up.`,-                  focus: { titleContains: `(${TITLE_LABEL}: ${sid}` },+                  focus: { ...(await windowTarget(sessions.get(sid), sid)) },                 }, { timeoutMs: 6000 });                 applied = !!(r2 && r2.success !== false);               } catch (e) {}@@ -11798,7 +11814,7 @@ const server = http.createServer(async (req, res) => {               return;             }             await pupCaption(`Adom is clicking ${_label} now.`, 5000);-            const shot = adPayload(await chrome.adCommand('desktop_screenshot_window', { titleContains: `(${TITLE_LABEL}: ${resolvedId}` }, { timeoutMs: 8000, caller: sessionCaller(session) }));+            const shot = adPayload(await chrome.adCommand('desktop_screenshot_window', { ...(await windowTarget(sessions.get(resolvedId), resolvedId)) }, { timeoutMs: 8000, caller: sessionCaller(session) }));             const shotId = shot && (shot.shotId || (shot.screenshots && shot.screenshots[0] && shot.screenshots[0].shotId));             if (!shotId) { sendJSON(res, { success: false, error: 'could not capture the window to aim the click' }); return; }             const X = Math.round(Number(args.x)), Y = Math.round(Number(args.y));