Pup - the AI's own browser

@@ -326,7 +326,18 @@ const _launchInFlight = new Map(); // a fleet of AI threads opening default windows simultaneously is the 10,000-user case. const _profileOpenChain = new Map(); // profileName -> tail promise let _tabClaimSeq = 0; // monotonic per-call marker for in-window tab adoption (see addTabToSession)-let _birthSeq = 0;    // monotonic counter for unique off-screen birth positions (birth-time hwnd resolution)+let _birthSeq = 0;+// v2.0.38: SERIALIZE window creation so the set-diff birth capture always sees EXACTLY ONE new+// window handle (position is unreliable — Chrome clamps our -32000 birth coord on-screen, so we+// cannot identify the window by where it is; but "the one handle that appeared while I held the+// lock" is unambiguous regardless of position or concurrency across threads).+let _birthLock = Promise.resolve();+function withBirthLock(fn) {+  const prev = _birthLock;+  let release;+  _birthLock = new Promise(r => { release = r; });+  return prev.then(fn).finally(() => release());+}    // monotonic counter for unique off-screen birth positions (birth-time hwnd resolution) let _regenBusy = false;   // a dashboard "regenerate all overlays" sweep is in flight let _lastRegen = null;    // { at, done, swept, painted, changed, results[] } from the last sweep const _overlayRefreshTimers = new Map(); // per-session debounce for the centralized post-verb overlay re-sync@@ -7523,10 +7534,6 @@ async function createPageInNewWindow(browser, profileName) {   const birthLeft = -32000 - ((_birthSeq++ % 60) * 220);   // v2.0.35: 220px apart (was 40) so set-diff's nearest-match can't cross-wire adjacent births   try {     const before = new Set(await browser.pages());-    // v2.0.34: snapshot existing OS window handles BEFORE creating, so the SET-DIFF below identifies-    // the new window unambiguously — coordinate matching alone collided concurrent births.-    let _beforeHwnds = new Set();-    if (process.platform === 'win32') { try { _beforeHwnds = new Set((await enumChromeWidgetWindows()).map(r => Number(r.h))); } catch (e) {} }     cdp = await browser.target().createCDPSession();     // v1.9.144 (John: "you keep opening pup windows on top of the one i'm working in") — birth     // the window OFF-SCREEN so the moment between creation and the park is invisible. 1.9.135@@ -7541,43 +7548,41 @@ async function createPageInNewWindow(browser, profileName) {     // their screen. This is the at-the-source fix; parks and re-asserts then act on an unfocused     // window (osBottomUnlessForeground no longer mistakes the creation-grab for user intent).     const prevFg = await osGetForegroundWindow();-    await cdp.send('Target.createTarget', { url: 'about:blank', newWindow: true, left: birthLeft, top: -32000, width: 1280, height: 800 });-    let fresh = null;-    for (let i = 0; i < 50 && !fresh; i++) {-      fresh = (await browser.pages()).find(p => !before.has(p));-      if (!fresh) await new Promise(r => setTimeout(r, 100));-    }-    // Resolve the OS handle NOW, by the unique off-screen birth position, before park moves it on--    // screen. Parked siblings are at positive L; only newborns sit far off-screen, so "the off-screen-    // window of this profile at ~birthLeft" is unambiguous. Stash it on the page for the resolver.-    console.log(`[hwnd-dbg] birth block: fresh=${!!fresh} win32=${process.platform==='win32'} profile=${profileName} beforeHwnds=${_beforeHwnds.size} birthLeft=${birthLeft}`);-    if (fresh && process.platform === 'win32' && profileName) {-      try {-        // v2.0.34: SET-DIFF birth capture. The window that just APPEARED in the birth zone (off-screen,-        // and NOT present before createTarget, and not already owned by another session) is ours by-        // construction. If concurrency put several new windows there at once, disambiguate by MY unique-        // birthLeft with a TIGHT tolerance (births are 40px apart, so >18px would cross-wire — the-        // fusion+nb-shared-hwnd bug). No coordinate-only match, no pid filter.-        let picked = null;-        for (let i = 0; i < 15 && !picked; i++) {+    // v2.0.38: hold the birth lock across snapshot -> create -> capture so exactly one OS window+    // appears in the diff. `capturedHwnd` is set inside; the page-find stays outside is fine because+    // the page target is unique per createTarget regardless.+    let fresh = null, capturedHwnd = null;+    await withBirthLock(async () => {+      let beforeHwnds = new Set();+      if (process.platform === 'win32') { try { beforeHwnds = new Set((await enumChromeWidgetWindows()).map(r => Number(r.h))); } catch (e) {} }+      await cdp.send('Target.createTarget', { url: 'about:blank', newWindow: true, left: birthLeft, top: -32000, width: 1280, height: 800 });+      for (let i = 0; i < 50 && !fresh; i++) {+        fresh = (await browser.pages()).find(p => !before.has(p));+        if (!fresh) await new Promise(r => setTimeout(r, 100));+      }+      if (process.platform === 'win32') {+        for (let i = 0; i < 20 && !capturedHwnd; i++) {           const rows = await enumChromeWidgetWindows();-          const newOff = rows.filter(r => r.T < -10000 && !_beforeHwnds.has(Number(r.h)) && !hwndOwnedByOtherSession(r.h, null));-          if (i === 0 || i === 6) console.log(`[hwnd-dbg] iter ${i}: rows=${rows.length} offscreen=${rows.filter(r=>r.T<-10000).length} newOff=${newOff.length} sampleTop=${rows.slice(0,3).map(r=>r.T).join(',')}`);-          if (newOff.length === 1) picked = newOff[0].h;-          else if (newOff.length > 1) {-            // v2.0.35: pick the NEW off-screen window NEAREST my birthLeft (across DPI scales). Births-            // are 220px apart now, so nearest is unambiguous against Chrome's small placement jitter;-            // no hard tolerance to be too-tight (18px failed) or too-loose (60px cross-wired).-            let best = null, bestErr = 1e9;-            for (const r of newOff) for (const sc of [1, 1.25, 1.5, 1.75, 2]) { const e = Math.abs(r.L - Math.round(birthLeft * sc)); if (e < bestErr) { bestErr = e; best = r.h; } }-            if (best && bestErr <= 140) picked = best;+          const fresh2 = rows.filter(r => !beforeHwnds.has(Number(r.h)) && !hwndOwnedByOtherSession(r.h, null));+          if (fresh2.length === 1) { capturedHwnd = fresh2[0].h; break; }+          if (fresh2.length > 1) {+            // more than one appeared despite the lock (a sibling thread's stuck-off-screen leftover+            // enumerated late): prefer the off-screen one, else the one nearest my birthLeft.+            const off = fresh2.filter(r => r.T < -10000);+            const pool = off.length ? off : fresh2;+            let best = pool[0].h, bestErr = 1e9;+            for (const r of pool) for (const sc of [1, 1.25, 1.5, 1.75, 2]) { const e = Math.abs(r.L - Math.round(birthLeft * sc)); if (e < bestErr) { bestErr = e; best = r.h; } }+            capturedHwnd = best; break;           }-          if (!picked) await new Promise(r => setTimeout(r, 120));+          await new Promise(r => setTimeout(r, 120));         }-        if (picked) { fresh.__pupHwnd = picked; console.log(`[hwnd] birth-resolved new window on "${profileName}" -> ${picked} (off-screen L≈${birthLeft}, set-diff)`); }-        else console.log(`[hwnd] birth capture on "${profileName}" left AMBIGUOUS (concurrent births) — will resolve later`);-      } catch (e) { console.log(`[hwnd-dbg] birth block THREW: ${e.message}`); }-    }+      }+    });+    // Resolve the OS handle NOW, by the unique off-screen birth position, before park moves it on-+    // screen. Parked siblings are at positive L; only newborns sit far off-screen, so "the off-screen+    // window of this profile at ~birthLeft" is unambiguous. Stash it on the page for the resolver.+    if (fresh && capturedHwnd) { fresh.__pupHwnd = capturedHwnd; console.log(`[hwnd] birth-resolved new window on "${profileName}" -> ${capturedHwnd} (locked set-diff, birthLeft ${birthLeft})`); }+    else if (fresh) console.log(`[hwnd] birth capture on "${profileName}" produced no handle — will resolve later`);     try {       const nowFg = await osGetForegroundWindow();       // Diagnostic only. The playbook (dev-skills/pup-bridge-dev, SOLVED PLAYBOOK) says this can