← Commit history

THE root cause of the raw-Chrome taskbar icons: only the 2nd-plus window on a profile went through the birth-capture path that assigns an OS hwnd; the FIRST window on a profile used browser.newPage() which captures no handle, so after 2.0.24 removed the title-tag fallback that first window was permanently unresolvable and showed a raw Chrome button with no AUMID and no overlay. Now every pup window on Windows is created through createPageInNewWindow (off-screen birth + set-diff capture), so all of them get a reliable, unique handle. Keeps the 2.0.36 diagnostics one more build to confirm

John Lauer ·5518892786 ·2mo ago ·parent b59b78d
4 files changed +15−6
adom-bridge-puppeteer-manifest.json+4−4
@@ -1,10 +1,10 @@ {   "manifest_version": 1,   "name": "puppeteer",-  "version": "2.0.36",-  "url": "https://wiki.adom.inc/download/adom/pup-bridge/2.0.36/adom-bridge-puppeteer-v2.0.36.zip",-  "sha256": "28541abac4a288486306803829bd7803dfbfa43466cc9e6108a16bf067352d5d",-  "size": 643280,+  "version": "2.0.37",+  "url": "https://wiki.adom.inc/download/adom/pup-bridge/2.0.37/adom-bridge-puppeteer-v2.0.37.zip",+  "sha256": "5b1814b6f5be6a914e359afda9f9555f592f3f084fe17cc5e1133dc524745437",+  "size": 643519,   "verbPrefixes": [     "browser_",     "desktop_recorder_",
src/BRIDGE_VERSION+1−1
@@ -1 +1 @@-2.0.36+2.0.37
src/bridge.json+1−1
@@ -2,7 +2,7 @@   "manifest_version": 1,   "name": "puppeteer",   "displayName": "Puppeteer (Chrome for Testing + Native)",-  "version": "2.0.36",+  "version": "2.0.37",   "description": "Drives a browser ALREADY on the machine \u2014 installed Chrome, else Microsoft Edge (every Windows PC ships with Edge) \u2014 launched with a FRESH isolated profile, so the common case has NO ~150 MB Chrome-for-Testing download and it never touches the user's real tabs/logins. Binds its local server to LOOPBACK (127.0.0.1) only, so no Windows Firewall 'allow Node through the firewall' prompt ever pops. Chrome for Testing is fetched only as a LAST RESORT if the machine has no Chromium browser at all. SPAWN-VERIFIED fallback: pup tries each detected browser (Chrome \u2192 Edge \u2192 CfT) and actually launches it, falling through to the next if one won't start (and handling browsers like Edge that relaunch onto another PID), so a corrupt/partial install never hard-fails an open. The browser that launches is cached as the default (persisted across restarts) so it isn't re-probed each time. On spawn the bridge SELF-WARMS: detects browsers + disk, and only if the box has no Chrome/Edge and no cached CfT does it background-fetch CfT so the first open is instant. pup_use pins a specific browser (chrome | edge | cft | auto); {browser:'chrome',install:true} downloads & installs REAL Google Chrome (user-scoped, no admin) on an Edge-only box. pup_readiness (READ-ONLY) reports which browser will be used + the full candidate list + the default + free disk. Every failure returns a specific errorCode + _hint (chrome_install_no_disk, chrome_download_network, chrome_install_permission, chrome_stable_not_detected, \u2026). Launches with FULL browser permissions by default for full debug (strictPermissions:true opts out). Headful automation: open/close windows+tabs, navigate, screenshot, eval JS, record. pup is a GENERIC, non-profile browser only \u2014 every session is a fresh isolated Chrome/Edge process, never the user's real signed-in browser; profile defaults to sessionId. To drive the user's REAL Chrome/Edge (their profile, cookies, SSO), use the Adom browser EXTENSION's nbrowser_* verbs \u2014 a separate bridge, not pup's job. macOS (v1.9.74+): full parity with mac-native mechanics \u2014 background-by-default is the app-level hide (windows stay drivable/screenshottable while hidden), raise/lower map to unhide+activate/hide, pup_alert_window posts a native toast whose click focuses the window, pup_use {browser:'chrome',install:true} installs Chrome from the official dmg, and taskbar identity/badging remains Windows-only.",   "homepage": "https://wiki.adom.inc/adom/adom-bridge",   "author": "Adom Inc.",
src/server.js+9
@@ -7712,6 +7712,15 @@ async function launchSession(sessionId, url, { freshProfile = false, profile, st     if (page) page._pupCreated = true;   // v1.9.142: never a 'restored leftover' — see closeRestoredLeftoverTabs     if (page) console.log(`Session "${sessionId}" opened in its OWN window on shared profile "${profileName}"`);     else { console.log(`[window] newWindow target failed for "${sessionId}" -- falling back to a tab`); page = await browser.newPage(); page._pupCreated = true; }+  } else if (process.platform === 'win32') {+    // v2.0.37 (John: "look at your pup windows bar icons"): the FIRST window on a profile used to+    // take browser.newPage(), which captures NO OS hwnd — so after 2.0.24 removed the title-tag+    // fallback that window was permanently unresolvable and showed a raw Chrome taskbar button. Route+    // it through the SAME birth-capture path every other window uses (create off-screen at a unique+    // position, set-diff the new handle), so every pup window on Windows gets a reliable hwnd.+    page = await createPageInNewWindow(browser, profileName);+    if (page) page._pupCreated = true;+    else { console.log(`[window] first-window newWindow target failed for "${sessionId}" -- falling back to a tab`); page = await browser.newPage(); page._pupCreated = true; }   } else {     page = await browser.newPage();     page._pupCreated = true;   // v1.9.142