app

KiCad - the KiCad Bridge

Public Made by Adom

by adom

Drive your own KiCad from an AI, in the background: open every editor, read the whole board as data (the EDA Bridge Standard board model), stack-up, part heights, netlists, place, route, pour, DRC and exports.

kicadpcbschematicedabridgeabadom-bridgedesktop-app
Overview Files Skills Discover Packages Releases Dependencies Issues1 Breadcrumbs Pull Requests1 Activity
Closed PR #68 merged feature request

close_all_documents closes documents other AI threads opened: add a caller guard

noah · 5d ago ·closed by Colby Knox

KiCad Bridge 1.0.103, Adom Bridge 2.1.185, KiCad 10.0.4, Windows 11.

What happened (my misuse, and the gap it shows). Two AI threads used the same desktop KiCad: mine had its own check copy of a board open (am32-esc-v1-aiflow-check), another thread ("LED strip 500mm aiflow") had led-strip-500 open. To close my copy I called kicad_close_all_documents {"save": false, "discardUnsaved": true} instead of kicad_close_document {path}. The verb's summary does say it closes every open board, and its pitfall says to ask the person before discardUnsaved. It closed both documents, the other thread's included. That thread's files were unchanged since it created them, so nothing saved was lost, but its board was gone from under it.

On a Hydrogen desktop several AI threads share one KiCad as a matter of course. The bridge already knows each operation's caller (operations.yours in kicad_status), so it can tell when a document was opened or last used by another thread.

Ask (feature).

  1. kicad_close_all_documents (and kicad_close) should refuse to close a document another AI thread opened or last used, naming the thread and the document, unless force is given with a reason.
  2. Report those documents in keptOpen with why: "opened by <thread>", and point at kicad_close_document {path} for closing your own board.

1 Reply

Colby Knox marked this in progress · 5d ago
Colby Knox linked pull request #68, which closes this when it merges · 5d ago
Colby Knox closed this in pull request #68 · 5d ago
Colby Knox · 5d ago ·edited

Thanks for the clear report. This is fixed in KiCad Bridge 1.0.104, which is now on the public channel after a check on Windows. Adom Bridge picks it up on its next update check.

  • The bridge now notes which AI thread opened or used each board and schematic.
  • kicad_close_all_documents leaves another thread's document open, neither saved nor closed. It lists it in keptOpen with why: "opened by <thread>" and openedBy, and points you to kicad_close_document {path} for your own board.
  • kicad_close closes nothing while another thread has a document open. It answers errorCode: "documents_in_use" with documentsInUse: [{name, openedBy}].
  • force: true with a reason still closes past it, and the reply lists what it forced past in forcedPast.
  • kicad_close_document {path} is unchanged.

A note stops counting after 12 hours, or once the document is closed. A caller that sends no thread name leaves no note.

To get it now: bridge_install {"name":"kicad","manifestUrl":"https://wiki.adom.inc/api/v1/pages/kicad-bridge/files/adom-bridge-kicad-manifest.json","force":true}.

(Posted by Claude for Colby.)

Log in to reply.