Closed bug report

Public page names an unannounced product

John Lauer · ·closed by John Lauer

Hi, John here. This page mentions an Adom product that stays unannounced until January 2027, so I am asking owners of public pages to take the name out. Could you please refer to it as "3rd party fab" instead (for example "the 3rd party fab's design rules")? Please keep every spec and number exactly as it is; only the name changes. Where the text describes fab, milling or assembly work, word it as done by the 3rd party fab.

I have left the name out of this issue on purpose, since issues are public. Below it appears as [product name]. Line numbers are from the current default branch.

A few of these are identifiers that other code or the design rules page loads, so I have marked those for you to decide. The fab id adom-[product name] comes from the rules index on adom/pcb-design-rules, so it would need to change there first if you want to rename it.

Prose and hints:

  • server.py:512 and rust/crates/kicad-bridge/src/verbs_libraries.rs:74: hint "[product name] is the house baseline." Suggested: "The 3rd party fab is the baseline."
  • server.py:609: hint "writes Gerber + drill files (JLCPCB/[product name] ready)." Suggested: "(JLCPCB / 3rd party fab ready)."
  • SKILL.md:501: "[product name] (adom-[product name]) is the house baseline and is listed first." Suggested: "The 3rd party fab (<fab id>) is the baseline and is listed first."
  • rust/crates/kicad-core/src/design_rules.rs:11: "[product name] is the house baseline and is listed first." Suggested: "The 3rd party fab is the baseline and is listed first."
  • rust/crates/kicad-core/src/design_rules.rs:38: "house baseline first". Suggested: "baseline fab first".
  • rust/crates/kicad-core/src/design_rules.rs:97 and handlers/design_rules.py:82: hint "adom-[product name] is the house baseline." Suggested: " is the baseline fab."
  • handlers/design_rules.py:14: "[product name] is the house baseline and is listed first." Same suggestion as design_rules.rs:11.
  • handlers/design_rules.py:40: "House baseline first". Suggested: "Baseline fab first".
  • docs/esc-routing-astra-prompt.md:21: "which is the ablation metric ([product name] mills the copper away; every square millimetre a pour keeps is copper not removed)". Suggested: "(the 3rd party fab mills the copper away; ...)".
  • skills/kicad-copper-pours/SKILL.md:3 (description): "because [product name]'s ablation process mills copper away" and trigger phrase "[product name] copper". Suggested: "because the 3rd party fab's ablation process mills copper away", and drop the trigger phrase or use "3rd party fab copper".
  • skills/kicad-copper-pours/SKILL.md:8: "on an [product name] board, are the copper that does NOT get milled away". Suggested: "on a 3rd party fab board, ...".
  • skills/kicad-copper-pours/SKILL.md:14: "[product name]'s process is subtractive: it starts from a copper-clad board and ablates the copper that must go." Suggested: "The 3rd party fab's process is subtractive: ...".
  • skills/kicad-place-route-loop/SKILL.md:55: "on an [product name] board, are the copper that does not get milled away". Suggested: "on a 3rd party fab board".
  • skills/kicad-tour/SKILL.md:3 (trigger words): "gerbers for [product name]". Suggested: "gerbers for 3rd party fab" or drop it.
  • skills/kicad-tour/SKILL.md:158: "These are JLCPCB- and [product name]-ready directly." Suggested: "These are JLCPCB- and 3rd party fab-ready directly."
  • skills/kicad-tour/hero/hero_builder.py:186: hero subtitle "Export gerbers to JLCPCB / [product name]." Suggested: "Export gerbers to JLCPCB / 3rd party fab." (If the hero image already rendered this text, it would need a rebuild too.)
  • dashboard/ui/index.html:870: example prompt "check adom/esc-g431 against the [product name] 2-layer design rules in kicad". Suggested: "against the 3rd party fab 2-layer design rules".

Identifiers (your call, they are functional):

  • SKILL.md:502 and SKILL.md:512: examples kicad_set_design_rules {"fab": "adom-[product name]", ...}.
  • server.py:515, rust/crates/kicad-bridge/src/verbs_libraries.rs:82, 83, 84: the same example fab id in the verb input/example/hint.
  • rust/crates/kicad-core/src/design_rules.rs:20 and handlers/design_rules.py:27: HOUSE_SLUG = "adom-[product name]"; handlers/design_rules.py:88: "default adom-[product name]".
  • rust/crates/kicad-core/src/design_rules.rs:344, 353 and 355: test fixture with "vendor": "[product name]", the fab id, a .kicad_dru path containing the name, and match tests on the first half and on the spaced form of the name.
  • skills/kicad-bridge-test/run_verb_tests.py:190: test args {"fab": "adom-[product name]", ...}.

Not a problem: rust/crates/kicad-platform/src/win/mod.rs:6 says "House rules" but means coding rules for the window layer, nothing to do with fabrication.

Thanks!

1 Reply

John Lauer ·

Done in 1.0.55 (insiders) and skills package 1.0.152.

  • Every hint, example and doc line you listed now says "3rd party fab" (or "the baseline fab"), specs unchanged: the root skill, kicad_list_design_rules / kicad_set_design_rules hints, design_rules.rs and handlers/design_rules.py doc comments, server.py hints, the copper-pours, place-route-loop and tour skills (descriptions and trigger phrases too), the tour hero subtitle in hero_builder.py, the dashboard example prompt, and docs/esc-routing-astra-prompt.md.
  • Examples no longer spell the fab id: they use "fab": "jlcpcb", or omit fab, which selects the baseline fab.
  • Kept, because it is functional: the fab id itself, in exactly two constants (HOUSE_SLUG in design_rules.rs and handlers/design_rules.py), since it must match the rules index on adom/pcb-design-rules. The tests now refer to it through that constant. If that page renames the id, it is a two-line change here.
  • The verb catalog served by the bridge (kicad_describe) no longer contains the name anywhere, checked live.
  • The page hero does not show it; the tour hero image is not in this repo.

Not fixable from here: older revisions in the page's file history still contain the old text (that is the history question in adom/wiki#212). Closing.

John Lauer closed this ·

Log in to reply.