Altium - the Altium Bridge

@@ -1,6 +1,6 @@ [package] name = "altium-bridge"-version = "0.2.37"+version = "0.2.39" edition = "2021" description = "Adom altium-bridge — the bridge process, in Rust. Calls ab's verbs for the desktop; speaks file IPC to the resident DelphiScript agent inside Altium." license = "MIT"

@@ -356,6 +356,9 @@ pub fn add_symbol_art(args: &Value) -> Value {  /// Read-only: a SchLib component's drawing (primitive counts, body rectangle, polyline bbox, models). pub fn symbol_prims(args: &Value) -> Value {+    if let Some(g) = support::need_licensed() {+        return g;+    }     let lib = match s(args, "libraryPath") {         Some(l) if !l.is_empty() => l,         _ => return json!({"success": false, "error": "libraryPath (.SchLib) required"}),

@@ -193,7 +193,8 @@ pub fn setup_trial(_args: &Value) -> Value {     let lic = instance::licence_state();     if lic.get("running").and_then(|b| b.as_bool()) != Some(true) {         return json!({"success": true, "stage": "launch", "installed": true,-            "summary": "Altium is installed but not running. Launching it next.",+            "summary": "Altium is installed but not running. This verb reports the next step, it does not launch: call altium_launch (or altium_ensure_licensed, which launches and claims a seat), then altium_setup_trial again.",+            "needsHuman": Value::Null,             "nextAction": "altium_launch (or altium_ensure_licensed)"});     }     let ss = signin_status(&json!({}));

@@ -29,7 +29,7 @@ use tiny_http::{Header, Method, Response, Server}; /// Attached to every failed reply (see the /command handler). const REPORT_ISSUES: &str = "If this looks like an altium-bridge BUG (not a refusal you expected), report it: check for a duplicate with `adom-wiki issue list adom/altium-bridge`, then `adom-wiki issue create adom/altium-bridge --title \"<verb>: <one-line symptom>\" --category bug-report --body \"<what you ran, what you expected, what happened, the VERBATIM response JSON (and errorShot if present), bridgeVersion, the Altium version from altium_status, the OS>\"`. A relay, routing, toast or lifecycle problem belongs on adom/adom-bridge instead. Reports from real machines are how this bridge gets correct: three different Altium builds behaved three different ways in one weekend."; -pub const BRIDGE_VERSION: &str = "0.2.37";+pub const BRIDGE_VERSION: &str = "0.2.39";  fn json_response(status: u16, body: &serde_json::Value) -> Response<std::io::Cursor<Vec<u8>>> {     let data = serde_json::to_vec(body).unwrap_or_else(|_| b"{}".to_vec());

@@ -227,6 +227,9 @@ pub fn export_step(args: &Value) -> Value { }  pub fn import_kicad(args: &Value) -> Value {+    if let Some(g) = support::need_licensed() {+        return g;+    }     let file = match s(args, "filePath") {         Some(f) if !f.is_empty() => f,         _ => return json!({"success": false, "error": "filePath (.kicad_sym / .kicad_sch / .kicad_pcb) is required"}),

@@ -119,8 +119,10 @@ fn describe() -> Value {               "A toast only reaches the machine it is shown on. Check toast.displayed and ALSO tell the user in chat."],             json!({"stage": "launch", "humanIsPresent": true})),         verb_doc("selftest_script_error", "Regression test for the script-error safety net (from 0.2.23): makes the agent raise a REAL DelphiScript runtime error on purpose and checks that the bridge photographs Altium's Error box, stops the halted script itself and leaves no dialog behind. Flashes one error box for under a second. Run it after any change to agent.rs / dialogs.rs and once on every new Altium build.",-            json!({}), json!({"netWorks": "bool", "outcome": "halted_and_recovered | contained_by_agent | unhandled", "errorShot": "base64 png (halted outcome only)", "autoRecovered": "bool", "dialogsLeft": "int"}), 60,-            "netWorks:true is the pass. The agent is stopped afterwards by design; the next verb restarts it.", &["agent_recover", "dialog_log", "agent_status"], &["It really does halt the engine for a moment: do not run it while a user is mid-edit in Altium."], json!({})),+            json!({}), json!({"netWorks": "bool", "outcome": "halted_and_recovered | contained_by_agent | unhandled", "errorShot": "base64 png (halted outcome only)", "autoRecovered": "bool", "dialogsLeft": "int"}), 180,+            "netWorks:true is the pass. The agent is stopped afterwards by design; the next verb restarts it.", &["agent_recover", "dialog_log", "agent_status"],+            &["It really does halt the engine for a moment: do not run it while a user is mid-edit in Altium.",+              "By design this is the SLOWEST verb in the catalog: it halts the engine, waits for the halt to be seen, recovers it and verifies by restarting the agent. Altium Designer Develop parks SILENTLY (no Error box), so the halt is only seen when the wait expires — measured 18 s to over 60 s on the same machine. Its budget is 180 s for that reason; a timeout here means the safety net is broken, not that it was slow."], json!({})),         verb_doc("symbol_prims", "Read a SchLib component's drawing: primitive counts by kind, body rectangle, polyline bounding box, display mode and the footprint models. Read-only, use it to verify add_symbol_art / set_models.",             json!({"libraryPath": "path (.SchLib)", "symbolName": "string", "models": "bool, default false (the model walk halts the engine on some builds)"}), json!({"pins": "int", "rectangles": "int", "lines": "int", "polylines": "int", "bodyRectMil": "[..]", "polyBboxMil": "[..]", "models": "[\"PCBLIB:NAME\"]"}), 60,             "polylines should equal what add_symbol_art reported and polyBboxMil should sit inside bodyRectMil.", &["add_symbol_art", "set_models", "read_symbol"], &[], json!({})),@@ -381,9 +383,9 @@ fn describe() -> Value {             "Use it to verify an imported footprint on a altium_test_board: pad layerId 74 = multi-layer (plated through), which is what altium_plate_vias produces.",             &["component_pins", "plate_vias", "test_board", "pcb_report"], &["Needs a .PcbDoc current: it reads a placed component, not a PcbLib member (altium_pcb_report reads libraries).", "3D bodies, fills and regions only show up in otherPrimitives."], json!({"designator": "U1"})),         verb_doc("schematic_data", "Components on the CURRENT schematic sheet with their pins (number, name, electrical type), position and orientation. designator filters to one part.",-            json!({"designator": "string - optional filter", "limit": "int, default 500", "pins": "bool, default true"}),+            json!({"designator": "string - optional filter", "limit": "int, default 500", "pins": "bool, default true", "params": "bool, default false - include each component's parameters"}),             json!({"data": "{document, count, components: [{designator, partId, libReference, comment, xMil, yMil, orientation, pins: [{number, name, electrical}], params: []}]}", "roundtripMs": "int"}), 120,-            "Pin-level view of a sheet. For parameters use altium_read_schematic (params come back empty here).",+            "Pin-level view of a sheet. params[] is empty unless you pass params:true; altium_read_schematic is the fuller parameter view.",             &["read_schematic", "cross_check", "show_schematic"], &["Needs a .SchDoc current; one sheet only.", "electrical is Altium's pin-type ordinal, not a name."], json!({"designator": "U1"})),         // ---- surfaces ----         verb_doc("show_project", "Open a project (.PrjPcb) through the agent and return a proof frame of Altium's main window. With no filePath it opens Altium's bundled example project (Bluetooth Sentinel).",@@ -1058,7 +1060,11 @@ pub fn dispatch(command: &str, args: &Value, _forwarded: &[(String, String)]) ->         },         "schematic_data" => {             let pins = if args.get("pins").and_then(|b| b.as_bool()) == Some(false) { "0" } else { "1" };-            board_read("schematic_data", vec![("designator", s(args, "designator").unwrap_or_default()), ("limit", s(args, "limit").unwrap_or("500".into())), ("pins", pins.into())], 120)+            // The agent has always honoured params=1; the dispatch never sent it, so every reply+            // carried an empty params[] and the doc had to apologise for it. Off by default:+            // a sheet's parameters are bulky and most callers want pins.+            let params = if args.get("params").and_then(|b| b.as_bool()) == Some(true) { "1" } else { "0" };+            board_read("schematic_data", vec![("designator", s(args, "designator").unwrap_or_default()), ("limit", s(args, "limit").unwrap_or("500".into())), ("pins", pins.into()), ("params", params.into())], 120)         }         // ---- surfaces ----         "show_project" => surfaces::show_project(args),

@@ -2,7 +2,7 @@   "manifest_version": 1,   "name": "altium",   "displayName": "Altium Designer",-  "version": "0.2.37",+  "version": "0.2.39",   "description": "Drive Altium Designer from Adom: a resident DelphiScript agent (eval + the 1,100-command process launcher), the X2 -R command line, UIA over the VCL shell, dialogs by PID, screenshots of every Altium window, and Altium 365.",   "homepage": "https://wiki.adom.inc/adom/altium-bridge",   "docs": "https://wiki.adom.inc/adom/altium-bridge",

@@ -202,7 +202,10 @@ def matrix(w):     # ---- phase 5: the script lanes and the safety net -----------------------------------------     M["run_script"] = dict(phase=5, **ref("refused while the agent is resident (agent_resident)", proc="Nope"))     M["dismiss_dialogs"] = dict(phase=5, **anyo("nothing to dismiss"))-    M["selftest_script_error"] = dict(phase=5, timeout=120, **ok(), check=lambda d: d.get("netWorks") is True)+    # The slowest verb by design, and the slowest on ADDevelop, which parks SILENTLY so the halt is+    # only seen when the wait expires (18 s to over 60 s on one machine). Keep this ABOVE the verb's+    # own declared budget (180 s), or the battery blames the bridge for its own cut-off.+    M["selftest_script_error"] = dict(phase=5, timeout=220, **ok(), check=lambda d: d.get("netWorks") is True)     M["agent_recover"] = dict(phase=5, **ok())     M["agent_stop"] = dict(phase=6, **ok())     M["close"] = dict(phase=6, timeout=300, **ok(discardChanges=True, waitSec=90), note="releases the licence seat; every modified document is the battery's own scratch")

@@ -140,4 +140,4 @@     "skills/altium-wiki-import/SKILL.md",     "uninstall.sh"   ]-}\ No newline at end of file+}