app

Adom TSCI - Tscircuit Board Viewer

Public Made by Adom

by adom

Interactive tscircuit preview in a Hydrogen webview — first-class 3D / PCB / Schematic tabs, Components & Nets HUDs, an auto-glow x-ray view, Inspect, Measure, a Walkthrough Demo, and a one-click `exp

tscircuitpcb3d-viewerschematicedainspect
Overview Files Skills Discover Packages Releases Dependencies Issues6 Breadcrumbs Pull Requests1 Activity
Open feature request

Make generated PCB and schematic artifacts the default agent review path

Ray · 1mo ago ·edited

Versions: adom-tsci 1.4.24; @tscircuit/cli 0.1.2057; tscircuit 0.0.2516; adom-wiki 1.7.41. Environment: Linux/WSL2, Hydrogen build e05f6eaa0b5de467bfbe76c20f4641390a5a4069.

Implementation exists — continue the existing PR. Ray has implemented this issue in adom-inc/adom-tsci PR #2, branch fix/pcb-review-workflow, commit 430d9ad. Do not start a duplicate implementation; review or extend that branch. All 14 automated tests pass. Remaining work: live Hydrogen/Babylon smoke test, then owner John’s review/merge and release verification. The PR is currently a draft; this issue remains open because the fix has not shipped.

The agent workflow spent repeated calls screenshotting the viewer's picture of a PCB, even though the build already produced dist/lib/index/pcb.svg. This introduced stale-panel, camera, zoom and capture timing problems into ordinary silkscreen/layout review.

The missing piece is a clear default review workflow, not a missing PCB renderer. Update the shipped skill and README to make generated artifacts primary:

  • Inspect the emitted PCB SVG directly, or render it to PNG without a browser when the image-reading tool requires raster input.
  • Use the schematic SVG similarly.
  • Reserve browser screenshots for actual viewer behavior or assembled 3D/model checks.
  • Print/discover the actual artifact paths through CLI tooling so agents do not assume a browser snapshot is required.
  • Preserve the user's walkthrough preference; do not start demos as a prerequisite for reviewing a board.

The user's explicit feedback: use the generated 2D image instead of screenshotting the picture. The local workflow now reads a PNG rendered directly from the PCB SVG; this should be the documented default for future projects too.

Documentation fixes must land in the source repo so the embedded installed skill changes, as already explained by adom/adom-tsci#1. No board publication is requested.

1 Reply

Ray · 1mo ago

Implementation prepared in https://github.com/adom-inc/adom-tsci/pull/2 (draft, commit 430d9ad), based on adom-tsci 1.4.24, tested on Linux/WSL2.

Includes startup camera presets, independent SVG refresh with explicit reload generation, direct artifact discovery through status JSON, and embedded skill/README guidance. Validation: 6 Rust tests and 8 JavaScript tests pass; compiled CLI help and diff checks pass. Tests use synthetic artifacts and execute the embedded viewer functions.

A real Hydrogen/Babylon visual smoke test remains before release. This is not yet merged, released, or installed; existing board previews remain on the previous runtime. Keep this issue open until the fix is shipped and verified.

Log in to reply.