← All Pull Requests

Fix stale comment: the thumbnail image fills the window, it no longer opens the modal #1

Closed opened by Ray 2026-09-02

The CSS comment above .card-fill-btn still describes the pre-0.28.2 behaviour and now contradicts the code a thousand lines below it.

src/html/index.html:290 says:

Direct-to-fullscreen shortcut: a ⛶ button on the thumbnail (hover-revealed) that skips the modal and fills the window in ONE click. The image itself still opens the modal on click — this is purely additional.

But src/html/index.html:1194 says the opposite, and is what actually runs:

// ONE click on a thumbnail goes STRAIGHT to fill-window on every surface
// (John: the old 3-layer stack, modal -> fullscreen -> unmax, is gone).
img.addEventListener("click", ()=>fillWindow(imgUrl(e), e.description||e.filename));

So the ⛶ button is no longer a shortcut past the modal; it is the discoverable, keyboard-focusable route to the same fill the image click already does. Comment updated to say that.

Comment only. No behaviour change, no CSS change.

How I got here, since it may be useful signal: Ray relayed your Chat ask about filing shotlog issues, and I filed two — one-click fullscreen, and the tooltip covering a popover. Both turned out to be already shipped in 0.28.2, one of them at your own request. I have closed the fullscreen one and annotated the other. This stale comment is very likely what made the fullscreen behaviour look unshipped when reading the source, so it is worth a minute to fix.

Not merging this myself — adom-shotlog is yours.

Diff Skip to comments (1)

--- a/src/html/index.html+++ b/src/html/index.html@@ -1,2078 +1,2081 @@⋯ 286 unchanged lines ⋯ .shot-card-img { display: block; width: 100%; height: 220px; flex-shrink: 0; background: #111;   object-fit: contain; object-position: center top; transition: opacity .15s; } .shot-card:active .shot-card-img { opacity: .85; }-/* Direct-to-fullscreen shortcut: a ⛶ button on the thumbnail (hover-revealed)-   that skips the modal and fills the window in ONE click. The image itself-   still opens the modal on click — this is purely additional. */+/* Fullscreen affordance: a ⛶ button on the thumbnail (hover-revealed).+   The thumbnail IMAGE also fills the window in one click (see the click+   handler on img, "ONE click on a thumbnail goes STRAIGHT to fill-window"),+   so this button is the discoverable, keyboard-focusable route to the same+   thing rather than a separate shortcut past the modal. */ .card-img-wrap { position: relative; } .card-fill-btn { position: absolute; top: 10px; right: 10px; width: 32px; height: 32px;   display: inline-flex; align-items: center; justify-content: center;⋯ 1780 unchanged lines ⋯ </script> </body> </html>+

Comments

John Lauer · 1mo ago

Applied verbatim in 0.28.3 (with a credit in the comment). Closing rather than merging: the page repo now carries newer index.html content than this diff's base, and a whole-file merge would have rolled that back. Thanks.

Log in to comment.