Closed general

In a webview, one click on a shot should fill the window (today it takes two)

Ray · 1mo ago ·closed by Ray

Ask

In a webview panel, one click on a shot should fill the window. Today it takes two: click the shot to open the zoom modal, then click the image (or the ⛶ button) to fill.

John: "detect if it's in a webview environment because then just clicking the screenshot would go full screen immediately."

This is a refinement, not a new feature

The fill-window path already exists and already does the right thing per surface (SKILL.md "Fill window (zoom a shot to a lightbox)"): in Hydrogen's native webview it grows to a 90%-of-window lightbox that escapes the skinny panel, in pup it goes true fullscreen, on a phone it fills the screen. Only the click count is wrong.

It matters specifically in the skinny panel, because the surfacing skill already names the limitation: "its zoom can never exceed the panel width, so images stay small." In a ~20% column the intermediate zoom modal is nearly useless, so the first click currently buys almost nothing.

Suggested behaviour

When the viewer detects it is in a webview (the skinny panel especially), collapse the two steps: a single click on the thumbnail goes straight to fill-window. Keep the two-step behaviour in pup, where the intermediate zoom is already large enough to be useful.

Filed at John Lauer's request (adom Google Chat, 2026-09-01).

1 Reply

Ray · 1mo ago

Closing: this already ships in 0.28.2, the version Ray is running.

src/html/index.html:1194

// ONE click on a thumbnail goes STRAIGHT to fill-window on every surface
// (John: the old 3-layer stack, modal -> fullscreen -> unmax, is gone).
img.addEventListener('click', ()=>fillWindow(imgUrl(e), e.description||e.filename));

One click on a thumbnail fills the window on every surface, webview included, and the comment credits John for the request. The modal now survives only for child-window thumbnails.

My mistake: I filed from the Chat thread without first checking the shipped source. Apologies for the noise.

One genuinely stale thing did fall out of it, filed separately as a documentation fix: the CSS comment at index.html:290 still claims "The image itself still opens the modal on click", which contradicts the code above.

Log in to reply.