Adom Library

@@ -2678,6 +2678,28 @@ pub(crate) fn lint_lbr(content: &str) -> LintResult {         // had just been used to fix.         let smd_re = regex_lite::Regex::new(r#"<smd [^>]*/>"#).unwrap();         let pad_re = regex_lite::Regex::new(r#"<pad [^>]*/>"#).unwrap();+        // Which pin each pad wires to, per package, from every device that uses it. Two pads that wire to the SAME+        // pin name are one net, so their copper may overlap by design: KiCad's USB-C receptacles stack the paired+        // A1/B12 (GND) and A4/B9 (VBUS) pads, and EAGLE names the duplicate pins GND@1, GND@2. Without this the+        // HRO TYPE-C-31-M-12 footprint failed as a short (adom/type-c-31-m-12, 2026-10-08).+        let pin_base = |n: &str| n.split('@').next().unwrap_or(n).to_string();+        let dev_re = regex_lite::Regex::new(r#"(?s)<device [^>]*package="([^"]*)"[^>]*>(.*?)</device>"#).unwrap();+        let con_re = regex_lite::Regex::new(r#"<connect [^>]*/>"#).unwrap();+        // Every pin a pad wires to across the devices that use the package: two devices may wire the same package+        // differently, and the pair is one net only if it is one net in all of them.+        let mut pad_net: std::collections::HashMap<(String, String), std::collections::BTreeSet<String>> = std::collections::HashMap::new();+        for d in dev_re.captures_iter(content) {+            for c in con_re.find_iter(&d[2]) {+                let el = c.as_str();+                let get = |k: &str| regex_lite::Regex::new(&format!(r#"\b{}="([^"]*)""#, k)).ok()+                    .and_then(|re| re.captures(el).map(|m| m[1].to_string()));+                if let (Some(pin), Some(pads)) = (get("pin"), get("pad")) {+                    for pad in pads.split_whitespace() {+                        pad_net.entry((d[1].to_string(), pad.to_string())).or_default().insert(pin_base(&pin));+                    }+                }+            }+        }         let attr = |el: &str, k: &str| -> Option<String> {             regex_lite::Regex::new(&format!(r#"{}="([^"]*)""#, k)).ok()?                 .captures(el).map(|c| c[1].to_string())@@ -2716,6 +2738,10 @@ pub(crate) fn lint_lbr(content: &str) -> LintResult {                     // NAME, NAME@2, NAME@3. Comparing those would fail every such footprint.                     let base = |n: &str| n.split('@').next().unwrap_or(n).to_string();                     if base(&a.name) == base(&b.name) { continue; }+                    // pads wired to the same pin (one net): overlapping copper is a merged pad, not a short+                    if let (Some(na), Some(nb)) = (pad_net.get(&(pkg.clone(), a.name.clone())), pad_net.get(&(pkg.clone(), b.name.clone()))) {+                        if na.len() == 1 && na == nb { continue; }+                    }                     let gx = (a.x - b.x).abs() - (a.hx + b.hx);                     let gy = (a.y - b.y).abs() - (a.hy + b.hy);                     let gap = if a.round && b.round {@@ -4806,6 +4832,41 @@ mod lint_tests {         assert!(!lint_lbr(&vias).errors.iter().any(|e| e.code == "pad-clearance"));     } +    #[test]+    fn overlapping_pads_on_the_same_pin_are_one_net_but_different_pins_still_short() {+        // KiCad's USB_C_Receptacle_HRO_TYPE-C-31-M-12 stacks A1 over B12 (both GND): EAGLE pins GND@1 and GND@2.+        use super::lint_lbr;+        let lib = |pins: (&str, &str)| format!(r#"<eagle><drawing><layers></layers><library>+            <packages><package name="P"><smd name="A1" x="0" y="0" dx="0.6" dy="1.2"/><smd name="B12" x="0.3" y="0" dx="0.6" dy="1.2"/></package></packages>+            <symbols><symbol name="S"><pin name="{a}" x="0" y="0" length="short"/><pin name="{b}" x="0" y="2" length="short"/></symbol></symbols>+            <devicesets><deviceset name="D"><gates><gate name="G$1" symbol="S" x="0" y="0"/></gates>+            <devices><device name="" package="P"><connects><connect gate="G$1" pin="{a}" pad="A1"/><connect gate="G$1" pin="{b}" pad="B12"/></connects>+            <technologies><technology name=""/></technologies></device></devices></deviceset></devicesets>+            </library></drawing></eagle>"#, a = pins.0, b = pins.1);+        let same = lint_lbr(&lib(("GND@1", "GND@2")));+        assert!(!same.errors.iter().any(|e| e.code == "pad-clearance"), "same net must pass: {:?}", same.errors);+        let diff = lint_lbr(&lib(("GND", "VBUS")));+        assert!(diff.errors.iter().any(|e| e.code == "pad-clearance"), "different nets must still fail: {:?}", diff.errors);+    }++    #[test]+    fn a_short_in_one_device_is_not_hidden_by_another_device_on_the_same_package() {+        // Two devices share package P: one wires A1/B12 to GND@1/GND@2 (one net), the other to GND/VBUS (a short).+        // The short must be reported whichever device comes last.+        use super::lint_lbr;+        let dev = |name: &str, b: &str| format!(r#"<device name="{name}" package="P"><connects><connect gate="G$1" pin="GND@1" pad="A1"/><connect gate="G$1" pin="{b}" pad="B12"/></connects><technologies><technology name=""/></technologies></device>"#);+        let lib = |first: String, second: String| format!(r#"<eagle><drawing><layers></layers><library>+            <packages><package name="P"><smd name="A1" x="0" y="0" dx="0.6" dy="1.2"/><smd name="B12" x="0.3" y="0" dx="0.6" dy="1.2"/></package></packages>+            <symbols><symbol name="S"><pin name="GND@1" x="0" y="0" length="short"/><pin name="GND@2" x="0" y="2" length="short"/><pin name="VBUS" x="0" y="4" length="short"/></symbol></symbols>+            <devicesets><deviceset name="D"><gates><gate name="G$1" symbol="S" x="0" y="0"/></gates>+            <devices>{first}{second}</devices></deviceset></devicesets>+            </library></drawing></eagle>"#);+        for (a, b) in [(dev("A", "GND@2"), dev("B", "VBUS")), (dev("B", "VBUS"), dev("A", "GND@2"))] {+            let r = lint_lbr(&lib(a, b));+            assert!(r.errors.iter().any(|e| e.code == "pad-clearance"), "the GND/VBUS short must fail in either order: {:?}", r.errors);+        }+    }+     #[test]     fn a_round_pad_off_a_square_pads_corner_is_measured_as_copper_not_boxes() {         // KiCad's stock Package_TO_SOT_THT:TO-92 (staggered): square pad 1 at (0,0), round pad