Adom Desktop

Type: Bug report (packaging / install)

Symptom: adom-wiki pkg install adom/adom-desktop fails and rolls the entire install back. The container is left with no ~/.local/bin/adom-desktop symlink (dangling if a prior one existed) and no freshly-linked skill bundle. Observed error:

[adom-desktop] FATAL: adompkg not on PATH — install via 'adompkg install adom-desktop'.
{ "error": "script exited with exit status: 1: .../adom_modules/adom/adom-desktop/install.sh" }

Root cause: the package's install.sh is hard-wired to the deprecated adompkg CLI. adompkg is dead — the current tool is adom-wiki — so the very first guard aborts the whole install:

if ! command -v adompkg >/dev/null 2>&1; then
  echo "[adom-desktop] FATAL: adompkg not on PATH — install via 'adompkg install adom-desktop'." >&2
  exit 1
fi
# shellcheck disable=SC1090
source "$(adompkg sh-helpers)"
...
adompkg-link-bin  adom-desktop "$CLI"          # Linux CLI symlink
adompkg-link-skill "$slug" "skills/$slug"       # per-skill symlinks

Because install.sh runs under adom-wiki pkg install (which sets cwd and runs the script), and adompkg isn't present, the script exits 1 and adom-wiki rolls the package back.

Why a simple s/adompkg/adom-wiki/ is not enough: the modern equivalents aren't wired up yet —

• adom-wiki pkg sh-helpers → warning [PKG_VERB_NOT_YET_IMPLEMENTED]: pkg sh-helpers is not wired up in this build yet
• there are no adom-wiki pkg link-bin / link-skill verbs (only pkg link/unlink, the npm-link sense).

So the helper functions (adompkg-link-bin, adompkg-link-skill) the script sources have no drop-in adom-wiki counterpart today.

Impact:

• Fresh/repair installs of adom/adom-desktop via adom-wiki are broken → no container CLI on PATH, no skill links, full rollback.
• This is exactly how the container's adom-desktop command went missing (dangling ~/.local/bin/adom-desktop -> .../dist/linux/adom-desktop after the module dir was cleaned). Recovery required adom-wiki pkg install adom/adom-desktop --ignore-scripts + a manual chmod +x dist/linux/adom-desktop — the script never ran.

Suggested fix — make install.sh dependency-free for linking (it already ships the artifacts in-tarball per the v1.8.147+ bundled-artifact model, so no package-manager download is needed — only symlink creation):

# replace the adompkg guard + sourced helpers with plain ln -sfn
mkdir -p "$HOME/.local/bin" "$HOME/.claude/skills"
ln -sfn "$PWD/dist/linux/adom-desktop" "$HOME/.local/bin/adom-desktop"     # Linux CLI
for d in skills/*/; do
  [ -f "$d/SKILL.md" ] || continue
  ln -sfn "$PWD/$d" "$HOME/.claude/skills/$(basename "$d")"                # skills
done

Alternatively, detect the package manager and only call its helper if the verb is actually implemented, else fall back to ln -sfn:

if command -v adompkg >/dev/null 2>&1; then source "$(adompkg sh-helpers)"; link_bin(){ adompkg-link-bin "$@"; }; ...
else link_bin(){ ln -sfn "$2" "$HOME/.local/bin/$1"; }; link_skill(){ ln -sfn "$PWD/$2" "$HOME/.claude/skills/$1"; }
fi

Either way, drop the hard exit 1 on missing adompkg.

Env: adom/adom-desktop pkg v1.9.94 (manifest) / release 1.9.101; CLI verified working once linked: adom-desktop 1.9.101 (66f59fe), ping → connected on 127.0.0.1:47200. Same stale adompkg reference likely exists in the bridge packages' install.sh (kicad/fusion/puppeteer) — worth a sweep.