pkg publish overwrites a page's image hero with billboard form, breaking the full-bleed custom hero

Overview Files Skills Discover Packages Releases Dependencies Issues4 Breadcrumbs Pull Requests Activity

Closed general

John Lauer · 22d ago ·closed by Colby Knox

When a page has a custom full-bleed hero image declared as hero: {type:"image", path:"screenshots/hero.png"}, running adom-wiki pkg publish REQUIRES a billboard hero ({type:"billboard", headline, subhead, screenshot}) and rejects the image form (hard error: 'No hero'). Worse, publishing then OVERWRITES the page's hero field with that billboard form, so the page stops rendering the custom hero full-bleed and instead renders a generic billboard TEMPLATE (the real hero.png is shrunk to a thumbnail on the right, with headline/subhead text on the left). Every pkg publish silently reverts/breaks the page hero, forcing a manual adom-wiki repo push page.json to restore {type:image,path} afterward. Hit live on adom/adom-desktop-fusion-bridge. Asks: (1) let pkg publish accept an {type:image,path} hero (or auto-derive a billboard from it) instead of rejecting it; OR (2) decouple the pkg listing hero from the page-display hero so publishing never mutates the page's hero; OR (3) render type:billboard with the screenshot full-bleed when no separate page hero is set. Right now the two hero notions collide and publishing always damages the page.

2 Replies

Colby Knox · 22d ago

Fixed and live on wiki.adom.inc.

A re-publish no longer overwrites a curated page hero. The page hero is OWNED by the page: it is set out-of-band via adom-wiki page hero (the hero PUT writes it into page.json). pkg publish now preserves an existing hero and adopts the manifest hero ONLY on the first materialization (when the page has none yet). So a {type:image,path} full-bleed hero survives every version bump, instead of reverting to the package.json billboard form. To change a hero, use page hero, not a publish.

Verified on staging: publish (billboard hero) -> set an image hero via the hero endpoint -> republish with the billboard manifest -> hero_type stayed image (was clobbered before).

One note for the CLI side: the SERVER accepts an image hero on publish (the hero gate allows {type:image,path}). So if adom-wiki pkg publish rejects an image-only manifest or auto-synthesizes a billboard, that is a CLI behavior to check, separate from this server fix.

Colby Knox · 22d ago

Confirmed live on prod: pkg publish no longer overwrites a page's image hero with billboard fields. The existing page hero is preserved across republishes. Thanks John.