← Commit history

Diagnostic: dump the exact composed badge PNG to disk plus the target (hwnd vs titleContains) before handing it to AD, so the composite can be INSPECTED rather than inferred from a screenshot. Four successive theories about the unpainted first taskbar button were wrong (SVG rasterisation, code-not-running, duplicate sessions, the composite cache); this measurement splits the problem cleanly — if the PNG contains the generic icon then the compositor is exonerated and the fault is delivery to that specific window.

John Lauer ·f8cdc90a73 ·3mo ago ·parent 4b30a5f
4 files changed +17−6
adom-bridge-puppeteer-manifest.json+4−4
@@ -1,10 +1,10 @@ {   "manifest_version": 1,   "name": "puppeteer",-  "version": "1.9.214",-  "url": "https://wiki.adom.inc/download/adom/adom-desktop-puppeteer-bridge/1.9.214/adom-bridge-puppeteer-v1.9.214.zip",-  "sha256": "3acdafa9f84fdfd55ed64809bf1c58604b768d0db82fc5ce08bd42c50ffde31d",-  "size": 441006,+  "version": "1.9.215",+  "url": "https://wiki.adom.inc/download/adom/adom-desktop-puppeteer-bridge/1.9.215/adom-bridge-puppeteer-v1.9.215.zip",+  "sha256": "7dc5f85709ada7c42fa63319ac202079e34161d1e8a58bc3569041822a0add9a",+  "size": 441329,   "verbPrefixes": [     "browser_",     "desktop_recorder_",
src/BRIDGE_VERSION+1−1
@@ -1 +1 @@-1.9.214+1.9.215
src/bridge.json+1−1
@@ -2,7 +2,7 @@   "manifest_version": 1,   "name": "puppeteer",   "displayName": "Puppeteer (Chrome for Testing + Native)",-  "version": "1.9.214",+  "version": "1.9.215",   "description": "Drives a browser ALREADY on the machine \u2014 installed Chrome, else Microsoft Edge (every Windows PC ships with Edge) \u2014 launched with a FRESH isolated profile, so the common case has NO ~150 MB Chrome-for-Testing download and it never touches the user's real tabs/logins. Binds its local server to LOOPBACK (127.0.0.1) only, so no Windows Firewall 'allow Node through the firewall' prompt ever pops. Chrome for Testing is fetched only as a LAST RESORT if the machine has no Chromium browser at all. SPAWN-VERIFIED fallback: pup tries each detected browser (Chrome \u2192 Edge \u2192 CfT) and actually launches it, falling through to the next if one won't start (and handling browsers like Edge that relaunch onto another PID), so a corrupt/partial install never hard-fails an open. The browser that launches is cached as the default (persisted across restarts) so it isn't re-probed each time. On spawn the bridge SELF-WARMS: detects browsers + disk, and only if the box has no Chrome/Edge and no cached CfT does it background-fetch CfT so the first open is instant. browser_use pins a specific browser (chrome | edge | cft | auto); {browser:'chrome',install:true} downloads & installs REAL Google Chrome (user-scoped, no admin) on an Edge-only box. browser_readiness (READ-ONLY) reports which browser will be used + the full candidate list + the default + free disk. Every failure returns a specific errorCode + _hint (chrome_install_no_disk, chrome_download_network, chrome_install_permission, chrome_stable_not_detected, \u2026). Launches with FULL browser permissions by default for full debug (strictPermissions:true opts out). Headful automation: open/close windows+tabs, navigate, screenshot, eval JS, record. pup is a GENERIC, non-profile browser only \u2014 every session is a fresh isolated Chrome/Edge process, never the user's real signed-in browser; profile defaults to sessionId. To drive the user's REAL Chrome/Edge (their profile, cookies, SSO), use the Adom browser EXTENSION's nbrowser_* verbs \u2014 a separate bridge, not pup's job. macOS (v1.9.74+): full parity with mac-native mechanics \u2014 background-by-default is the app-level hide (windows stay drivable/screenshottable while hidden), raise/lower map to unhide+activate/hide, browser_alert_window posts a native toast whose click focuses the window, browser_use {browser:'chrome',install:true} installs Chrome from the official dmg, and taskbar identity/badging remains Windows-only.",   "homepage": "https://wiki.adom.inc/adom/adom-desktop",   "author": "Adom Inc.",
src/server.js+11
@@ -4123,6 +4123,17 @@ async function applyAppOverlay(session, sessionId) {     const nm = session._appName ? `${session._appName} — ` : '';     // v1.9.212: address the button BY HWND when known — the title tag is unavailable on PDF windows,     // which is why those buttons never got painted no matter what the compositor produced.+    // v1.9.215 DIAGNOSTIC: dump the EXACT bytes we are about to hand AD, plus the target we address,+    // so the composite can be inspected directly instead of inferred from a screenshot. Four of my+    // theories about this button were wrong; this measurement splits the problem: if the PNG contains+    // the generic icon, the compositor is exonerated and the fault is delivery to this window.+    try {+      const _dbgDir = path.join(require('os').tmpdir(), 'pup-badge-debug');+      fs.mkdirSync(_dbgDir, { recursive: true });+      const _dbgPath = path.join(_dbgDir, `${sessionId}.png`);+      fs.writeFileSync(_dbgPath, Buffer.from(overlay, 'base64'));+      console.log(`[overlay-debug] "${sessionId}" composed ${Buffer.from(overlay, 'base64').length}B -> ${_dbgPath} | src=${(src && src.href) || '?'} | hwnd=${session._hwnd || '(none, using title)'}`);+    } catch (e) { console.log(`[overlay-debug] dump failed: ${e.message}`); }     const _tgt = (session._hwnd ? { hwnd: session._hwnd } : { titleContains: `(session: ${sessionId}` });     await chrome.adCommand('desktop_taskbar', {       ..._tgt,