← Commit history

v2.0.309: Enum spam: a birth-captured hwnd is believed without re-enumerating (the proof now precedes the owner-pid lookup).

John Lauer ·f87c54d561 ·2mo ago ·parent b9cce7a
4 files changed +18−13
adom-bridge-puppeteer-manifest.json+5−5
@@ -1,10 +1,10 @@ {   "manifest_version": 1,   "name": "puppeteer",-  "version": "2.0.308",-  "url": "https://wiki.adom.inc/download/adom/pup-bridge/2.0.308/adom-bridge-puppeteer-v2.0.308.zip",-  "sha256": "4277124992830b6444ff111745b67ec596f34e136ba06e4c3a5949700d9228da",-  "size": 1431506,+  "version": "2.0.309",+  "url": "https://wiki.adom.inc/download/adom/pup-bridge/2.0.309/adom-bridge-puppeteer-v2.0.309.zip",+  "sha256": "ed43a34a006fd34a5a12ef7f13beee630d06c29aa577253d380b59dbdc877633",+  "size": 1431603,   "verbPrefixes": [     "browser_",     "desktop_recorder_",@@ -12,5 +12,5 @@   ],   "healthEndpoint": "/status",   "statusVerb": "browser_readiness",-  "released_at": "2026-08-23T14:55:39.071158Z"+  "released_at": "2026-08-23T14:57:58.773179Z" }
src/BRIDGE_VERSION+1−1
@@ -1 +1 @@-2.0.308\ No newline at end of file+2.0.309\ No newline at end of file
src/bridge.json+1−1
@@ -2,7 +2,7 @@   "manifest_version": 1,   "name": "puppeteer",   "displayName": "Puppeteer (Chrome for Testing + Native)",-  "version": "2.0.308",+  "version": "2.0.309",   "description": "Drives a browser ALREADY on the machine \u2014 installed Chrome, else Microsoft Edge (every Windows PC ships with Edge) \u2014 launched with a FRESH isolated profile, so the common case has NO ~150 MB Chrome-for-Testing download and it never touches the user's real tabs/logins. Binds its local server to LOOPBACK (127.0.0.1) only, so no Windows Firewall 'allow Node through the firewall' prompt ever pops. Chrome for Testing is fetched only as a LAST RESORT if the machine has no Chromium browser at all. SPAWN-VERIFIED fallback: pup tries each detected browser (Chrome \u2192 Edge \u2192 CfT) and actually launches it, falling through to the next if one won't start (and handling browsers like Edge that relaunch onto another PID), so a corrupt/partial install never hard-fails an open. The browser that launches is cached as the default (persisted across restarts) so it isn't re-probed each time. On spawn the bridge SELF-WARMS: detects browsers + disk, and only if the box has no Chrome/Edge and no cached CfT does it background-fetch CfT so the first open is instant. pup_use pins a specific browser (chrome | edge | cft | auto); {browser:'chrome',install:true} downloads & installs REAL Google Chrome (user-scoped, no admin) on an Edge-only box. pup_readiness (READ-ONLY) reports which browser will be used + the full candidate list + the default + free disk. Every failure returns a specific errorCode + _hint (chrome_install_no_disk, chrome_download_network, chrome_install_permission, chrome_stable_not_detected, \u2026). Launches with FULL browser permissions by default for full debug (strictPermissions:true opts out). Headful automation: open/close windows+tabs, navigate, screenshot, eval JS, record. pup is a GENERIC, non-profile browser only \u2014 every session is a fresh isolated Chrome/Edge process, never the user's real signed-in browser; profile defaults to sessionId. To drive the user's REAL Chrome/Edge (their profile, cookies, SSO), use the Adom browser EXTENSION's nbrowser_* verbs \u2014 a separate bridge, not pup's job. macOS (v1.9.74+): full parity with mac-native mechanics \u2014 background-by-default is the app-level hide (windows stay drivable/screenshottable while hidden), raise/lower map to unhide+activate/hide, pup_alert_window posts a native toast whose click focuses the window, pup_use {browser:'chrome',install:true} installs Chrome from the official dmg, and taskbar identity/badging remains Windows-only.",   "homepage": "https://wiki.adom.inc/adom/adom-bridge",   "author": "Adom Inc.",
src/server.js+11−6
@@ -8004,18 +8004,23 @@ async function hwndBelongsToPup(hwnd, session) {   // let a wrong-but-pup cached hwnd (another session's window) pass forever, so a stale/mis-resolved   // hwnd was never corrected and overlays painted on the wrong button. When a session is given, the   // pid set is scoped to its profile; a cross-profile hwnd now fails and forces a re-resolve.-  const info = await hwndOwnerPid(hwnd);-  const pid = info && info.pid;-  if (!pid) return false;   const prof = session && session.profileName;   // v2.0.31: STRONGEST PROOF FIRST — a hwnd pup captured at BIRTH (it created that exact off-screen   // window) is definitively pup's, no pid tracking and no title tag required. This replaces the-  // v1.9.350 title-based shared-profile fallback that 2.0.24 broke by removing the title tag. Learn-  // the owner pid so every sibling window on the shared Chrome process passes instantly afterwards.+  // v1.9.350 title-based shared-profile fallback that 2.0.24 broke by removing the title tag.+  // v2.0.309 (John: the enum spam): this proof now runs BEFORE the owner-pid enumeration, so a+  // window pup itself created is never re-enumerated to be believed. The owner pid is learned from+  // the shared snapshot when it happens to be there, never by forcing a fresh enum.   try {     const born = session && (session.tabs || []).some(t => t && t.page && Number(t.page.__pupHwnd) === Number(hwnd));-    if (born) { learnConfirmedPid(prof, pid); return true; }+    if (born) {+      try { const row = (_enumCache.rows || []).find(r => Number(r.h) === Number(hwnd)); if (row && row.pid) learnConfirmedPid(prof, Number(row.pid)); } catch (e) {}+      return true;+    }   } catch (e) {}+  const info = await hwndOwnerPid(hwnd);+  const pid = info && info.pid;+  if (!pid) return false;   // v2.0.43: RECOVERED-HANDLE PROOF. A respawned pup can't have birth-captured anything, but the   // session file persisted both the hwnd AND Chrome's pid at capture time, and Chrome outlives pup   // respawns — so this exact pair (the handle still owned by the very process it was recorded