← Commit history

The plain-mode registry sweep is removed: registry keys with no window property pointing at them are inert and were never what split the taskbar groups, while deleting them broke re-entry into tiles and aumid modes because ab caches icon registration by app id and skipped the registry re-write, leaving buttons with names but no art; the native-AUMID convergence from 2.0.221 remains the whole plain-mode story.

John Lauer ·f777a51b6a ·2mo ago ·parent ccfa0bb
4 files changed +11−22
adom-bridge-puppeteer-manifest.json+4−4
@@ -1,10 +1,10 @@ {   "manifest_version": 1,   "name": "puppeteer",-  "version": "2.0.222",-  "url": "https://wiki.adom.inc/download/adom/pup-bridge/2.0.222/adom-bridge-puppeteer-v2.0.222.zip",-  "sha256": "952921b84b6faa1048aba1926d989dbb1c405057b422b94206f2b554d3b6838c",-  "size": 942460,+  "version": "2.0.223",+  "url": "https://wiki.adom.inc/download/adom/pup-bridge/2.0.223/adom-bridge-puppeteer-v2.0.223.zip",+  "sha256": "e0f4de2a0ad9b778994972b2b452e84daee2ccd60401d91d1271be0acde9ab6c",+  "size": 942355,   "verbPrefixes": [     "browser_",     "desktop_recorder_",
src/BRIDGE_VERSION+1−1
@@ -1 +1 @@-2.0.222+2.0.223
src/bridge.json+1−1
@@ -2,7 +2,7 @@   "manifest_version": 1,   "name": "puppeteer",   "displayName": "Puppeteer (Chrome for Testing + Native)",-  "version": "2.0.222",+  "version": "2.0.223",   "description": "Drives a browser ALREADY on the machine \u2014 installed Chrome, else Microsoft Edge (every Windows PC ships with Edge) \u2014 launched with a FRESH isolated profile, so the common case has NO ~150 MB Chrome-for-Testing download and it never touches the user's real tabs/logins. Binds its local server to LOOPBACK (127.0.0.1) only, so no Windows Firewall 'allow Node through the firewall' prompt ever pops. Chrome for Testing is fetched only as a LAST RESORT if the machine has no Chromium browser at all. SPAWN-VERIFIED fallback: pup tries each detected browser (Chrome \u2192 Edge \u2192 CfT) and actually launches it, falling through to the next if one won't start (and handling browsers like Edge that relaunch onto another PID), so a corrupt/partial install never hard-fails an open. The browser that launches is cached as the default (persisted across restarts) so it isn't re-probed each time. On spawn the bridge SELF-WARMS: detects browsers + disk, and only if the box has no Chrome/Edge and no cached CfT does it background-fetch CfT so the first open is instant. pup_use pins a specific browser (chrome | edge | cft | auto); {browser:'chrome',install:true} downloads & installs REAL Google Chrome (user-scoped, no admin) on an Edge-only box. pup_readiness (READ-ONLY) reports which browser will be used + the full candidate list + the default + free disk. Every failure returns a specific errorCode + _hint (chrome_install_no_disk, chrome_download_network, chrome_install_permission, chrome_stable_not_detected, \u2026). Launches with FULL browser permissions by default for full debug (strictPermissions:true opts out). Headful automation: open/close windows+tabs, navigate, screenshot, eval JS, record. pup is a GENERIC, non-profile browser only \u2014 every session is a fresh isolated Chrome/Edge process, never the user's real signed-in browser; profile defaults to sessionId. To drive the user's REAL Chrome/Edge (their profile, cookies, SSO), use the Adom browser EXTENSION's nbrowser_* verbs \u2014 a separate bridge, not pup's job. macOS (v1.9.74+): full parity with mac-native mechanics \u2014 background-by-default is the app-level hide (windows stay drivable/screenshottable while hidden), raise/lower map to unhide+activate/hide, pup_alert_window posts a native toast whose click focuses the window, pup_use {browser:'chrome',install:true} installs Chrome from the official dmg, and taskbar identity/badging remains Windows-only.",   "homepage": "https://wiki.adom.inc/adom/adom-bridge",   "author": "Adom Inc.",
src/server.js+5−16
@@ -4581,22 +4581,11 @@ async function stripAllPupIdentities(reason) {     try { execFileSync('reg', ['delete', `HKCU\\Software\\Classes\\AppUserModelId\\${id}`, '/f'], { timeout: 5000, windowsHide: true, stdio: 'ignore' }); } catch (e) {}   }   try { _registeredPupAumids.clear(); } catch (e) {}-  // v2.0.217 (John's red-box ralph: the grouped CfT button wore pup's teal icon in plain mode):-  // the ids set above comes from _curAppId bookkeeping, which a prior mode switch already nulled —-  // so the delete loop ran on NOTHING and every historical Adom.Pup.* registry key survived.-  // Plain means plain: sweep the registry for ALL pup AUMID keys and delete them.-  try {-    const _rq = execFileSync('reg', ['query', 'HKCU\\Software\\Classes\\AppUserModelId'], { timeout: 8000, windowsHide: true }).toString();-    let _swept = 0;-    for (const _ln of _rq.split(/\r?\n/)) {-      const _k = _ln.trim();-      if (/\\AppUserModelId\\Adom\.Pup/i.test(_k)) {-        try { execFileSync('reg', ['delete', _k, '/f'], { timeout: 5000, windowsHide: true, stdio: 'ignore' }); _swept++; } catch (e) {}-      }-    }-    if (_swept) console.log(`[identity] plain strip: swept ${_swept} Adom.Pup.* AUMID registry key(s) (bookkeeping had lost track of them)`);-    try { savePupSettings({ _stripEpoch: Number(pupSettings()._stripEpoch || 0) + 1 }); } catch (e) {}-  } catch (e) {}+  // v2.0.223: the 2.0.217 registry SWEEP that lived here was a mistake and is gone. Registry keys+  // with no window property pointing at them are inert — they never split taskbar groups (Chrome's+  // native-vs-empty AUMID drift did, fixed by the convergence below) — and deleting them broke+  // re-entry into tiles/aumid: ab caches icon registration BY APPID, so re-stamps skipped the+  // registry re-write and buttons came back with the right NAME and no ART (ralph r1/r5 fails).   // v2.0.182 (measured during the ladder proof): deleting the REGISTRY keys is not enough — the   // per-WINDOW AppUserModel property trio (+ the explicit ID) survives on the window and keeps   // branding the rebuilt button. Truly plain = wipe those properties with VT_EMPTY via the shell