← Commit history

v2.0.274: Fix the second half of adom/pup-bridge#69: pup_evaluate ran nothing and reported ok. The eval is new Function('return (' + expr + ')'), which is EXPRESSION-only, so the reporter's location.assign('...'); 'navigating' was a SyntaxError: nothing ran, the page never navigated, and the handler still answered ok:true with the failure buried in result.__error. Reproduced verbatim. Two fixes. On a syntax error the source is retried through CDP Runtime.evaluate, which has devtools-console semantics (accepts a statement list, returns the completion value), so the same code now works; a context destroyed mid-eval is treated as SUCCESS because it means the page navigated. And a failed eval is now a FAILED verb with errorCode eval_failed instead of ok:true wrapping __error, which was the exact lie this issue is about. Also confirms the switch_tab half: after 2.0.272 all four switches including repeats land on the requested tab with activated:true; the earlier partial result was measured against a session that had been reaped, not a real failure.

John Lauer ·f3d97c5762 ·2mo ago ·parent 7cdc778
4 files changed +44−7
adom-bridge-puppeteer-manifest.json+5−5
@@ -1,10 +1,10 @@ {   "manifest_version": 1,   "name": "puppeteer",-  "version": "2.0.272",-  "url": "https://wiki.adom.inc/download/adom/pup-bridge/2.0.272/adom-bridge-puppeteer-v2.0.272.zip",-  "sha256": "7007abab82fe336139871f8473ee82da2531ce800e5ae01114f41eda0db7dbb6",-  "size": 962731,+  "version": "2.0.274",+  "url": "https://wiki.adom.inc/download/adom/pup-bridge/2.0.274/adom-bridge-puppeteer-v2.0.274.zip",+  "sha256": "fff78766aa3159fb6382cab085c65fd54193ee0b114ee1ede74e57c5eac7a01d",+  "size": 963778,   "verbPrefixes": [     "browser_",     "desktop_recorder_",@@ -12,5 +12,5 @@   ],   "healthEndpoint": "/status",   "statusVerb": "browser_readiness",-  "released_at": "2026-08-21T19:28:42.525899Z"+  "released_at": "2026-08-21T23:15:00.887094Z" }
src/BRIDGE_VERSION+1−1
@@ -1 +1 @@-2.0.272\ No newline at end of file+2.0.274\ No newline at end of file
src/bridge.json+1−1
@@ -2,7 +2,7 @@   "manifest_version": 1,   "name": "puppeteer",   "displayName": "Puppeteer (Chrome for Testing + Native)",-  "version": "2.0.272",+  "version": "2.0.274",   "description": "Drives a browser ALREADY on the machine \u2014 installed Chrome, else Microsoft Edge (every Windows PC ships with Edge) \u2014 launched with a FRESH isolated profile, so the common case has NO ~150 MB Chrome-for-Testing download and it never touches the user's real tabs/logins. Binds its local server to LOOPBACK (127.0.0.1) only, so no Windows Firewall 'allow Node through the firewall' prompt ever pops. Chrome for Testing is fetched only as a LAST RESORT if the machine has no Chromium browser at all. SPAWN-VERIFIED fallback: pup tries each detected browser (Chrome \u2192 Edge \u2192 CfT) and actually launches it, falling through to the next if one won't start (and handling browsers like Edge that relaunch onto another PID), so a corrupt/partial install never hard-fails an open. The browser that launches is cached as the default (persisted across restarts) so it isn't re-probed each time. On spawn the bridge SELF-WARMS: detects browsers + disk, and only if the box has no Chrome/Edge and no cached CfT does it background-fetch CfT so the first open is instant. pup_use pins a specific browser (chrome | edge | cft | auto); {browser:'chrome',install:true} downloads & installs REAL Google Chrome (user-scoped, no admin) on an Edge-only box. pup_readiness (READ-ONLY) reports which browser will be used + the full candidate list + the default + free disk. Every failure returns a specific errorCode + _hint (chrome_install_no_disk, chrome_download_network, chrome_install_permission, chrome_stable_not_detected, \u2026). Launches with FULL browser permissions by default for full debug (strictPermissions:true opts out). Headful automation: open/close windows+tabs, navigate, screenshot, eval JS, record. pup is a GENERIC, non-profile browser only \u2014 every session is a fresh isolated Chrome/Edge process, never the user's real signed-in browser; profile defaults to sessionId. To drive the user's REAL Chrome/Edge (their profile, cookies, SSO), use the Adom browser EXTENSION's nbrowser_* verbs \u2014 a separate bridge, not pup's job. macOS (v1.9.74+): full parity with mac-native mechanics \u2014 background-by-default is the app-level hide (windows stay drivable/screenshottable while hidden), raise/lower map to unhide+activate/hide, pup_alert_window posts a native toast whose click focuses the window, pup_use {browser:'chrome',install:true} installs Chrome from the official dmg, and taskbar identity/badging remains Windows-only.",   "homepage": "https://wiki.adom.inc/adom/adom-bridge",   "author": "Adom Inc.",
src/server.js+37
@@ -16399,6 +16399,43 @@ const server = http.createServer(async (req, res) => {               result = { __error: e.message };             }           }+          // v2.0.274 (#69, second half): STATEMENTS, and stop swallowing the error.+          // The eval above is `new Function('return (' + expr + ')')` — EXPRESSION-only. The reporter+          // sent `location.assign('...'); 'navigating'`, which is two statements, so it was a+          // SyntaxError: nothing ran, the page never navigated, and the handler still answered+          // ok:true with the failure buried in result.__error. Measured verbatim:+          //     result: {"__error": "Unexpected token ';'"}   returned as a SUCCESS+          // Fix 1: on a SYNTAX error, retry through CDP Runtime.evaluate, which has devtools-console+          // semantics — it accepts a statement list and returns the completion value, so the same+          // source works and 'navigating' comes back.+          if (result && result.__error && /Unexpected token|SyntaxError|Unexpected end of input/i.test(String(result.__error))) {+            let cdpSession = null;+            try {+              cdpSession = await _evalCtx.target().createCDPSession();+              const r = await withTimeout(cdpSession.send('Runtime.evaluate', {+                expression: String(args.expr), returnByValue: true, awaitPromise: true, userGesture: true,+              }), 20_000, 'Runtime.evaluate');+              if (r && r.exceptionDetails) {+                result = { __error: (r.exceptionDetails.exception && r.exceptionDetails.exception.description) || r.exceptionDetails.text || 'evaluation threw' };+              } else {+                result = r && r.result ? r.result.value : null;+                console.log(`[eval] "${resolvedId}" expression form was a syntax error — ran it as STATEMENTS via Runtime.evaluate (devtools-console semantics)`);+              }+            } catch (e) {+              // A navigation started by the source tears down the context; that is the code WORKING.+              if (/context was destroyed|Execution context|Target closed/i.test(e.message || '')) {+                console.log(`[eval] "${resolvedId}" execution context was destroyed mid-eval — that means the page NAVIGATED, which is success, not failure`);+                result = { navigated: true };+              }+            } finally { try { if (cdpSession) await cdpSession.detach(); } catch (e) {} }+          }+          // Fix 2: a failed eval is a FAILED verb. #69's whole complaint is verbs that answer ok+          // while nothing happened; returning {ok:true, result:{__error}} is that exact lie.+          if (result && typeof result === 'object' && result.__error) {+            sendJSON(res, { success: false, errorCode: 'eval_failed', error: `pup_eval could not run your code: ${result.__error}`,+              _hint: 'The expression form is tried first, then a statement list via Runtime.evaluate. If this is a syntax error, check the source; if it names a detached frame or closed target, the tab moved and pup already retried once.' });+            return;+          }           sendJSON(res, { success: true, output: JSON.stringify({ ok: true, result, sessionId: resolvedId, tabId }) });           return;         }