← Commit history

Floaty-click harvest hoisted above the identity-support gate with a sweep heartbeat: the pencil must work even when identity stamping is unsupported, and a silent sweep is now visible in the log. Diagnosing the click flag being consumed with no action

John Lauer ·f29c49bd73 ·2mo ago ·parent 9f57b8d
4 files changed +28−23
adom-bridge-puppeteer-manifest.json+4−4
@@ -1,10 +1,10 @@ {   "manifest_version": 1,   "name": "puppeteer",-  "version": "2.0.66",-  "url": "https://wiki.adom.inc/download/adom/pup-bridge/2.0.66/adom-bridge-puppeteer-v2.0.66.zip",-  "sha256": "ccf94504dd365d7ce932ac5255668b0fd0c708151a81d6797424fe11ade9336b",-  "size": 832460,+  "version": "2.0.67",+  "url": "https://wiki.adom.inc/download/adom/pup-bridge/2.0.67/adom-bridge-puppeteer-v2.0.67.zip",+  "sha256": "f42cf9fbe2ef872a4e0e0e150010697c7c15e7138aeb27cb76ee2789bdce2066",+  "size": 832547,   "verbPrefixes": [     "browser_",     "desktop_recorder_",
src/BRIDGE_VERSION+1−1
@@ -1 +1 @@-2.0.66+2.0.67
src/bridge.json+1−1
@@ -2,7 +2,7 @@   "manifest_version": 1,   "name": "puppeteer",   "displayName": "Puppeteer (Chrome for Testing + Native)",-  "version": "2.0.66",+  "version": "2.0.67",   "description": "Drives a browser ALREADY on the machine \u2014 installed Chrome, else Microsoft Edge (every Windows PC ships with Edge) \u2014 launched with a FRESH isolated profile, so the common case has NO ~150 MB Chrome-for-Testing download and it never touches the user's real tabs/logins. Binds its local server to LOOPBACK (127.0.0.1) only, so no Windows Firewall 'allow Node through the firewall' prompt ever pops. Chrome for Testing is fetched only as a LAST RESORT if the machine has no Chromium browser at all. SPAWN-VERIFIED fallback: pup tries each detected browser (Chrome \u2192 Edge \u2192 CfT) and actually launches it, falling through to the next if one won't start (and handling browsers like Edge that relaunch onto another PID), so a corrupt/partial install never hard-fails an open. The browser that launches is cached as the default (persisted across restarts) so it isn't re-probed each time. On spawn the bridge SELF-WARMS: detects browsers + disk, and only if the box has no Chrome/Edge and no cached CfT does it background-fetch CfT so the first open is instant. pup_use pins a specific browser (chrome | edge | cft | auto); {browser:'chrome',install:true} downloads & installs REAL Google Chrome (user-scoped, no admin) on an Edge-only box. pup_readiness (READ-ONLY) reports which browser will be used + the full candidate list + the default + free disk. Every failure returns a specific errorCode + _hint (chrome_install_no_disk, chrome_download_network, chrome_install_permission, chrome_stable_not_detected, \u2026). Launches with FULL browser permissions by default for full debug (strictPermissions:true opts out). Headful automation: open/close windows+tabs, navigate, screenshot, eval JS, record. pup is a GENERIC, non-profile browser only \u2014 every session is a fresh isolated Chrome/Edge process, never the user's real signed-in browser; profile defaults to sessionId. To drive the user's REAL Chrome/Edge (their profile, cookies, SSO), use the Adom browser EXTENSION's nbrowser_* verbs \u2014 a separate bridge, not pup's job. macOS (v1.9.74+): full parity with mac-native mechanics \u2014 background-by-default is the app-level hide (windows stay drivable/screenshottable while hidden), raise/lower map to unhide+activate/hide, pup_alert_window posts a native toast whose click focuses the window, pup_use {browser:'chrome',install:true} installs Chrome from the official dmg, and taskbar identity/badging remains Windows-only.",   "homepage": "https://wiki.adom.inc/adom/adom-bridge",   "author": "Adom Inc.",
src/server.js+22−17
@@ -15156,7 +15156,28 @@ const _onPupBound = async () => {   // ALLOWED in minimal-touch (v1.9.191, gentle branding), so enforcement gets its OWN interval with no   // minimal-touch gate. 10s cadence: a window is never knowingly bare for more than ~10s.   setInterval(async () => {-    if (process.platform !== 'win32' || _identitySupported !== true) return;+    if (process.platform !== 'win32') return;+    // v2.0.67: floaty-click harvest runs BEFORE the identity gate (the pencil must work even when+    // identity stamping is unsupported) and heartbeats so a dead sweep is visible in the log.+    global.__floatyHb = (global.__floatyHb || 0) + 1;+    if (global.__floatyHb % 15 === 1) console.log(`[floaty] sweep heartbeat #${global.__floatyHb} (${sessions.size} session(s), identitySupported=${_identitySupported})`);+    try {+      for (const [sidF, sF] of [...sessions]) {+        if (sF._lostBrowser || !(sF.tabs || []).length) continue;+        for (const tF of (sF.tabs || [])) {+          if (!tF || !tF.page) continue;+          const clickedF = await Promise.race([+            tF.page.evaluate(() => { const c = window.__pupFloatyClick; window.__pupFloatyClick = null; return c || null; }),+            new Promise(r => setTimeout(() => r(null), 800)),+          ]).catch(() => null);+          if (clickedF) {+            console.log(`[floaty] "${sidF}" pencil clicked — starting annotate (pen) on ${tF.tabId}`);+            startAnnotation(sF, sidF, 'user-floaty', { tool: 'pen', tabId: tF.tabId }).catch(() => {});+          }+        }+      }+    } catch (e) { console.log(`[floaty] harvest error: ${e.message}`); }+    if (_identitySupported !== true) return;     try {       for (const [sid2, s2] of [...sessions]) {         if (s2._lostBrowser || !(s2.tabs || []).length) continue;@@ -15167,22 +15188,6 @@ const _onPupBound = async () => {         if (pupSettings().aumidIcons === 'on' && !s2._curAppId && Date.now() - (s2._stampTriedAt || 0) > 20000) {           s2._stampTriedAt = Date.now(); stampPupIdentity(sid2, { once: true }).catch(() => {});         }-        // v2.0.66: harvest floaty-pencil clicks (the in-page button can't reach the loopback;-        // this sweep is the bridge). Read-and-clear per tab; max ~4s click-to-toolbar.-        try {-          for (const t6 of (s2.tabs || [])) {-            if (!t6 || !t6.page) continue;-            const clicked = await Promise.race([-              t6.page.evaluate(() => { const c = window.__pupFloatyClick; window.__pupFloatyClick = null; return c || null; }),-              new Promise(r => setTimeout(() => r(null), 800)),-            ]).catch(() => null);-            if (clicked) {-              console.log(`[floaty] "${sid2}" pencil clicked — starting annotate (pen) on ${t6.tabId}`);-              startAnnotation(s2, sid2, 'user-floaty', { tool: 'pen', tabId: t6.tabId }).catch(() => {});-              break;-            }-          }-        } catch (e) {}         if (pupSettings().overlayBadges !== 'on') continue;         // v2.0.47: GROUND-TRUTH RE-ASSERT. Overlay state is write-only (Windows can't be asked         // whether the badge is still there), and shell-side events beyond the progress bar can