← Commit history

v2.0.241: An unrecognised wiki view value is rejected with the accepted list instead of being silently treated as the public view, which had let a caller asking for a signed-in view receive the public one alongside a response that technically said so and completely misled.

John Lauer ·f26c7484bb ·2mo ago ·parent cba31d5
4 files changed +16−7
adom-bridge-puppeteer-manifest.json+5−5
@@ -1,10 +1,10 @@ {   "manifest_version": 1,   "name": "puppeteer",-  "version": "2.0.240",-  "url": "https://wiki.adom.inc/download/adom/pup-bridge/2.0.240/adom-bridge-puppeteer-v2.0.240.zip",-  "sha256": "04a9d608389a4896bdb3cd2abf6aa342e60a9e56a557600219caf4c9fede24d1",-  "size": 944473,+  "version": "2.0.241",+  "url": "https://wiki.adom.inc/download/adom/pup-bridge/2.0.241/adom-bridge-puppeteer-v2.0.241.zip",+  "sha256": "2d6147e4981962bba309d76f9f814de9bd57146402d19c7700d82bc366cbcafe",+  "size": 944790,   "verbPrefixes": [     "browser_",     "desktop_recorder_",@@ -12,5 +12,5 @@   ],   "healthEndpoint": "/status",   "statusVerb": "browser_readiness",-  "released_at": "2026-08-18T13:39:48.922439Z"+  "released_at": "2026-08-18T13:56:09.667120Z" }
src/BRIDGE_VERSION+1−1
@@ -1 +1 @@-2.0.240\ No newline at end of file+2.0.241\ No newline at end of file
src/bridge.json+1−1
@@ -2,7 +2,7 @@   "manifest_version": 1,   "name": "puppeteer",   "displayName": "Puppeteer (Chrome for Testing + Native)",-  "version": "2.0.240",+  "version": "2.0.241",   "description": "Drives a browser ALREADY on the machine \u2014 installed Chrome, else Microsoft Edge (every Windows PC ships with Edge) \u2014 launched with a FRESH isolated profile, so the common case has NO ~150 MB Chrome-for-Testing download and it never touches the user's real tabs/logins. Binds its local server to LOOPBACK (127.0.0.1) only, so no Windows Firewall 'allow Node through the firewall' prompt ever pops. Chrome for Testing is fetched only as a LAST RESORT if the machine has no Chromium browser at all. SPAWN-VERIFIED fallback: pup tries each detected browser (Chrome \u2192 Edge \u2192 CfT) and actually launches it, falling through to the next if one won't start (and handling browsers like Edge that relaunch onto another PID), so a corrupt/partial install never hard-fails an open. The browser that launches is cached as the default (persisted across restarts) so it isn't re-probed each time. On spawn the bridge SELF-WARMS: detects browsers + disk, and only if the box has no Chrome/Edge and no cached CfT does it background-fetch CfT so the first open is instant. pup_use pins a specific browser (chrome | edge | cft | auto); {browser:'chrome',install:true} downloads & installs REAL Google Chrome (user-scoped, no admin) on an Edge-only box. pup_readiness (READ-ONLY) reports which browser will be used + the full candidate list + the default + free disk. Every failure returns a specific errorCode + _hint (chrome_install_no_disk, chrome_download_network, chrome_install_permission, chrome_stable_not_detected, \u2026). Launches with FULL browser permissions by default for full debug (strictPermissions:true opts out). Headful automation: open/close windows+tabs, navigate, screenshot, eval JS, record. pup is a GENERIC, non-profile browser only \u2014 every session is a fresh isolated Chrome/Edge process, never the user's real signed-in browser; profile defaults to sessionId. To drive the user's REAL Chrome/Edge (their profile, cookies, SSO), use the Adom browser EXTENSION's nbrowser_* verbs \u2014 a separate bridge, not pup's job. macOS (v1.9.74+): full parity with mac-native mechanics \u2014 background-by-default is the app-level hide (windows stay drivable/screenshottable while hidden), raise/lower map to unhide+activate/hide, pup_alert_window posts a native toast whose click focuses the window, pup_use {browser:'chrome',install:true} installs Chrome from the official dmg, and taskbar identity/badging remains Windows-only.",   "homepage": "https://wiki.adom.inc/adom/adom-bridge",   "author": "Adom Inc.",
src/server.js+9
@@ -14572,6 +14572,15 @@ const server = http.createServer(async (req, res) => {           // v2.0.139 (John: "add a shortcut key like annotate has"): view:"toggle" flips whatever           // the window currently shows — the Alt+Shift+V hotkey's form, since the extension can't           // know the current view. Explicit "authed"/"public" behave as before.+          // v2.0.241 (caught while verifying the guard rewrite): an UNRECOGNISED view was silently+          // coerced to 'public'. A caller asking for "signed-in" got the public view plus a response+          // claiming view:"public", unchanged:true — technically true, completely misleading. Reject+          // it and name the accepted values instead of guessing what the caller meant.+          if (args.view !== undefined && !['authed', 'public', 'toggle'].includes(args.view)) {+            sendJSON(res, { success: false, error: `view must be one of authed|public|toggle (got "${args.view}")`,+              _hint: 'authed = the signed-in view, public = what a logged-out visitor sees, toggle = flip whichever it is now. There is no "signed-in"/"private" alias: this used to fall through to public silently.' });+            return;+          }           const view = args.view === 'toggle'             ? (curView === 'authed' ? 'public' : 'authed')             : (args.view === 'authed' ? 'authed' : 'public');