← Commit history

v2.0.286: pup_screenshot: if a capture ever brings the window to the FOREGROUND (a window-level fallback when CDP can't serve it) with no recent user input, caption '<thread> · screenshotting' so the user always knows what put a window on their screen. No-op on the common CDP path (measured 0/101 non-foregrounding). John: uncaptioned screenshot-foregrounds are why he kept catching me.

John Lauer ·f163c77762 ·2mo ago ·parent 302889e
4 files changed +29−7
adom-bridge-puppeteer-manifest.json+5−5
@@ -1,10 +1,10 @@ {   "manifest_version": 1,   "name": "puppeteer",-  "version": "2.0.285",-  "url": "https://wiki.adom.inc/download/adom/pup-bridge/2.0.285/adom-bridge-puppeteer-v2.0.285.zip",-  "sha256": "ff250f121995c7a3d06705a702ba70eaf9450311b5bc375d72a39169995a51ba",-  "size": 968245,+  "version": "2.0.286",+  "url": "https://wiki.adom.inc/download/adom/pup-bridge/2.0.286/adom-bridge-puppeteer-v2.0.286.zip",+  "sha256": "5960a489f059eb555a063542ecd6de288d489c9038c198488d8f30650dbe51fa",+  "size": 968711,   "verbPrefixes": [     "browser_",     "desktop_recorder_",@@ -12,5 +12,5 @@   ],   "healthEndpoint": "/status",   "statusVerb": "browser_readiness",-  "released_at": "2026-08-22T21:00:08.805307Z"+  "released_at": "2026-08-22T21:34:00.365224Z" }
src/BRIDGE_VERSION+1−1
@@ -1 +1 @@-2.0.285\ No newline at end of file+2.0.286\ No newline at end of file
src/bridge.json+1−1
@@ -2,7 +2,7 @@   "manifest_version": 1,   "name": "puppeteer",   "displayName": "Puppeteer (Chrome for Testing + Native)",-  "version": "2.0.285",+  "version": "2.0.286",   "description": "Drives a browser ALREADY on the machine \u2014 installed Chrome, else Microsoft Edge (every Windows PC ships with Edge) \u2014 launched with a FRESH isolated profile, so the common case has NO ~150 MB Chrome-for-Testing download and it never touches the user's real tabs/logins. Binds its local server to LOOPBACK (127.0.0.1) only, so no Windows Firewall 'allow Node through the firewall' prompt ever pops. Chrome for Testing is fetched only as a LAST RESORT if the machine has no Chromium browser at all. SPAWN-VERIFIED fallback: pup tries each detected browser (Chrome \u2192 Edge \u2192 CfT) and actually launches it, falling through to the next if one won't start (and handling browsers like Edge that relaunch onto another PID), so a corrupt/partial install never hard-fails an open. The browser that launches is cached as the default (persisted across restarts) so it isn't re-probed each time. On spawn the bridge SELF-WARMS: detects browsers + disk, and only if the box has no Chrome/Edge and no cached CfT does it background-fetch CfT so the first open is instant. pup_use pins a specific browser (chrome | edge | cft | auto); {browser:'chrome',install:true} downloads & installs REAL Google Chrome (user-scoped, no admin) on an Edge-only box. pup_readiness (READ-ONLY) reports which browser will be used + the full candidate list + the default + free disk. Every failure returns a specific errorCode + _hint (chrome_install_no_disk, chrome_download_network, chrome_install_permission, chrome_stable_not_detected, \u2026). Launches with FULL browser permissions by default for full debug (strictPermissions:true opts out). Headful automation: open/close windows+tabs, navigate, screenshot, eval JS, record. pup is a GENERIC, non-profile browser only \u2014 every session is a fresh isolated Chrome/Edge process, never the user's real signed-in browser; profile defaults to sessionId. To drive the user's REAL Chrome/Edge (their profile, cookies, SSO), use the Adom browser EXTENSION's nbrowser_* verbs \u2014 a separate bridge, not pup's job. macOS (v1.9.74+): full parity with mac-native mechanics \u2014 background-by-default is the app-level hide (windows stay drivable/screenshottable while hidden), raise/lower map to unhide+activate/hide, pup_alert_window posts a native toast whose click focuses the window, pup_use {browser:'chrome',install:true} installs Chrome from the official dmg, and taskbar identity/badging remains Windows-only.",   "homepage": "https://wiki.adom.inc/adom/adom-bridge",   "author": "Adom Inc.",
src/server.js+22
@@ -16140,6 +16140,11 @@ const server = http.createServer(async (req, res) => {           const fullPage = args.fullPage || false;           const maxWidth = args.maxWidth || MAX_SCREENSHOT_DIM;           const ts = Date.now();+          // v2.0.286 (John): a capture can sometimes bring the window to the FOREGROUND (pup falling+          // back to a window-level grab when the CDP path can't serve it). When that happens the user+          // must be told WHY — the missing caption is exactly why uncaptioned foregrounds slipped past.+          // Snapshot the OS foreground before the capture so we can detect+caption it after.+          const _fgBefore = await osGetForegroundWindow().catch(() => null);           let screenshotBuf = await withTimeout(             // v2.0.186 (#50): captureBeyondViewport defaults TRUE in current puppeteer, which renders             // from the document ORIGIN — so a viewport screenshot ignored the page's live scroll@@ -16148,6 +16153,23 @@ const server = http.createServer(async (req, res) => {             raceCrash(tab, resolvedId, tab.page.screenshot({ type: 'png', fullPage, captureBeyondViewport: fullPage })),             20_000, 'page.screenshot'           );+          // If the capture foregrounded THIS window AND there was no recent user input (so it was pup,+          // not the user clicking it), caption "<thread> · screenshotting" so the user knows what put it+          // on their screen. No-op on the common CDP path, which never foregrounds (measured 0/101).+          try {+            const _hw = session && session._hwnd;+            if (_hw) {+              const _fgAfter = await osGetForegroundWindow().catch(() => null);+              if (_fgAfter && String(_fgAfter) === String(_hw) && String(_fgAfter) !== String(_fgBefore)) {+                let _idle = 99999; try { _idle = await osIdleMs(); } catch (e) {}+                if (_idle > 3000) {+                  const _thread = session.owner || session._ownerThread || 'an AI thread';+                  pupCaption(`${_thread} · screenshotting`, 4000, 'pup-screenshot').catch(() => {});+                  console.log(`[screenshot] "${resolvedId}" came to the FOREGROUND during capture (user idle ${_idle}ms = pup did it) — captioned "${_thread} · screenshotting"`);+                }+              }+            }+          } catch (e) {}           // v1.8.21: fullPage only covers DOCUMENT-level scroll. On SPAs that scroll inside           // a nested container (the document itself doesn't grow), fullPage silently returns           // just the visible viewport. Detect that and hand the caller the right tool.