← Commit history

Find and fix the ACTUAL hole behind the bare first taskbar button, by tracing the decode path instead of guessing at pixels for a sixth time. The 1.9.205 glyph fallback only covered 'no favicon FOUND at all'. But when a favicon IS found and sharp cannot DECODE it — a BMP-encoded .ico (which icoLargestPng deliberately returns null for), or a malformed/exotic SVG — iconPng stayed null while src was truthy, so that fallback never ran, no favicon layer was pushed, and the composite came out as the Adom mark ALONE. That is exactly the 'no main overlay icon' John pointed at through five revisions, and no amount of colour or size tuning could have fixed it. Now ANY undecodable favicon falls back to the generic glyph, so a badge can never be mark-only. Also fixes the non-ico decode to resize 48/cover to match the 48px composite (it was still 22/inside from the old 32px layout, which left transparent margins and made badges look inconsistently sized).

John Lauer ·efec3a9407 ·3mo ago ·parent ed148a2
4 files changed +26−7
adom-bridge-puppeteer-manifest.json+4−4
@@ -1,10 +1,10 @@ {   "manifest_version": 1,   "name": "puppeteer",-  "version": "1.9.206",-  "url": "https://wiki.adom.inc/download/adom/adom-desktop-puppeteer-bridge/1.9.206/adom-bridge-puppeteer-v1.9.206.zip",-  "sha256": "35eb17609c85750465a9b00d07fd3522891edb311e5d286faf122b25a593a385",-  "size": 437433,+  "version": "1.9.207",+  "url": "https://wiki.adom.inc/download/adom/adom-desktop-puppeteer-bridge/1.9.207/adom-bridge-puppeteer-v1.9.207.zip",+  "sha256": "4020850aa27509e51ec859489b66b6f583b753ff3d592b10f66f0fad780e10ba",+  "size": 437858,   "verbPrefixes": [     "browser_",     "desktop_recorder_",
src/BRIDGE_VERSION+1−1
@@ -1 +1 @@-1.9.206+1.9.207
src/bridge.json+1−1
@@ -2,7 +2,7 @@   "manifest_version": 1,   "name": "puppeteer",   "displayName": "Puppeteer (Chrome for Testing + Native)",-  "version": "1.9.206",+  "version": "1.9.207",   "description": "Drives a browser ALREADY on the machine \u2014 installed Chrome, else Microsoft Edge (every Windows PC ships with Edge) \u2014 launched with a FRESH isolated profile, so the common case has NO ~150 MB Chrome-for-Testing download and it never touches the user's real tabs/logins. Binds its local server to LOOPBACK (127.0.0.1) only, so no Windows Firewall 'allow Node through the firewall' prompt ever pops. Chrome for Testing is fetched only as a LAST RESORT if the machine has no Chromium browser at all. SPAWN-VERIFIED fallback: pup tries each detected browser (Chrome \u2192 Edge \u2192 CfT) and actually launches it, falling through to the next if one won't start (and handling browsers like Edge that relaunch onto another PID), so a corrupt/partial install never hard-fails an open. The browser that launches is cached as the default (persisted across restarts) so it isn't re-probed each time. On spawn the bridge SELF-WARMS: detects browsers + disk, and only if the box has no Chrome/Edge and no cached CfT does it background-fetch CfT so the first open is instant. browser_use pins a specific browser (chrome | edge | cft | auto); {browser:'chrome',install:true} downloads & installs REAL Google Chrome (user-scoped, no admin) on an Edge-only box. browser_readiness (READ-ONLY) reports which browser will be used + the full candidate list + the default + free disk. Every failure returns a specific errorCode + _hint (chrome_install_no_disk, chrome_download_network, chrome_install_permission, chrome_stable_not_detected, \u2026). Launches with FULL browser permissions by default for full debug (strictPermissions:true opts out). Headful automation: open/close windows+tabs, navigate, screenshot, eval JS, record. pup is a GENERIC, non-profile browser only \u2014 every session is a fresh isolated Chrome/Edge process, never the user's real signed-in browser; profile defaults to sessionId. To drive the user's REAL Chrome/Edge (their profile, cookies, SSO), use the Adom browser EXTENSION's nbrowser_* verbs \u2014 a separate bridge, not pup's job. macOS (v1.9.74+): full parity with mac-native mechanics \u2014 background-by-default is the app-level hide (windows stay drivable/screenshottable while hidden), raise/lower map to unhide+activate/hide, browser_alert_window posts a native toast whose click focuses the window, browser_use {browser:'chrome',install:true} installs Chrome from the official dmg, and taskbar identity/badging remains Windows-only.",   "homepage": "https://wiki.adom.inc/adom/adom-desktop",   "author": "Adom Inc.",
src/server.js+20−1
@@ -3998,7 +3998,26 @@ async function applyAppOverlay(session, sessionId) {             } catch (e) { iconPng = null; }           }           if (!iconPng && !isIco) {-            try { iconPng = await sharpMod(Buffer.from(src.b64, 'base64')).resize(22, 22, { fit: 'inside' }).png().toBuffer(); } catch (e) { iconPng = null; }+            try { iconPng = await sharpMod(Buffer.from(src.b64, 'base64')).resize(48, 48, { fit: 'cover' }).png().toBuffer(); } catch (e) { iconPng = null; }+          }+          // v1.9.207 — THE ACTUAL HOLE behind John's bare first button, found by tracing the decode+          // path instead of guessing at pixels again. The glyph fallback added in 1.9.205 only covers+          // "no favicon FOUND at all". But when a favicon IS found and sharp cannot DECODE it (a+          // BMP-encoded .ico, which icoLargestPng deliberately returns null for; a malformed or+          // exotic SVG), iconPng stays null while src is truthy — so that fallback never ran, no+          // favicon layer was pushed, and the composite ended up as the Adom mark ALONE. That is+          // precisely the "no main overlay icon" he kept pointing at, through five revisions.+          // Any undecodable favicon now falls back to the glyph, so a badge can NEVER be mark-only.+          if (!iconPng) {+            try {+              const gsvg = Buffer.from('<svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 48 48">'+                + '<rect x="0" y="0" width="48" height="48" rx="10" fill="#12e0c4"/>'+                + '<circle cx="24" cy="24" r="14" fill="none" stroke="#06282a" stroke-width="4"/>'+                + '<ellipse cx="24" cy="24" rx="6" ry="14" fill="none" stroke="#06282a" stroke-width="3.4"/>'+                + '<path d="M10 24 H38" stroke="#06282a" stroke-width="3.4"/></svg>');+              iconPng = await sharpMod(gsvg).resize(48, 48).png().toBuffer();+              console.log(`[overlay] "${sessionId}" favicon found but UNDECODABLE (${src.mime || 'unknown mime'}) — using the generic glyph so the badge is never mark-only`);+            } catch (e) {}           }           // v1.9.191 (John's design): a TRULY BRANDED badge = the page's own favicon as the main           // image, with the Adom mark tucked into the LOWER-RIGHT corner, so one glance says both