← Commit history

Gate the AUMID stamp at its choke point so minimal-touch is actually silent. Live measurement showed mt3 still getting [identity] stamps from callers that bypassed the launch-path gate; stampPupIdentity and brandPupWindow now no-op in minimal mode, so nothing can leak a taskbar-identity change (which makes Windows destroy and recreate the window's taskbar button).

John Lauer ·ef00104dbd ·3mo ago ·parent 8f38524
4 files changed +11−6
adom-bridge-puppeteer-manifest.json+4−4
@@ -1,10 +1,10 @@ {   "manifest_version": 1,   "name": "puppeteer",-  "version": "1.9.187",-  "url": "https://wiki.adom.inc/download/adom/adom-desktop-puppeteer-bridge/1.9.187/adom-bridge-puppeteer-v1.9.187.zip",-  "sha256": "a6bad6c6573b327a5751fce1e157d20871b40f3e3522bccc61d1fadf4e7750cb",-  "size": 422861,+  "version": "1.9.188",+  "url": "https://wiki.adom.inc/download/adom/adom-desktop-puppeteer-bridge/1.9.188/adom-bridge-puppeteer-v1.9.188.zip",+  "sha256": "ee65c15c1e201092ba6fad4dd8bc7ec8a2e8dd44ae1dddc1ac0ffe2176ca8d91",+  "size": 422986,   "verbPrefixes": [     "browser_",     "desktop_recorder_",
src/BRIDGE_VERSION+1−1
@@ -1 +1 @@-1.9.187+1.9.188
src/bridge.json+1−1
@@ -2,7 +2,7 @@   "manifest_version": 1,   "name": "puppeteer",   "displayName": "Puppeteer (Chrome for Testing + Native)",-  "version": "1.9.187",+  "version": "1.9.188",   "description": "Drives a browser ALREADY on the machine \u2014 installed Chrome, else Microsoft Edge (every Windows PC ships with Edge) \u2014 launched with a FRESH isolated profile, so the common case has NO ~150 MB Chrome-for-Testing download and it never touches the user's real tabs/logins. Binds its local server to LOOPBACK (127.0.0.1) only, so no Windows Firewall 'allow Node through the firewall' prompt ever pops. Chrome for Testing is fetched only as a LAST RESORT if the machine has no Chromium browser at all. SPAWN-VERIFIED fallback: pup tries each detected browser (Chrome \u2192 Edge \u2192 CfT) and actually launches it, falling through to the next if one won't start (and handling browsers like Edge that relaunch onto another PID), so a corrupt/partial install never hard-fails an open. The browser that launches is cached as the default (persisted across restarts) so it isn't re-probed each time. On spawn the bridge SELF-WARMS: detects browsers + disk, and only if the box has no Chrome/Edge and no cached CfT does it background-fetch CfT so the first open is instant. browser_use pins a specific browser (chrome | edge | cft | auto); {browser:'chrome',install:true} downloads & installs REAL Google Chrome (user-scoped, no admin) on an Edge-only box. browser_readiness (READ-ONLY) reports which browser will be used + the full candidate list + the default + free disk. Every failure returns a specific errorCode + _hint (chrome_install_no_disk, chrome_download_network, chrome_install_permission, chrome_stable_not_detected, \u2026). Launches with FULL browser permissions by default for full debug (strictPermissions:true opts out). Headful automation: open/close windows+tabs, navigate, screenshot, eval JS, record. pup is a GENERIC, non-profile browser only \u2014 every session is a fresh isolated Chrome/Edge process, never the user's real signed-in browser; profile defaults to sessionId. To drive the user's REAL Chrome/Edge (their profile, cookies, SSO), use the Adom browser EXTENSION's nbrowser_* verbs \u2014 a separate bridge, not pup's job. macOS (v1.9.74+): full parity with mac-native mechanics \u2014 background-by-default is the app-level hide (windows stay drivable/screenshottable while hidden), raise/lower map to unhide+activate/hide, browser_alert_window posts a native toast whose click focuses the window, browser_use {browser:'chrome',install:true} installs Chrome from the official dmg, and taskbar identity/badging remains Windows-only.",   "homepage": "https://wiki.adom.inc/adom/adom-desktop",   "author": "Adom Inc.",
src/server.js+5
@@ -2687,6 +2687,10 @@ async function ensurePupIdentityRegistered() {   } catch (e) { console.log(`[identity] register threw: ${e.message}`); return false; } } async function stampPupIdentity(sessionId) {+  // v1.9.185 minimal-touch: the AUMID stamp is the single most invasive thing pup does to a window+  // it does not own (Windows DESTROYS and RECREATES the taskbar button on an AppUserModelID change).+  // Gated at the choke point so no caller can leak it.+  if (minimalTouch()) return false;   if (process.platform !== 'win32' || !sessionId || _identitySupported === false) return false;   if (!_identityRegistered) { await ensurePupIdentityRegistered(); if (_identitySupported === false) return false; }   try {@@ -4285,6 +4289,7 @@ async function refreshWindowChrome(session, sessionId, tries = 5) { } // Brand a pup window: full identity on capable AD, overlay badge fallback on older AD. async function brandPupWindow(sessionId) {+  if (minimalTouch()) return false;   // v1.9.185: no taskbar identity/branding in minimal mode   const stamped = await stampPupIdentity(sessionId);   if (stamped) return true;   // v1.9.52: if identity IS supported, a false here is a transient "not yet" (window not findable,