Pup - the AI's own browser

@@ -8078,17 +8078,22 @@ async function launchSession(sessionId, url, { freshProfile = false, profile, st     console.log(`Welcome page failed to load (non-fatal): ${e.message}`);   } -  // v2.0.11 (John): PLACEMENT-FIRST. The OS taskbar button appears the instant Chrome creates the-  // (off-screen) window, so under the old "defer the park until the real URL settled" order a user-  // who clicked that flashing button mid-load saw NOTHING — the window sat off-screen for the whole-  // nav. We now DEFINE and KICK OFF the park immediately below, right after the fast local welcome-  // load and BEFORE both the real-URL nav and the AUMID stamp, so the button always maps to a-  // correctly placed (background, z-bottom) window. Trade-off vs the old order: the first-  // cross-origin paint-raise is no longer hidden by off-screen-ness; the existing z-bottom-  // re-asserts (post-nav re-bottom + the +2.5s pass inside kickoffPark) correct it instead.-  // Deterministic reveal for the user beats hiding a rare, self-correcting blip.-  // Only for a freshly launched browser — a reused window is already placed, and re-parking it could-  // hide a window the user has up (kickoffPark guards on that).+  // v1.8.73: stamp the window IDENTITY at CREATE (per the AD contract: identity is per-HWND —+  // stamping only at park would leave the window reading "Google Chrome for Testing" during its+  // whole load). The welcome page just set the "(session: <id>)" title, so AD can resolve it.+  // Fire-and-forget; the park re-brands (with badge fallback) as belt-and-suspenders.+  // v1.9.185 minimal-touch: do NOT stamp a per-session AUMID. Changing a window's AppUserModelID+  // makes Windows DESTROY and RECREATE its taskbar button — the single most invasive thing pup did+  // to a window it does not own. In minimal mode the window keeps Chrome's own identity.+  if (process.platform === 'win32' && (!minimalTouch() || pupSettings().aumidIcons === 'on')) { stampPupIdentity(sessionId, { once: true }).catch(() => {}); }++  // v1.8.68: the park is DEFINED here but KICKED OFF only after the real URL's navigation has+  // SETTLED (below). Rationale: the first cross-origin paint RAISES the window; if the window+  // is already placed on-screen (even at z-bottom), the user sees a blip on top of their work+  // (the adom/wiki thread's window John caught). Parking after settle means the paint-raise+  // hits a window still OFF-SCREEN — invisible, harmless. The window's first visible moment is+  // full-size, z-bottomed, and z-confirmed. Only for a freshly launched browser (_needsPark) —+  // a reused window is already placed, and re-parking it could hide a window the user has up.   const kickoffPark = () => {     if (foreground || (process.platform !== 'win32' && process.platform !== 'darwin')) return;     try {@@ -8124,30 +8129,13 @@ async function launchSession(sessionId, url, { freshProfile = false, profile, st       }     } catch (e) {}   };-  // Kick the park off NOW (placement-first): the window is positioned on-screen at z-bottom right-  // after the fast welcome load, before the flash below and before the multi-second real-URL nav.-  kickoffPark();--  // Stamp identity now that the window is placed. Identity is per-HWND (AD contract), so stamping at-  // create keeps it from reading "Google Chrome for Testing" during load; the welcome page already-  // set the "(session: <id>)" title so AD can resolve it. Fire-and-forget; the park re-brands (badge-  // fallback) as belt-and-suspenders. minimal-touch: do NOT stamp a per-session AUMID (changing the-  // AppUserModelID makes Windows destroy+recreate the taskbar button) — the window keeps Chrome's own-  // identity in minimal mode.-  if (process.platform === 'win32' && (!minimalTouch() || pupSettings().aumidIcons === 'on')) { stampPupIdentity(sessionId, { once: true }).catch(() => {}); }   // v1.8.36: SNAPPY auto-flash. The window already exists + is backgrounded here (the   // welcome page loaded from a local file), so flash the taskbar NOW — do not wait for the   // real URL's domcontentloaded, which for heavy sites is another 1–3s. Set _flashState so   // the open handler's later scheduleAutoFlash debounces (no double flash). Fire-and-forget.   if (!foreground && !silent && process.platform === 'win32') {     // v1.9.185 minimal-touch: no taskbar flash at all (and no log noise pretending one fired).-    // v2.0.11 (John): wait for the placement-first park's first pass to land BEFORE flashing, so the-    // instant the flash pulls the user's eye to the taskbar button, clicking it reveals a window that-    // is already on-screen — never the old "click the flash, see nothing" off-screen gap.-    if (pupSettings().openFlash === 'on') {-      try { const _be = browsers.get(profileName); if (_be && _be.browser && _be.browser._bgPromise) await _be.browser._bgPromise; } catch (e) {}-      try { _flashState.set(sessionId, Date.now()); _openFlashDone.set(sessionId, Date.now()); console.log(`[flash] "${sessionId}" (launch)`); flashViaAD(sessionId, { force: true }); } catch (e) {}-    }+    if (pupSettings().openFlash === 'on') { try { _flashState.set(sessionId, Date.now()); _openFlashDone.set(sessionId, Date.now()); console.log(`[flash] "${sessionId}" (launch)`); flashViaAD(sessionId, { force: true }); } catch (e) {} }   }    if (url) {@@ -8162,10 +8150,9 @@ async function launchSession(sessionId, url, { freshProfile = false, profile, st     // v1.9.105: keep the main-frame HTTP status — the strongest broken-render signal there is.     const _resp = await page.goto(url, { waitUntil: 'domcontentloaded', timeout: 30000 });     try { page.__pupHttpStatus = _resp && typeof _resp.status === 'function' ? _resp.status() : null; } catch (e) {}-    // Wait for the page to SETTLE (load event, capped at 2.5s) so the prompt re-bottom below lands-    // AFTER the first cross-origin paint (the paint that can raise the window). Skip if already-    // complete. (Placement-first, v2.0.11: the window is already on-screen at z-bottom by now — this-    // wait just times the corrective re-bottom rather than hiding the raise off-screen.)+    // v1.8.68: wait for the page to SETTLE (load event, capped at 2.5s) while the window is+    // still OFF-SCREEN, so the first paint's window-raise is invisible. Skip the wait if the+    // page is already complete.     if (!foreground && process.platform === 'win32') {       try {         const ready = await page.evaluate(() => document.readyState).catch(() => 'unknown');@@ -8180,10 +8167,9 @@ async function launchSession(sessionId, url, { freshProfile = false, profile, st       setTimeout(() => { reassertBottomAfterNav(sessionId).catch(() => {}); }, 3000);     }   }-  // Park already happened early (placement-first, before the nav). Now that the real URL has-  // painted, re-assert z-bottom once promptly so any first-paint raise is corrected fast (the-  // +2.5s kickoffPark pass and the +3s post-nav timer are the slower belt-and-suspenders).-  if (!foreground && (process.platform === 'win32' || process.platform === 'darwin')) { reassertBottomAfterNav(sessionId).catch(() => {}); }+  // Park now — after settle (url path) or right away (welcome-only path). The paint-raise+  // already happened off-screen; the window's first visible frame is full-size at z-bottom.+  kickoffPark();    // Belt and suspenders: close any tab in this Chrome that's NOT claimed by   // a registered session. This catches two cases: