← Commit history

Fix duplicate tab on burst opens: the popup-tracker was double-attaching pup's own in-window window.open blanks (which addTabToSession already adopts); it now skips any tab tagged with the pupclaim_ window.name marker

John Lauer ·ee5f3220f0 ·3mo ago ·parent 8abe88b
4 files changed +17−6
adom-bridge-puppeteer-manifest.json+4−4
@@ -1,10 +1,10 @@ {   "manifest_version": 1,   "name": "puppeteer",-  "version": "1.9.295",-  "url": "https://wiki.adom.inc/download/adom/adom-desktop-puppeteer-bridge/1.9.295/adom-bridge-puppeteer-v1.9.295.zip",-  "sha256": "fc4cf70cfe17bbf2518e0a85923e584e1a1db362f5341729f1c829263ced6dd2",-  "size": 720542,+  "version": "1.9.296",+  "url": "https://wiki.adom.inc/download/adom/adom-desktop-puppeteer-bridge/1.9.296/adom-bridge-puppeteer-v1.9.296.zip",+  "sha256": "34235f89286e45b0af48aceb0b77eb5ebd490a787a6c189eb6f21df96484a2ff",+  "size": 720885,   "verbPrefixes": [     "browser_",     "desktop_recorder_",
src/BRIDGE_VERSION+1−1
@@ -1 +1 @@-1.9.295+1.9.296
src/bridge.json+1−1
@@ -2,7 +2,7 @@   "manifest_version": 1,   "name": "puppeteer",   "displayName": "Puppeteer (Chrome for Testing + Native)",-  "version": "1.9.295",+  "version": "1.9.296",   "description": "Drives a browser ALREADY on the machine \u2014 installed Chrome, else Microsoft Edge (every Windows PC ships with Edge) \u2014 launched with a FRESH isolated profile, so the common case has NO ~150 MB Chrome-for-Testing download and it never touches the user's real tabs/logins. Binds its local server to LOOPBACK (127.0.0.1) only, so no Windows Firewall 'allow Node through the firewall' prompt ever pops. Chrome for Testing is fetched only as a LAST RESORT if the machine has no Chromium browser at all. SPAWN-VERIFIED fallback: pup tries each detected browser (Chrome \u2192 Edge \u2192 CfT) and actually launches it, falling through to the next if one won't start (and handling browsers like Edge that relaunch onto another PID), so a corrupt/partial install never hard-fails an open. The browser that launches is cached as the default (persisted across restarts) so it isn't re-probed each time. On spawn the bridge SELF-WARMS: detects browsers + disk, and only if the box has no Chrome/Edge and no cached CfT does it background-fetch CfT so the first open is instant. browser_use pins a specific browser (chrome | edge | cft | auto); {browser:'chrome',install:true} downloads & installs REAL Google Chrome (user-scoped, no admin) on an Edge-only box. browser_readiness (READ-ONLY) reports which browser will be used + the full candidate list + the default + free disk. Every failure returns a specific errorCode + _hint (chrome_install_no_disk, chrome_download_network, chrome_install_permission, chrome_stable_not_detected, \u2026). Launches with FULL browser permissions by default for full debug (strictPermissions:true opts out). Headful automation: open/close windows+tabs, navigate, screenshot, eval JS, record. pup is a GENERIC, non-profile browser only \u2014 every session is a fresh isolated Chrome/Edge process, never the user's real signed-in browser; profile defaults to sessionId. To drive the user's REAL Chrome/Edge (their profile, cookies, SSO), use the Adom browser EXTENSION's nbrowser_* verbs \u2014 a separate bridge, not pup's job. macOS (v1.9.74+): full parity with mac-native mechanics \u2014 background-by-default is the app-level hide (windows stay drivable/screenshottable while hidden), raise/lower map to unhide+activate/hide, browser_alert_window posts a native toast whose click focuses the window, browser_use {browser:'chrome',install:true} installs Chrome from the official dmg, and taskbar identity/badging remains Windows-only.",   "homepage": "https://wiki.adom.inc/adom/adom-desktop",   "author": "Adom Inc.",
src/server.js+11
@@ -797,6 +797,17 @@ function wirePopupTracking(browser, profileName) {       const popupPage = await target.page();       if (!popupPage) return; +      // v1.9.296: skip pup's OWN in-window tab creations. addTabToSession opens a+      // window.open("about:blank") tagged with a unique window.name ("pupclaim_…") and adopts it+      // explicitly. When that blank's opener happened to be observable here, the tracker ALSO+      // attached the very same page — double-attaching it (two tab rows for one tab: the duplicate+      // John saw on a burst of opens). The marker is authoritative: these belong to addTabToSession,+      // so the tracker must not touch them. (Real page-initiated popups have no such marker.)+      try {+        const nm = await popupPage.evaluate(() => window.name);+        if (typeof nm === 'string' && nm.indexOf('pupclaim_') === 0) return;+      } catch (e) { /* can't read it (mid-nav) — fall through to the registered-page dedup below */ }+       // Skip if some session already has this page registered (we attached it       // explicitly; this is the targetcreated event firing for our own creation).       for (const s of sessions.values()) {