← Commit history

Issue #5 (John, 2026-07-06) — browser_raise_os_window now resolves the window by the TRACKED HANDLE instead of matching the title suffix. His original point: right after a navigation the new page sets its own title BEFORE the bridge re-appends '(session: <id>)', so the lookup fails; and it turns out Chrome's PDF viewer never carries the suffix at all, which is what made PDF windows unraisable and their taskbar buttons unpaintable — a full day was spent rediscovering that this week. sessionHwnd() now prefers the handle pup stores at park, falls back to geometry-matching against the profile's Chrome PID (v1.9.216), and only then to a title lookup, so raise targets the same window regardless of what its title currently says.

John Lauer ·ed77f46340 ·3mo ago ·parent 0b71616
4 files changed +18−8
adom-bridge-puppeteer-manifest.json+4−4
@@ -1,10 +1,10 @@ {   "manifest_version": 1,   "name": "puppeteer",-  "version": "1.9.219",-  "url": "https://wiki.adom.inc/download/adom/adom-desktop-puppeteer-bridge/1.9.219/adom-bridge-puppeteer-v1.9.219.zip",-  "sha256": "0d2eacb58abce46feafb5dc4822a3ecea4078b9ab4342e0ce562ad761d5da377",-  "size": 445693,+  "version": "1.9.220",+  "url": "https://wiki.adom.inc/download/adom/adom-desktop-puppeteer-bridge/1.9.220/adom-bridge-puppeteer-v1.9.220.zip",+  "sha256": "3b1284f9af9a9322db059ecede2117f284b3bac427f5af4d16ef1b10cc229909",+  "size": 446007,   "verbPrefixes": [     "browser_",     "desktop_recorder_",
src/BRIDGE_VERSION+1−1
@@ -1 +1 @@-1.9.219+1.9.220
src/bridge.json+1−1
@@ -2,7 +2,7 @@   "manifest_version": 1,   "name": "puppeteer",   "displayName": "Puppeteer (Chrome for Testing + Native)",-  "version": "1.9.219",+  "version": "1.9.220",   "description": "Drives a browser ALREADY on the machine \u2014 installed Chrome, else Microsoft Edge (every Windows PC ships with Edge) \u2014 launched with a FRESH isolated profile, so the common case has NO ~150 MB Chrome-for-Testing download and it never touches the user's real tabs/logins. Binds its local server to LOOPBACK (127.0.0.1) only, so no Windows Firewall 'allow Node through the firewall' prompt ever pops. Chrome for Testing is fetched only as a LAST RESORT if the machine has no Chromium browser at all. SPAWN-VERIFIED fallback: pup tries each detected browser (Chrome \u2192 Edge \u2192 CfT) and actually launches it, falling through to the next if one won't start (and handling browsers like Edge that relaunch onto another PID), so a corrupt/partial install never hard-fails an open. The browser that launches is cached as the default (persisted across restarts) so it isn't re-probed each time. On spawn the bridge SELF-WARMS: detects browsers + disk, and only if the box has no Chrome/Edge and no cached CfT does it background-fetch CfT so the first open is instant. browser_use pins a specific browser (chrome | edge | cft | auto); {browser:'chrome',install:true} downloads & installs REAL Google Chrome (user-scoped, no admin) on an Edge-only box. browser_readiness (READ-ONLY) reports which browser will be used + the full candidate list + the default + free disk. Every failure returns a specific errorCode + _hint (chrome_install_no_disk, chrome_download_network, chrome_install_permission, chrome_stable_not_detected, \u2026). Launches with FULL browser permissions by default for full debug (strictPermissions:true opts out). Headful automation: open/close windows+tabs, navigate, screenshot, eval JS, record. pup is a GENERIC, non-profile browser only \u2014 every session is a fresh isolated Chrome/Edge process, never the user's real signed-in browser; profile defaults to sessionId. To drive the user's REAL Chrome/Edge (their profile, cookies, SSO), use the Adom browser EXTENSION's nbrowser_* verbs \u2014 a separate bridge, not pup's job. macOS (v1.9.74+): full parity with mac-native mechanics \u2014 background-by-default is the app-level hide (windows stay drivable/screenshottable while hidden), raise/lower map to unhide+activate/hide, browser_alert_window posts a native toast whose click focuses the window, browser_use {browser:'chrome',install:true} installs Chrome from the official dmg, and taskbar identity/badging remains Windows-only.",   "homepage": "https://wiki.adom.inc/adom/adom-desktop",   "author": "Adom Inc.",
src/server.js+12−2
@@ -9268,8 +9268,18 @@ const server = http.createServer(async (req, res) => {             }             if (process.platform === 'win32') {               try {-                const fw = adPayload(await chrome.adCommand('desktop_find_window', { titleContains: `(session: ${sessionId}` }, { timeoutMs: 5000 , caller: sessionCaller(sessions.get(sessionId))}));-                const hwnd = fw && fw.best && fw.best.hwnd;+                // v1.9.220 (wiki issue #5, John, 2026-07-06): TRACK THE HANDLE, don't match the title.+                // Title-matching is fragile exactly as he described — right after a navigation the new+                // page sets its own title before the bridge re-appends the "(session: <id>)" suffix, so+                // the lookup fails; and Chrome's PDF viewer never carries the suffix at all, which is+                // what made PDF windows unraisable/unpaintable. sessionHwnd() now prefers the handle+                // pup stored at park (falling back to bounds-matching, then a title lookup), so the+                // raise resolves the SAME window regardless of what its title currently says.+                let hwnd = await sessionHwnd(sessionId);+                if (!hwnd) {+                  const fw = adPayload(await chrome.adCommand('desktop_find_window', { titleContains: `(session: ${sessionId}` }, { timeoutMs: 5000 , caller: sessionCaller(sessions.get(sessionId))}));+                  hwnd = fw && fw.best && fw.best.hwnd;+                }                 if (hwnd) {                   const psPath = path.join(require('os').tmpdir(), '_adom_focus_hwnd.ps1');                   fs.writeFileSync(psPath, [