← Commit history

Skill 1.8.8: CfT skipped:true is intended conditional-prewarm behavior (not a failure); adopt refresh_bridges/restart_bridge/staleProcess as the canonical push-live recipe

John Lauer ·eb8e72a3ce · ·parent 9c02218
3 files changed +16−1
SKILL.md+6
@@ -39,6 +39,12 @@ When you run `browser_open_window`, one of these happens — handle each: | `errorCode: "chrome_install_no_disk"` | No Chrome/Edge and too little free disk to install Chrome for Testing (`readiness.diskFreeMb` shown). | Tell the user how much is free and that ~800 MB is needed; ask them to free space OR install Edge/Chrome (Edge needs ~nothing). Do NOT retry the download — it fails until disk is freed. | | `errorCode: "chrome_install_failed"` / `chrome_download_network` / `chrome_install_permission` | No Chrome/Edge AND the CfT fallback download failed (network/proxy, permission, or other). | Read `readiness.lastError`. Ask the user to install Chrome or Edge (Edge ships with Windows). | +**CfT reported as `skipped` is NOT a failure.** On AD ≥ 1.9.76 the Chrome-for-Testing prewarm is+CONDITIONAL (`prewarm_cft: auto`): boxes with a system Chrome/Edge skip the ~150 MB download, and+`bridge_readiness` reports the asset as `{present:false, skipped:true, reason}`. That's the intended+installed-browser-first behavior — pup drives the installed browser; do NOT retry, prewarm, or report+an error because of a `skipped` CfT row.+ **Want real Google Chrome on an Edge-only box?** If the user asks for Chrome specifically, run `browser_use '{"browser":"chrome","install":true}'` — pup downloads Google's official installer and installs Chrome **user-scoped (no admin prompt in most cases)**, then pins it. Poll `browser_readiness` (`installingChrome` / `chromeStablePhase`) until `browserKind:"chrome"`. If it stalls, a UAC prompt may be waiting on the user's desktop — ask them to accept it.  ### The Node step — AD provisions Node for you (AD ≥ 1.9.63); do NOTHING
package.json+1−1
@@ -1,6 +1,6 @@ {   "slug": "adom-desktop-puppeteer-bridge",-  "version": "1.8.7",+  "version": "1.8.8",   "type": "app",   "description": "CONTAINER-SIDE install \u2014 the pup skill pack in the wiki skillpack layout: the everyday `pup` user skill PLUS two bundled developer sub-skills (pup-bridge-dev, pup-bridge-publish; user-invocable:false, DEVELOPER-only descriptions so they never trigger for everyday users), all dropped into ~/.claude/skills/ AND ~/.codex/skills/ by an explicit install.sh list. It does NOT contain the bridge runtime: the bridge (Node + browser driving) lives on the DESKTOP \u2014 bundled inside Adom Desktop and published on the Releases tab as adom-bridge-puppeteer-v<ver>.zip, which Adom Desktop streams into its bridges-cache. TL;DR: pkg install = the skill pack; the bridge = the Release zip + bundled in Adom Desktop.",   "keywords": [
skills/pup-bridge-publish/SKILL.md+9
@@ -225,3 +225,12 @@ NEVER lands when the repo's committed `.gitignore` matches it (this repo ignores raised — the only tell is `commit:null` + a 404 on the file. Fix: add a `!hero-vN.png` unignore line, push `.gitignore` FIRST (real commit hash returned), then push the PNG, then verify anonymously: HTTP 200 AND `md5sum` matches the local file. Use a NEW versioned filename per hero (CDN staleness).++## Pushing an update LIVE on a desktop (AD >= 1.9.76)++`refresh_bridges '{"name":"puppeteer"}'` downloads the update AND auto-restarts a running bridge —+no manual kill, no bridge_install force needed for the update path. Then PROVE it went live:+`bridge_check_updates` must show `liveVersion == current` and `staleProcess:false` (liveVersion reads+the running process's /status version — keep BRIDGE_VERSION correct). If a process serves stale code,+`restart_bridge '{"name":"puppeteer"}'` kills (tracked PIDs + port orphans) and respawns from cache.+Drop any taskkill/manual-PID habits.