← Commit history

Dashboard SSE: report snapshot failures instead of swallowing them. The stream caught any error from dashboardSnapshot(), silently stopped, and left the page stuck on connecting forever with no way to see why. That is precisely the failure-suppression pattern the restructure plan documents (525 catch blocks, many hiding real errors), reproduced by me in brand-new code written the same day. The error is now logged bridge-side and streamed to the client, which renders it on the page, and headers are flushed so the stream opens immediately.

John Lauer ·e7f2211754 ·3mo ago ·parent 807a28e
4 files changed +23−8
adom-bridge-puppeteer-manifest.json+4−4
@@ -1,10 +1,10 @@ {   "manifest_version": 1,   "name": "puppeteer",-  "version": "1.9.228",-  "url": "https://wiki.adom.inc/download/adom/adom-desktop-puppeteer-bridge/1.9.228/adom-bridge-puppeteer-v1.9.228.zip",-  "sha256": "dc33d138ca41c97a05da25d314acf24427dff15124cbf2edd57ce2ac1177cb60",-  "size": 454581,+  "version": "1.9.229",+  "url": "https://wiki.adom.inc/download/adom/adom-desktop-puppeteer-bridge/1.9.229/adom-bridge-puppeteer-v1.9.229.zip",+  "sha256": "2dd79712e79ae344f34c19034bf4c66f3327fc52f527308971427af0abc27527",+  "size": 454929,   "verbPrefixes": [     "browser_",     "desktop_recorder_",
src/BRIDGE_VERSION+1−1
@@ -1 +1 @@-1.9.228+1.9.229
src/bridge.json+1−1
@@ -2,7 +2,7 @@   "manifest_version": 1,   "name": "puppeteer",   "displayName": "Puppeteer (Chrome for Testing + Native)",-  "version": "1.9.228",+  "version": "1.9.229",   "description": "Drives a browser ALREADY on the machine \u2014 installed Chrome, else Microsoft Edge (every Windows PC ships with Edge) \u2014 launched with a FRESH isolated profile, so the common case has NO ~150 MB Chrome-for-Testing download and it never touches the user's real tabs/logins. Binds its local server to LOOPBACK (127.0.0.1) only, so no Windows Firewall 'allow Node through the firewall' prompt ever pops. Chrome for Testing is fetched only as a LAST RESORT if the machine has no Chromium browser at all. SPAWN-VERIFIED fallback: pup tries each detected browser (Chrome \u2192 Edge \u2192 CfT) and actually launches it, falling through to the next if one won't start (and handling browsers like Edge that relaunch onto another PID), so a corrupt/partial install never hard-fails an open. The browser that launches is cached as the default (persisted across restarts) so it isn't re-probed each time. On spawn the bridge SELF-WARMS: detects browsers + disk, and only if the box has no Chrome/Edge and no cached CfT does it background-fetch CfT so the first open is instant. browser_use pins a specific browser (chrome | edge | cft | auto); {browser:'chrome',install:true} downloads & installs REAL Google Chrome (user-scoped, no admin) on an Edge-only box. browser_readiness (READ-ONLY) reports which browser will be used + the full candidate list + the default + free disk. Every failure returns a specific errorCode + _hint (chrome_install_no_disk, chrome_download_network, chrome_install_permission, chrome_stable_not_detected, \u2026). Launches with FULL browser permissions by default for full debug (strictPermissions:true opts out). Headful automation: open/close windows+tabs, navigate, screenshot, eval JS, record. pup is a GENERIC, non-profile browser only \u2014 every session is a fresh isolated Chrome/Edge process, never the user's real signed-in browser; profile defaults to sessionId. To drive the user's REAL Chrome/Edge (their profile, cookies, SSO), use the Adom browser EXTENSION's nbrowser_* verbs \u2014 a separate bridge, not pup's job. macOS (v1.9.74+): full parity with mac-native mechanics \u2014 background-by-default is the app-level hide (windows stay drivable/screenshottable while hidden), raise/lower map to unhide+activate/hide, browser_alert_window posts a native toast whose click focuses the window, browser_use {browser:'chrome',install:true} installs Chrome from the official dmg, and taskbar identity/badging remains Windows-only.",   "homepage": "https://wiki.adom.inc/adom/adom-desktop",   "author": "Adom Inc.",
src/server.js+17−2
@@ -8008,7 +8008,9 @@ document.addEventListener('click', ev => { }); $('#f').onchange=render; $('#q').oninput=render; const es=new EventSource('/dashboard/events');-es.onmessage=e=>{SNAP=JSON.parse(e.data);$('#live').classList.remove('stale');render();};+es.onmessage=e=>{const d=JSON.parse(e.data);+  if(d.error){$('#m').innerHTML='<div class="empty">snapshot error: '+esc(d.error)+'</div>';$('#live').classList.add('stale');return;}+  SNAP=d;$('#live').classList.remove('stale');render();}; es.onerror=()=>$('#live').classList.add('stale'); </script></body></html>`; @@ -8044,10 +8046,23 @@ const server = http.createServer(async (req, res) => {         'Content-Type': 'text/event-stream', 'Cache-Control': 'no-cache',         'Connection': 'keep-alive', 'Access-Control-Allow-Origin': '*',       });+      try { res.flushHeaders && res.flushHeaders(); } catch (e) {}       let alive = true;       const push = async () => {         if (!alive) return;-        try { res.write(`data: ${JSON.stringify(await dashboardSnapshot())}\n\n`); } catch (e) { alive = false; }+        // v1.9.229: REPORT the failure, do not swallow it. The previous version caught any error from+        // dashboardSnapshot() and silently set alive=false, so a single throw left the page stuck on+        // "connecting…" forever with no way to see why. That is exactly the failure-suppression+        // pattern the restructure plan calls out (525 catch blocks, many hiding real errors) and I+        // reproduced it in brand-new code. Now the error is streamed to the client and logged.+        let payload;+        try {+          payload = JSON.stringify(await dashboardSnapshot());+        } catch (e) {+          console.log(`[dashboard] snapshot FAILED: ${e && e.stack ? e.stack.split('\n')[0] : e}`);+          payload = JSON.stringify({ error: String((e && e.message) || e), ts: Date.now() });+        }+        try { res.write(`data: ${payload}\n\n`); } catch (e) { alive = false; }       };       await push();       const iv = setInterval(push, 2000);