← Commit history

Fix AUMID re-stamp churn: debounce the taskbar-identity stamp so a settling category (loading to web to wiki-signed-in) commits ONCE per open instead of recreating the taskbar button 2-3 times (John saw the AUMID applied 3x when opening a window). Idempotency gate unchanged, so stable windows stay a no-op.

John Lauer ·e7eb5c6a72 ·2mo ago ·parent 9629202
4 files changed +27−6
adom-bridge-puppeteer-manifest.json+4−4
@@ -1,10 +1,10 @@ {   "manifest_version": 1,   "name": "puppeteer",-  "version": "2.0.1",-  "url": "https://wiki.adom.inc/download/adom/pup-bridge/2.0.1/adom-bridge-puppeteer-v2.0.1.zip",-  "sha256": "e5c78dfc0f776b65a54f9420a7ea897a86be86bacf7b3f581afa989a7c90b8b7",-  "size": 637481,+  "version": "2.0.2",+  "url": "https://wiki.adom.inc/download/adom/pup-bridge/2.0.2/adom-bridge-puppeteer-v2.0.2.zip",+  "sha256": "3b6a9cb96999b11853e5aeb6c944f2d8815a51a2bb7b6b114260f295f46e579d",+  "size": 637982,   "verbPrefixes": [     "browser_",     "desktop_recorder_",
src/BRIDGE_VERSION+1−1
@@ -1 +1 @@-2.0.1+2.0.2
src/bridge.json+1−1
@@ -2,7 +2,7 @@   "manifest_version": 1,   "name": "puppeteer",   "displayName": "Puppeteer (Chrome for Testing + Native)",-  "version": "2.0.1",+  "version": "2.0.2",   "description": "Drives a browser ALREADY on the machine \u2014 installed Chrome, else Microsoft Edge (every Windows PC ships with Edge) \u2014 launched with a FRESH isolated profile, so the common case has NO ~150 MB Chrome-for-Testing download and it never touches the user's real tabs/logins. Binds its local server to LOOPBACK (127.0.0.1) only, so no Windows Firewall 'allow Node through the firewall' prompt ever pops. Chrome for Testing is fetched only as a LAST RESORT if the machine has no Chromium browser at all. SPAWN-VERIFIED fallback: pup tries each detected browser (Chrome \u2192 Edge \u2192 CfT) and actually launches it, falling through to the next if one won't start (and handling browsers like Edge that relaunch onto another PID), so a corrupt/partial install never hard-fails an open. The browser that launches is cached as the default (persisted across restarts) so it isn't re-probed each time. On spawn the bridge SELF-WARMS: detects browsers + disk, and only if the box has no Chrome/Edge and no cached CfT does it background-fetch CfT so the first open is instant. pup_use pins a specific browser (chrome | edge | cft | auto); {browser:'chrome',install:true} downloads & installs REAL Google Chrome (user-scoped, no admin) on an Edge-only box. pup_readiness (READ-ONLY) reports which browser will be used + the full candidate list + the default + free disk. Every failure returns a specific errorCode + _hint (chrome_install_no_disk, chrome_download_network, chrome_install_permission, chrome_stable_not_detected, \u2026). Launches with FULL browser permissions by default for full debug (strictPermissions:true opts out). Headful automation: open/close windows+tabs, navigate, screenshot, eval JS, record. pup is a GENERIC, non-profile browser only \u2014 every session is a fresh isolated Chrome/Edge process, never the user's real signed-in browser; profile defaults to sessionId. To drive the user's REAL Chrome/Edge (their profile, cookies, SSO), use the Adom browser EXTENSION's nbrowser_* verbs \u2014 a separate bridge, not pup's job. macOS (v1.9.74+): full parity with mac-native mechanics \u2014 background-by-default is the app-level hide (windows stay drivable/screenshottable while hidden), raise/lower map to unhide+activate/hide, pup_alert_window posts a native toast whose click focuses the window, pup_use {browser:'chrome',install:true} installs Chrome from the official dmg, and taskbar identity/badging remains Windows-only.",   "homepage": "https://wiki.adom.inc/adom/adom-desktop",   "author": "Adom Inc.",
src/server.js+21
@@ -3412,6 +3412,27 @@ async function stampPupIdentity(sessionId, opts) {     // changed is exactly the churn/flicker (and suspected crash pressure) we must never cause. Equal     // desired-vs-current appId => no-op. This is what lets reconcileModel run every sweep safely.     if (prevAppId === appId) return true;+    // v2.0.2 COALESCE THE CATEGORY-SETTLE CHURN (John: "why did i see the AUMID applied 3x when i+    // opened that window?"). A freshly-opened window's category refines as it loads and authenticates+    // (loading -> web -> wiki-signed-in), and every change re-stamps, which RECREATES the taskbar+    // button, so a single open flickered the button 2-3 times. Debounce the commit: record the+    // desired appId and stamp ONCE after a short quiet window; a further category change within the+    // window just updates the target and is picked up by the single scheduled commit, so the+    // intermediate tiles never get stamped. Same one-commit-per-real-change rule as the overlay paint.+    // The idempotency gate above already makes a stable window a no-op, so this only ever debounces a+    // genuine category CHANGE, never steady state. The commit re-enters with {_commit:true} to skip+    // the debounce and stamp the (by-then settled) category.+    const AUMID_SETTLE_MS = 1800;+    if (sess && !(opts && opts._commit)) {+      sess._desiredAppId = appId;+      if (!sess._aumidCommitTimer) {+        sess._aumidCommitTimer = setTimeout(() => {+          sess._aumidCommitTimer = null;+          if (sessions.has(sessionId)) stampPupIdentity(sessionId, { _commit: true }).catch(() => {});+        }, AUMID_SETTLE_MS);+      }+      return true; // deferred; the scheduled commit stamps the settled category exactly once+    }     // Register the NEW appId BEFORE stamping (AD's verified order) so the fresh button resolves     // its icon/name from the registry the moment it is created.     if (true) {