Pup - the AI's own browser

@@ -5082,7 +5082,7 @@ async function badgePupTaskbar(sessionId) { // foreground window after, so callers (and tests) know for CERTAIN whether it worked. // cdpPort (the browser's CDP debug port) resolves the real browser via its LISTENING // process — reliable across the launcher→browser pid relaunch that Edge/Chrome do.-function osBackgroundWindowByPid(pid, cdpPort, restoreHwnd, respectUser) {+function osBackgroundWindowByPid(pid, cdpPort, restoreHwnd, respectUser, targetHwnd) {   if (process.platform !== 'win32' || (!pid && !cdpPort)) return 'error';   try {     const port = Number(cdpPort) || 0;@@ -5147,7 +5147,12 @@ function osBackgroundWindowByPid(pid, cdpPort, restoreHwnd, respectUser) {       '$anchors = @($pidList.ToArray())',       'foreach ($tp in $anchors) { Get-CimInstance Win32_Process -Filter "ParentProcessId=$tp" -ErrorAction SilentlyContinue | Where-Object { $_.Name -in @("chrome.exe","msedge.exe") } | ForEach-Object { [void]$pidList.Add([int]$_.ProcessId) } }',       // Resolve the ONE real browser window (largest visible Chrome_WidgetWin_1), not a helper.-      '$pup = [WinBgP]::BestWindow([int[]]@($pidList.ToArray()))',+      // v1.9.253 (the adom-theme disruption): BestWindow = "largest visible window of the process"+      // picked the WRONG window whenever the shared profile had several - the background call then+      // claimed success while the actual new window kept its creation focus. When the caller knows+      // the session's own hwnd, use it; BestWindow only as the no-hwnd fallback.+      `$explicit = [IntPtr]${Number(targetHwnd) || 0}`,+      '$pup = if ($explicit -ne [IntPtr]::Zero) { $explicit } else { [WinBgP]::BestWindow([int[]]@($pidList.ToArray())) }',       'if ($pup -eq [IntPtr]::Zero) { Write-Output "no-window"; exit }',       // respectUser (v1.8.49): used ONLY by LATE re-parks (post-resize etc.), never the launch       // passes. Rationale: after startup, Chrome does NOT self-raise — so if the pup window is@@ -6676,6 +6681,40 @@ async function getOrLaunchBrowser(profileName, { freshProfile = false, strictPer // always makes a tab; only CDP Target.createTarget accepts newWindow. Page identity is resolved by // diffing browser.pages() before/after rather than matching internal target ids, so this stays // correct across puppeteer versions. Returns null if the window never materialises.+function osRestoreForeground(hwnd) {+  // Give the USER's window its focus back (SetForegroundWindow needs the AttachThreadInput trick+  // when called from a background process). Only ever called with the user's prior-foreground hwnd.+  if (process.platform !== 'win32' || !hwnd) return false;+  try {+    const scriptPath = path.join(require('os').tmpdir(), `_adom_restorefg_${process.pid}.ps1`);+    const ps = [+      'Add-Type @"',+      'using System; using System.Runtime.InteropServices;',+      'public class WinRf {',+      '  [DllImport("user32.dll")] public static extern IntPtr GetForegroundWindow();',+      '  [DllImport("user32.dll")] public static extern uint GetWindowThreadProcessId(IntPtr h, out uint pid);',+      '  [DllImport("user32.dll")] public static extern bool AttachThreadInput(uint a, uint b, bool f);',+      '  [DllImport("user32.dll")] public static extern bool SetForegroundWindow(IntPtr h);',+      '  [DllImport("user32.dll")] public static extern bool BringWindowToTop(IntPtr h);',+      '  [DllImport("kernel32.dll")] public static extern uint GetCurrentThreadId();',+      '}',+      '"@',+      `$t = [IntPtr]${Number(hwnd)}`,+      '$fg = [WinRf]::GetForegroundWindow()',+      'if ($fg -eq $t) { Write-Output "already"; exit }',+      '$p1 = 0; $tid1 = [WinRf]::GetWindowThreadProcessId($fg, [ref]$p1)',+      '$me = [WinRf]::GetCurrentThreadId()',+      '[void][WinRf]::AttachThreadInput($me, $tid1, $true)',+      '[void][WinRf]::SetForegroundWindow($t)',+      '[void][WinRf]::BringWindowToTop($t)',+      '[void][WinRf]::AttachThreadInput($me, $tid1, $false)',+      'Write-Output "restored"',+    ].join(String.fromCharCode(13, 10));+    fs.writeFileSync(scriptPath, ps);+    const out = runPsHidden(scriptPath, { timeout: 5000 }).trim();+    return out === 'restored' || out === 'already';+  } catch (e) { return false; }+} async function createPageInNewWindow(browser) {   let cdp = null;   try {@@ -6687,13 +6726,29 @@ async function createPageInNewWindow(browser) {     // these are explicit PER-WINDOW coords on this one creation, and the unconditional park     // (1.9.138) immediately rewrites the normal rect on-screen at bottom-z, so nothing can stay     // stranded. Windows whose park somehow fails are caught by healOffscreenWindow.+    // v1.9.253 (John: "i don't believe you that chrome is auto-foregrounding the windows" — he was+    // right to push: MEASURE it). Capture the user's foreground before creating the window; check it+    // after. If creation stole focus, hand it straight back while the new window is still OFF-SCREEN+    // (invisible), so the user's typing is interrupted for at most ~1s and NOTHING ever appears on+    // their screen. This is the at-the-source fix; parks and re-asserts then act on an unfocused+    // window (osBottomUnlessForeground no longer mistakes the creation-grab for user intent).+    const prevFg = osGetForegroundWindow();     await cdp.send('Target.createTarget', { url: 'about:blank', newWindow: true, left: -32000, top: -32000, width: 1280, height: 800 });-    for (let i = 0; i < 50; i++) {-      const fresh = (await browser.pages()).find(p => !before.has(p));-      if (fresh) return fresh;-      await new Promise(r => setTimeout(r, 100));+    let fresh = null;+    for (let i = 0; i < 50 && !fresh; i++) {+      fresh = (await browser.pages()).find(p => !before.has(p));+      if (!fresh) await new Promise(r => setTimeout(r, 100));     }-    return null;+    try {+      const nowFg = osGetForegroundWindow();+      if (prevFg && nowFg && String(nowFg) !== String(prevFg)) {+        const restored = osRestoreForeground(prevFg);+        console.log(`[focus] MEASURED: createTarget(newWindow) STOLE the OS foreground (fg ${prevFg} -> ${nowFg}); restored to the user: ${restored}`);+      } else {+        console.log(`[focus] MEASURED: createTarget(newWindow) did NOT move the OS foreground (fg=${prevFg || '?'})`);+      }+    } catch (e) {}+    return fresh;   } catch (e) {     console.log(`[window] createPageInNewWindow failed: ${e.message}`);     return null;@@ -10149,7 +10204,8 @@ const server = http.createServer(async (req, res) => {             // keeps rendering hidden windows). Per-process, so shared-profile siblings hide too.             ok = await macSetAppHiddenByPid(macSessionPid(session), true);           } else {-            ok = (be && be.browser) ? (osBackgroundWindowByPid(be.browser._detachedPid, be.browser._cdpPort, be.browser._priorForeground) === 'backgrounded') : osSendWindowToBack(session.profileName);+            if (!session._hwnd) { try { await resolveSessionHwndByBounds(session, sessionId); } catch (e) {} }+            ok = (be && be.browser) ? (osBackgroundWindowByPid(be.browser._detachedPid, be.browser._cdpPort, be.browser._priorForeground, false, session._hwnd) === 'backgrounded') : osSendWindowToBack(session.profileName);           }           session._foreground = false;           sendJSON(res, { success: true, output: JSON.stringify({ ok: true, sessionId, placement: 'background', applied: ok, _hint: 'Window sent behind the user\'s windows (still drivable/screenshottable). Keep pup in the background unless the user asked to watch.' }) });