← Commit history

v2.0.357: Tag the OS window on adoption and re-tag on recovery (issue #79 root cause): a window pup adopted never went through birth so it carried no identity property and was permanently unresolvable, which is what made a new thread's taskbar tile land on the adopted window's button.

John Lauer ·d456c2a224 ·2mo ago ·parent 1668777
5 files changed +35−8
adom-bridge-puppeteer-manifest.json+5−5
@@ -1,10 +1,10 @@ {   "manifest_version": 1,   "name": "puppeteer",-  "version": "2.0.356",-  "url": "https://wiki.adom.inc/download/adom/pup-bridge/2.0.356/adom-bridge-puppeteer-v2.0.356.zip",-  "sha256": "2b7719b8f1699c6e77ab3ee7ee49b54278566336834aaffaa750cdb62205d77b",-  "size": 1526500,+  "version": "2.0.357",+  "url": "https://wiki.adom.inc/download/adom/pup-bridge/2.0.357/adom-bridge-puppeteer-v2.0.357.zip",+  "sha256": "fb9027032086fcf4b2d2a22f94b589017db7e68c0255de0533e717cb5488b390",+  "size": 1527232,   "verbPrefixes": [     "browser_",     "desktop_recorder_",@@ -12,5 +12,5 @@   ],   "healthEndpoint": "/status",   "statusVerb": "browser_readiness",-  "released_at": "2026-08-27T13:32:09.884106Z"+  "released_at": "2026-08-27T13:59:29.821308Z" }
package.json+1−1
@@ -1,6 +1,6 @@ {   "slug": "pup-bridge",-  "version": "2.0.356",+  "version": "2.0.357",   "type": "app",   "description": "The pup SKILL PACK \u2014 the AI skills that teach a cloud/container AI how to drive the Adom Desktop Puppeteer (pup) bridge (browser_* verbs): the everyday `pup` skill plus focused sub-skills for windows/sessions/tabs, screenshots+recording, browsers+Chrome install, and driving the Adom wiki. Installs into ~/.claude/skills + ~/.codex/skills. DOCS ONLY \u2014 this is NOT the bridge runtime. The bridge itself (the Node program that drives the browser) runs on the DESKTOP: Adom Desktop bundles it and auto-installs/updates it, and it's published separately on the Releases tab as adom-bridge-puppeteer-v<ver>.zip. The pkg version is kept in lockstep with the Release version so the page's max version row always carries BOTH a pkg tarball (skills) and a runtime zip (bridge) \u2014 a skills-only or runtime-only bump on the top row breaks constraint installs. TL;DR: pkg install = the skills for your AI; the bridge = the Release zip, which Adom Desktop manages for you.",   "keywords": [
src/BRIDGE_VERSION+1−1
@@ -1 +1 @@-2.0.356\ No newline at end of file+2.0.357\ No newline at end of file
src/bridge.json+1−1
@@ -2,7 +2,7 @@   "manifest_version": 1,   "name": "puppeteer",   "displayName": "Puppeteer (Chrome for Testing + Native)",-  "version": "2.0.356",+  "version": "2.0.357",   "description": "Drives a browser ALREADY on the machine \u2014 installed Chrome, else Microsoft Edge (every Windows PC ships with Edge) \u2014 launched with a FRESH isolated profile, so the common case has NO ~150 MB Chrome-for-Testing download and it never touches the user's real tabs/logins. Binds its local server to LOOPBACK (127.0.0.1) only, so no Windows Firewall 'allow Node through the firewall' prompt ever pops. Chrome for Testing is fetched only as a LAST RESORT if the machine has no Chromium browser at all. SPAWN-VERIFIED fallback: pup tries each detected browser (Chrome \u2192 Edge \u2192 CfT) and actually launches it, falling through to the next if one won't start (and handling browsers like Edge that relaunch onto another PID), so a corrupt/partial install never hard-fails an open. The browser that launches is cached as the default (persisted across restarts) so it isn't re-probed each time. On spawn the bridge SELF-WARMS: detects browsers + disk, and only if the box has no Chrome/Edge and no cached CfT does it background-fetch CfT so the first open is instant. pup_use pins a specific browser (chrome | edge | cft | auto); {browser:'chrome',install:true} downloads & installs REAL Google Chrome (user-scoped, no admin) on an Edge-only box. pup_readiness (READ-ONLY) reports which browser will be used + the full candidate list + the default + free disk. Every failure returns a specific errorCode + _hint (chrome_install_no_disk, chrome_download_network, chrome_install_permission, chrome_stable_not_detected, \u2026). Launches with FULL browser permissions by default for full debug (strictPermissions:true opts out). Headful automation: open/close windows+tabs, navigate, screenshot, eval JS, record. pup is a GENERIC, non-profile browser only \u2014 every session is a fresh isolated Chrome/Edge process, never the user's real signed-in browser; profile defaults to sessionId. To drive the user's REAL Chrome/Edge (their profile, cookies, SSO), use the Adom browser EXTENSION's nbrowser_* verbs \u2014 a separate bridge, not pup's job. macOS (v1.9.74+): full parity with mac-native mechanics \u2014 background-by-default is the app-level hide (windows stay drivable/screenshottable while hidden), raise/lower map to unhide+activate/hide, pup_alert_window posts a native toast whose click focuses the window, pup_use {browser:'chrome',install:true} installs Chrome from the official dmg, and taskbar identity/badging remains Windows-only.",   "homepage": "https://wiki.adom.inc/adom/adom-bridge",   "author": "Adom Inc.",
src/server.js+27
@@ -2459,6 +2459,12 @@ async function recoverSessions() {         // the pid; hwndBelongsToPup accepts that pair as proof (and learns the pid for siblings).         if (pid) session._recoveredHwndPid = Number(pid) || null;         console.log(`[recovery] "${sessionId}" restored persisted hwnd ${sf._hwnd} (continuity proof pid ${pid || 'none'})`);+        // v2.0.357: RE-TAG on recovery. The identity property lives in Chrome's process, so it+        // normally survives a pup respawn, but it does NOT survive the case that actually matters:+        // a window that was adopted before 2.0.357 (never tagged) or one whose Chrome restarted.+        // Re-writing it here is idempotent and costs one in-process SetProp, and it means a machine+        // carrying untagged windows heals on its next restart rather than staying unresolvable.+        tagWindowSession(Number(sf._hwnd), sessionId).catch(() => {});       }       // v1.9.202 (John's icon audit): a recovered window came back with NO taskbar badge. Under       // minimalTouch the overlay is applied only on OPEN and NAVIGATE, and the re-stamp sweeps that@@ -9099,6 +9105,27 @@ async function reclaimUnmanagedWindows() {         let u = null; try { u = group[0].url(); } catch (e) {}         // Title FIRST — every downstream brand step resolves the window by its "(session: <id>)".         try { await retagSessionTitle(group[0], newId, profileName); } catch (e) {}+        // v2.0.357 (issue #79, the half that outlives the sentinel): TAG THE OS WINDOW.+        // pup writes its identity property at BIRTH, and re-writes it on every successful resolve.+        // An ADOPTED window was never born under pup, so it carried no tag and nothing here added+        // one, which made it permanently unresolvable: "[hwnd] NOT resolved — N windows on this+        // profile, no property tag". That is not cosmetic. hwnd resolution is what decides which+        // OS window a taskbar tile gets stamped onto, so an untagged window makes the NEXT window's+        // tile land on the wrong button. John saw a brand-new thread's window appear under the+        // adopted window's button and asked why his window was being put inside it. This is why.+        // The title we just wrote is unique at this instant, so it is the one moment the hwnd can+        // be recovered without guessing, and the tag then survives every later handle loss.+        try {+          const _mark = `${TITLE_LABEL}: ${newId}`;+          const _hit = win32.findChromeWindowByTitle(_mark);+          if (_hit && _hit.hwnd) {+            ns._hwnd = Number(_hit.hwnd);+            await tagWindowSession(_hit.hwnd, newId);+            console.log(`[reclaim] "${newId}": tagged OS window ${_hit.hwnd} so it stays resolvable (was untagged: adopted windows never went through birth)`);+          } else {+            console.log(`[reclaim] "${newId}": could not find its OS window by title — it will stay untagged and unresolvable until a later resolve succeeds`);+          }+        } catch (e) { console.log(`[reclaim] "${newId}": tagging failed: ${e.message}`); }         console.log(`[reclaim] UNMANAGED window on "${profileName}" (${group.length} tab(s)) adopted as "${newId}" — ${(u || '').slice(0, 60)}`);         refreshWindowChrome(ns, newId).catch(() => {});         // v1.9.202: an ADOPTED window also needs its badge — refreshWindowChrome is gated off under