← Commit history

Hwnd resolution goes TITLE-FIRST (the 3-untracked mystery solved): the dashboard flagged three untracked pup windows that turned out to BE the real session windows - after a restart, every parked window shares the IDENTICAL rect (work-area minus 10px insets), so the geometry-only resolver cannot distinguish them and misassigns hwnds, leaving the real windows unclaimed and the sessions pointing elsewhere. The title tag is exact where it exists: resolveSessionHwndByBounds now resolves via desktop_find_window on the '(session: <id>' suffix first, and falls back to geometry only for windows that cannot carry the tag (the PDF viewer case bounds-matching was built for). Also logged for a future fix: hero-studio's title carries a DOUBLED session tag ('(session: hero-studio) (session: hero-studio)') - the title injector can append twice.

John Lauer ·d174b1a184 ·2mo ago ·parent 512f3f6
4 files changed +16−6
adom-bridge-puppeteer-manifest.json+4−4
@@ -1,10 +1,10 @@ {   "manifest_version": 1,   "name": "puppeteer",-  "version": "1.9.273",-  "url": "https://wiki.adom.inc/download/adom/adom-desktop-puppeteer-bridge/1.9.273/adom-bridge-puppeteer-v1.9.273.zip",-  "sha256": "9af581706065f8266d1c898c72473591d81e7ee2acac1ca238b555f8e2fba7ef",-  "size": 615738,+  "version": "1.9.274",+  "url": "https://wiki.adom.inc/download/adom/adom-desktop-puppeteer-bridge/1.9.274/adom-bridge-puppeteer-v1.9.274.zip",+  "sha256": "ad9effed93b59f8f88e4841d5b2b1db0f7126fd302ee5fb48b532a41bd30fb82",+  "size": 615945,   "verbPrefixes": [     "browser_",     "desktop_recorder_",
src/BRIDGE_VERSION+1−1
@@ -1 +1 @@-1.9.273+1.9.274
src/bridge.json+1−1
@@ -2,7 +2,7 @@   "manifest_version": 1,   "name": "puppeteer",   "displayName": "Puppeteer (Chrome for Testing + Native)",-  "version": "1.9.273",+  "version": "1.9.274",   "description": "Drives a browser ALREADY on the machine \u2014 installed Chrome, else Microsoft Edge (every Windows PC ships with Edge) \u2014 launched with a FRESH isolated profile, so the common case has NO ~150 MB Chrome-for-Testing download and it never touches the user's real tabs/logins. Binds its local server to LOOPBACK (127.0.0.1) only, so no Windows Firewall 'allow Node through the firewall' prompt ever pops. Chrome for Testing is fetched only as a LAST RESORT if the machine has no Chromium browser at all. SPAWN-VERIFIED fallback: pup tries each detected browser (Chrome \u2192 Edge \u2192 CfT) and actually launches it, falling through to the next if one won't start (and handling browsers like Edge that relaunch onto another PID), so a corrupt/partial install never hard-fails an open. The browser that launches is cached as the default (persisted across restarts) so it isn't re-probed each time. On spawn the bridge SELF-WARMS: detects browsers + disk, and only if the box has no Chrome/Edge and no cached CfT does it background-fetch CfT so the first open is instant. browser_use pins a specific browser (chrome | edge | cft | auto); {browser:'chrome',install:true} downloads & installs REAL Google Chrome (user-scoped, no admin) on an Edge-only box. browser_readiness (READ-ONLY) reports which browser will be used + the full candidate list + the default + free disk. Every failure returns a specific errorCode + _hint (chrome_install_no_disk, chrome_download_network, chrome_install_permission, chrome_stable_not_detected, \u2026). Launches with FULL browser permissions by default for full debug (strictPermissions:true opts out). Headful automation: open/close windows+tabs, navigate, screenshot, eval JS, record. pup is a GENERIC, non-profile browser only \u2014 every session is a fresh isolated Chrome/Edge process, never the user's real signed-in browser; profile defaults to sessionId. To drive the user's REAL Chrome/Edge (their profile, cookies, SSO), use the Adom browser EXTENSION's nbrowser_* verbs \u2014 a separate bridge, not pup's job. macOS (v1.9.74+): full parity with mac-native mechanics \u2014 background-by-default is the app-level hide (windows stay drivable/screenshottable while hidden), raise/lower map to unhide+activate/hide, browser_alert_window posts a native toast whose click focuses the window, browser_use {browser:'chrome',install:true} installs Chrome from the official dmg, and taskbar identity/badging remains Windows-only.",   "homepage": "https://wiki.adom.inc/adom/adom-desktop",   "author": "Adom Inc.",
src/server.js+10
@@ -4651,6 +4651,16 @@ async function resolveSessionHwndByBounds(session, sessionId) {   if (process.platform !== 'win32' || !session) return null;   try {     if (session._hwnd) return Number(session._hwnd);+    // v1.9.274 (John's dashboard showed 3 'untracked' windows that WERE the real session windows):+    // every parked window shares the IDENTICAL rect (work-area minus insets), so pure geometry+    // matching cannot distinguish windows after a restart and misassigns hwnds. The title tag is+    // exact where it exists - resolve by title FIRST; geometry stays as the fallback for windows+    // that cannot carry the tag (PDF viewer).+    try {+      const fw = adPayload(await chrome.adCommand('desktop_find_window', { titleContains: `(session: ${sessionId}` }, { timeoutMs: 5000, caller: sessionCaller(session) }));+      const b = fw && (fw.best || (fw.data && fw.data.best));+      if (b && b.hwnd) { session._hwnd = Number(b.hwnd); console.log(`[hwnd] "${sessionId}" resolved by TITLE tag -> ${b.hwnd}`); return Number(b.hwnd); }+    } catch (e) {}     const page = (session.tabs || [])[0] && (session.tabs || [])[0].page;     if (!page) return null;     let bounds = null, cdp = null;