Pup - the AI's own browser

@@ -887,6 +887,7 @@ async function rescanProfile(browser, profileName, { adoptOrphans = false } = {}     let session = sessions.get(sessionId);     if (!session) {       session = createSession(profileName);+      session._sessionId = sessionId; // v1.8.43: for AD taskbar/flash titleContains resolution       sessions.set(sessionId, session);     } else if (session.profileName !== profileName) {       // SessionId collision across profiles — shouldn't happen in practice@@ -1084,6 +1085,7 @@ async function recoverSessions() {        const session = createSession(profileName);       attachTab(session, sessionId, page);+      session._sessionId = sessionId; // v1.8.43: for AD taskbar/flash titleContains resolution       sessions.set(sessionId, session);       const be = browsers.get(profileName);       if (be) be.refCount++;@@ -1645,38 +1647,20 @@ function osBackgroundWindowByPid(pid, cdpPort, restoreHwnd) { // v1.8.24: a FINITE 4-blink pulse then stop (see Flash() below) — NOT a blink-forever // nag. Skips if the window is already foreground. Fire-and-forget (async exec) so it // never adds latency to the driving verb.-function osFlashWindow(profileName, opts) {-  if (process.platform !== 'win32') return;+// v1.8.43: pup's taskbar flash routes through AD-CORE desktop_flash_window (native ++// reliable, ONE mechanism for flash AND clear) instead of pup's own FlashWindowEx — which+// duplicated an AD capability, and whose fire-and-forget FLASHW_STOP wouldn't actually+// clear the Win11 attention tint. Resolves the window by its "(session: <id>)" title suffix.+// {stop:true} clears it; otherwise a finite 4-count flash. Returns AD's real result so+// callers can report truthfully (no more cleared:true lies).+async function flashViaAD(sessionId, opts) {   opts = opts || {};-  const stop = !!opts.stop; // v1.8.35: {stop:true} clears the taskbar highlight (FLASHW_STOP)-  const be = browsers.get(profileName);-  const pid = (be && be.browser && (be.browser._detachedPid || (be.browser.process() && be.browser.process().pid))) || null;-  if (!pid) return;-  try {-    const psScript = path.join(require('os').tmpdir(), `_adom_flash_${pid}.ps1`);-    const ps = [-      'Add-Type @"',-      'using System; using System.Runtime.InteropServices;',-      'public class WinFlash {',-      '  [StructLayout(LayoutKind.Sequential)] public struct FLASHWINFO { public uint cbSize; public IntPtr hwnd; public uint dwFlags; public uint uCount; public uint dwTimeout; }',-      '  [DllImport("user32.dll")] public static extern bool FlashWindowEx(ref FLASHWINFO pwfi);',-      '  [DllImport("user32.dll")] public static extern IntPtr GetForegroundWindow();',-      // v1.8.24: FINITE pulse — FLASHW_TRAY (taskbar button), 4 blinks, then stop (NOT-      // FLASHW_TIMERNOFG, which blinks forever = a nag). v1.8.35: stop=true → FLASHW_STOP-      // (dwFlags 0, count 0) to CLEAR a lingering highlight on demand.-      '  public static void Flash(IntPtr h, bool stop){ if(h==IntPtr.Zero) return; if(!stop && GetForegroundWindow()==h) return;',-      '    FLASHWINFO fi=new FLASHWINFO(); fi.cbSize=(uint)Marshal.SizeOf(fi); fi.hwnd=h; fi.dwFlags=(stop?(uint)0:(uint)0x2); fi.uCount=(stop?(uint)0:(uint)4); fi.dwTimeout=0; FlashWindowEx(ref fi); }',-      '}',-      '"@',-      `$targetPid = ${pid}`,-      `$doStop = ${stop ? '$true' : '$false'}`,-      '$p = Get-Process -Id $targetPid -ErrorAction SilentlyContinue',-      'if ($p -and $p.MainWindowHandle -ne 0) { [WinFlash]::Flash($p.MainWindowHandle, $doStop) }',-      'else { Get-CimInstance Win32_Process -Filter "ParentProcessId=$targetPid" -ErrorAction SilentlyContinue | Where-Object { $_.Name -in @("chrome.exe","msedge.exe") } | ForEach-Object { $cp = Get-Process -Id $_.ProcessId -ErrorAction SilentlyContinue; if ($cp -and $cp.MainWindowHandle -ne 0) { [WinFlash]::Flash($cp.MainWindowHandle, $doStop) } } }',-    ].join('\r\n');-    fs.writeFileSync(psScript, ps);-    runPsHiddenAsync(psScript);-  } catch (e) {}+  if (process.platform !== 'win32' || !sessionId) return null;+  const args = opts.stop+    ? { titleContains: `(session: ${sessionId}`, stop: true }+    : { titleContains: `(session: ${sessionId}`, mode: 'count', count: 4 };+  try { return await chrome.adCommand('desktop_flash_window', args, { timeoutMs: 6000 }); }+  catch (e) { return null; } }  // v1.8.23: verbs that MUTATE a session's visible state → auto-flash the window so the@@ -1685,16 +1669,16 @@ const MUTATING_VERBS = new Set(['browser_open_window', 'browser_open_tab', 'brow  // Debounced auto-flash: one flash per window per ~5s burst of verbs, re-armed after // quiet. {silent:true} on the verb OR session._flashSilent (session default) suppresses.-const _flashState = new Map(); // profileName -> last flash ts+const _flashState = new Map(); // sessionId -> last flash ts function scheduleAutoFlash(session, opts) {   opts = opts || {};-  if (process.platform !== 'win32' || !session) return;+  if (process.platform !== 'win32' || !session || !session._sessionId) return;   if (opts.silent || session._flashSilent) return;-  const key = session.profileName;+  const key = session._sessionId;   const now = Date.now();   if (now - (_flashState.get(key) || 0) < 5000) return; // coalesce the burst   _flashState.set(key, now);-  osFlashWindow(key);+  flashViaAD(session._sessionId, {}); // fire-and-forget (async → AD desktop_flash_window) }  // Record what the agent just did to a session, for lastAgentUpdate (browser_list_tabs /@@ -2270,7 +2254,7 @@ async function launchSession(sessionId, url, { freshProfile = false, profile, st   // real URL's domcontentloaded, which for heavy sites is another 1–3s. Set _flashState so   // the open handler's later scheduleAutoFlash debounces (no double flash). Fire-and-forget.   if (!foreground && !silent && process.platform === 'win32') {-    try { _flashState.set(profileName, Date.now()); osFlashWindow(profileName); } catch (e) {}+    try { _flashState.set(sessionId, Date.now()); flashViaAD(sessionId, {}); } catch (e) {}   }    if (url) {@@ -2328,6 +2312,7 @@ async function launchSession(sessionId, url, { freshProfile = false, profile, st   // resolves in attachTab itself if unset.   if (downloadPath) session._downloadPath = downloadPath;   attachTab(session, sessionId, page);+  session._sessionId = sessionId; // v1.8.43: for AD taskbar/flash titleContains resolution   sessions.set(sessionId, session);   activeSessionId = sessionId; @@ -3415,9 +3400,13 @@ const server = http.createServer(async (req, res) => {           const session = sessions.get(sessionId);           try {             const stop = !!(args.stop || args.clear);-            osFlashWindow(session.profileName, { stop });-            console.log(`${stop ? 'Cleared' : 'Flashed'} taskbar for session "${sessionId}"`);-            sendJSON(res, { success: true, output: JSON.stringify({ ok: true, sessionId, alerted: !stop, cleared: stop, _hint: stop ? 'Cleared the taskbar highlight for this window (FLASHW_STOP).' : 'Flashed the taskbar (finite ~4-pulse) without stealing focus. Pass {stop:true} to clear it.' }) });+            // v1.8.43: route through AD's desktop_flash_window (reliable, native). AWAIT the+            // real result — no more fire-and-forget cleared:true lies.+            const r = await flashViaAD(session._sessionId || sessionId, { stop });+            let applied = false;+            try { const o = r && (typeof r.output === 'string' ? JSON.parse(r.output) : r.output || r); applied = !!(o && (o.ok || o.count)); } catch (e) {}+            console.log(`${stop ? 'Cleared' : 'Flashed'} taskbar for session "${sessionId}" (AD applied=${applied})`);+            sendJSON(res, { success: true, output: JSON.stringify({ ok: true, sessionId, alerted: !stop, cleared: stop, applied, _hint: applied ? (stop ? 'Cleared the taskbar flash for this window via AD desktop_flash_window.' : 'Flashed the taskbar (finite 4-count) via AD, no focus steal. Pass {stop:true} to clear.') : 'AD desktop_flash_window did not match the window (title changed? window closed?) — nothing applied.' }) });           } catch (e) {             sendJSON(res, { success: false, error: `Alert failed: ${e.message}` });           }