← Commit history

Stops pup from triggering a Windows Firewall/UAC prompt (John hit it when his payroll thread opened a Gusto window). Root cause: Chromes Cast/MediaRouter feature binds an mDNS listener on 0.0.0.0:5353, a network-exposed socket that makes Windows Firewall prompt, and it re-prompts on every new Chrome for Testing exe path (a version bump). pup is an automation browser that never casts, so it now disables MediaRouter, the DIAL and Cast route providers, and passes media-router=0; Chrome then binds only loopback and no firewall prompt is shown. disable-background-networking did not cover this because MediaRouters mDNS is a separate binding

John Lauer ·b8921f48f5 ·2mo ago ·parent 3db17d0
4 files changed +15−7
adom-bridge-puppeteer-manifest.json+4−4
@@ -1,10 +1,10 @@ {   "manifest_version": 1,   "name": "puppeteer",-  "version": "2.0.119",-  "url": "https://wiki.adom.inc/download/adom/pup-bridge/2.0.119/adom-bridge-puppeteer-v2.0.119.zip",-  "sha256": "90ce4fc171166d3cba50baebc7f0216a6bdb48974bf5300f1291525e199703e3",-  "size": 864234,+  "version": "2.0.120",+  "url": "https://wiki.adom.inc/download/adom/pup-bridge/2.0.120/adom-bridge-puppeteer-v2.0.120.zip",+  "sha256": "fe71322c65e3050a3c2532d487237d2f51f0da7c5d0568918416cdc4c78e36dd",+  "size": 864550,   "verbPrefixes": [     "browser_",     "desktop_recorder_",
src/BRIDGE_VERSION+1−1
@@ -1 +1 @@-2.0.119+2.0.120
src/bridge.json+1−1
@@ -2,7 +2,7 @@   "manifest_version": 1,   "name": "puppeteer",   "displayName": "Puppeteer (Chrome for Testing + Native)",-  "version": "2.0.119",+  "version": "2.0.120",   "description": "Drives a browser ALREADY on the machine \u2014 installed Chrome, else Microsoft Edge (every Windows PC ships with Edge) \u2014 launched with a FRESH isolated profile, so the common case has NO ~150 MB Chrome-for-Testing download and it never touches the user's real tabs/logins. Binds its local server to LOOPBACK (127.0.0.1) only, so no Windows Firewall 'allow Node through the firewall' prompt ever pops. Chrome for Testing is fetched only as a LAST RESORT if the machine has no Chromium browser at all. SPAWN-VERIFIED fallback: pup tries each detected browser (Chrome \u2192 Edge \u2192 CfT) and actually launches it, falling through to the next if one won't start (and handling browsers like Edge that relaunch onto another PID), so a corrupt/partial install never hard-fails an open. The browser that launches is cached as the default (persisted across restarts) so it isn't re-probed each time. On spawn the bridge SELF-WARMS: detects browsers + disk, and only if the box has no Chrome/Edge and no cached CfT does it background-fetch CfT so the first open is instant. pup_use pins a specific browser (chrome | edge | cft | auto); {browser:'chrome',install:true} downloads & installs REAL Google Chrome (user-scoped, no admin) on an Edge-only box. pup_readiness (READ-ONLY) reports which browser will be used + the full candidate list + the default + free disk. Every failure returns a specific errorCode + _hint (chrome_install_no_disk, chrome_download_network, chrome_install_permission, chrome_stable_not_detected, \u2026). Launches with FULL browser permissions by default for full debug (strictPermissions:true opts out). Headful automation: open/close windows+tabs, navigate, screenshot, eval JS, record. pup is a GENERIC, non-profile browser only \u2014 every session is a fresh isolated Chrome/Edge process, never the user's real signed-in browser; profile defaults to sessionId. To drive the user's REAL Chrome/Edge (their profile, cookies, SSO), use the Adom browser EXTENSION's nbrowser_* verbs \u2014 a separate bridge, not pup's job. macOS (v1.9.74+): full parity with mac-native mechanics \u2014 background-by-default is the app-level hide (windows stay drivable/screenshottable while hidden), raise/lower map to unhide+activate/hide, pup_alert_window posts a native toast whose click focuses the window, pup_use {browser:'chrome',install:true} installs Chrome from the official dmg, and taskbar identity/badging remains Windows-only.",   "homepage": "https://wiki.adom.inc/adom/adom-bridge",   "author": "Adom Inc.",
src/server.js+9−1
@@ -8097,7 +8097,15 @@ async function getOrLaunchBrowser(profileName, { freshProfile = false, strictPer       // --disable-field-trial-config turns off the experiment config that gates promos like it,       // which is also the determinism WHY-CFT promises (same browser on every machine).       '--disable-field-trial-config',-      '--disable-features=WinLaunchOnLogon,LaunchChromeOnWindowsLogon,StartupBoost,BeginBrowsingInstantly,DesktopStartupPromo,IPH_LaunchOnStartup',+      // v2.0.120 (John got a Windows Firewall/UAC prompt when his payroll thread opened a Gusto+      // window): Chrome's Cast/MediaRouter feature binds an mDNS listener on 0.0.0.0:5353 — a+      // network-exposed socket, which is exactly what makes Windows Firewall prompt (and it prompts+      // per-new-exe, so every CfT version bump re-triggers it). pup is an automation browser that+      // never casts, so disable MediaRouter + the DIAL/mDNS route providers: Chrome then binds only+      // loopback and NO firewall prompt is ever shown. --disable-background-networking (above) alone+      // does not cover this; MediaRouter's mDNS is separate.+      '--disable-features=WinLaunchOnLogon,LaunchChromeOnWindowsLogon,StartupBoost,BeginBrowsingInstantly,DesktopStartupPromo,IPH_LaunchOnStartup,MediaRouter,DialMediaRouteProvider,CastMediaRouteProvider',+      '--media-router=0',       '--ash-no-nudges',       // ADOM-YOU VISUAL IDENTITY (John, 2026-08-06). A custom logo image on the       // Chrome profile chip is impossible for a local non-signed-in profile