← Commit history

Seal minimal-touch so the experiment measures what it claims. A systematic sweep of every desktop_taskbar / set_window_identity / flash_window call site found three AUTOMATIC paths still firing in minimal mode: updateThumbnailTooltip, badgePupTaskbar (legacy overlay fallback) and registerPupAumid. All three now no-op. The only remaining ungated taskbar calls are on USER-INITIATED raise paths (browser_raise_os_window and its flash-clear), which are explicit user actions, not the continuous background machinery under investigation.

John Lauer ·b339e46a38 ·3mo ago ·parent c106407
4 files changed +9−6
adom-bridge-puppeteer-manifest.json+4−4
@@ -1,10 +1,10 @@ {   "manifest_version": 1,   "name": "puppeteer",-  "version": "1.9.189",-  "url": "https://wiki.adom.inc/download/adom/adom-desktop-puppeteer-bridge/1.9.189/adom-bridge-puppeteer-v1.9.189.zip",-  "sha256": "90db5567f4523cd98706ac267020577316f99fc8823e7cd250a9cb02e0440383",-  "size": 423482,+  "version": "1.9.190",+  "url": "https://wiki.adom.inc/download/adom/adom-desktop-puppeteer-bridge/1.9.190/adom-bridge-puppeteer-v1.9.190.zip",+  "sha256": "ab2ac17a0aa1757da99036fa9bba72c18197ed5bdd279abe3d156dba32b61391",+  "size": 423532,   "verbPrefixes": [     "browser_",     "desktop_recorder_",
src/BRIDGE_VERSION+1−1
@@ -1 +1 @@-1.9.189+1.9.190
src/bridge.json+1−1
@@ -2,7 +2,7 @@   "manifest_version": 1,   "name": "puppeteer",   "displayName": "Puppeteer (Chrome for Testing + Native)",-  "version": "1.9.189",+  "version": "1.9.190",   "description": "Drives a browser ALREADY on the machine \u2014 installed Chrome, else Microsoft Edge (every Windows PC ships with Edge) \u2014 launched with a FRESH isolated profile, so the common case has NO ~150 MB Chrome-for-Testing download and it never touches the user's real tabs/logins. Binds its local server to LOOPBACK (127.0.0.1) only, so no Windows Firewall 'allow Node through the firewall' prompt ever pops. Chrome for Testing is fetched only as a LAST RESORT if the machine has no Chromium browser at all. SPAWN-VERIFIED fallback: pup tries each detected browser (Chrome \u2192 Edge \u2192 CfT) and actually launches it, falling through to the next if one won't start (and handling browsers like Edge that relaunch onto another PID), so a corrupt/partial install never hard-fails an open. The browser that launches is cached as the default (persisted across restarts) so it isn't re-probed each time. On spawn the bridge SELF-WARMS: detects browsers + disk, and only if the box has no Chrome/Edge and no cached CfT does it background-fetch CfT so the first open is instant. browser_use pins a specific browser (chrome | edge | cft | auto); {browser:'chrome',install:true} downloads & installs REAL Google Chrome (user-scoped, no admin) on an Edge-only box. browser_readiness (READ-ONLY) reports which browser will be used + the full candidate list + the default + free disk. Every failure returns a specific errorCode + _hint (chrome_install_no_disk, chrome_download_network, chrome_install_permission, chrome_stable_not_detected, \u2026). Launches with FULL browser permissions by default for full debug (strictPermissions:true opts out). Headful automation: open/close windows+tabs, navigate, screenshot, eval JS, record. pup is a GENERIC, non-profile browser only \u2014 every session is a fresh isolated Chrome/Edge process, never the user's real signed-in browser; profile defaults to sessionId. To drive the user's REAL Chrome/Edge (their profile, cookies, SSO), use the Adom browser EXTENSION's nbrowser_* verbs \u2014 a separate bridge, not pup's job. macOS (v1.9.74+): full parity with mac-native mechanics \u2014 background-by-default is the app-level hide (windows stay drivable/screenshottable while hidden), raise/lower map to unhide+activate/hide, browser_alert_window posts a native toast whose click focuses the window, browser_use {browser:'chrome',install:true} installs Chrome from the official dmg, and taskbar identity/badging remains Windows-only.",   "homepage": "https://wiki.adom.inc/adom/adom-desktop",   "author": "Adom Inc.",
src/server.js+3
@@ -2820,6 +2820,7 @@ async function stampPupIdentity(sessionId) { // into the id itself (Adom.Pup.<sid>.<cat>), so a Set suffices — a state change is a NEW id. const _registeredPupAumids = new Set(); async function registerPupAumid(appId, sessionId) {+  if (minimalTouch()) return false;   // v1.9.190: minimal-touch — no taskbar work at all   if (_identitySupported === false || appId === PUP_APP_ID || _registeredPupAumids.has(appId)) return;   // v1.9.44: write IconResource FIRST, before the button can possibly exist. AD's registration does   // not write it (see writeAumidIcon), and an AUMID with no icon is what paints white.@@ -3300,6 +3301,7 @@ function sessionCaller(session) {   } catch (e) { return null; } } async function updateThumbnailTooltip(session, sessionId) {+  if (minimalTouch()) return false;   // v1.9.190: minimal-touch — no taskbar work at all   if (process.platform !== 'win32' || !session || _thumbTooltipSupported === false) return;   const tip = buildThumbnailTooltip(session, sessionId);   if (session._thumbTip === tip) return;   // idempotent: only push real changes@@ -4311,6 +4313,7 @@ async function brandPupWindow(sessionId) {   return badgePupTaskbar(sessionId); } async function badgePupTaskbar(sessionId) {+  if (minimalTouch()) return false;   // v1.9.190: minimal-touch — no taskbar work at all   if (process.platform !== 'win32') return false;   const icon = pupBadgeB64();   if (!icon) { console.log('[badge] no icon asset — skipping'); return false; }