Pup - the AI's own browser

@@ -55,6 +55,19 @@ function fileExists(p) {   try { return !!p && fs.statSync(p).isFile(); } catch { return false; } } +// Free disk (MB) on the volume holding `dir` (defaults to the CfT cache). Walks up+// to a path that exists (cacheDir may not exist yet on a fresh box). null if we+// can't tell (very old Node without statfsSync) — callers must treat null as "unknown",+// never as "zero", so we don't block installs on boxes where we simply can't measure.+function diskFreeMb(dir) {+  for (const d of [dir, cacheDir(), os.homedir()].filter(Boolean)) {+    try { const s = fs.statfsSync(d); return Math.floor((s.bavail * s.bsize) / (1024 * 1024)); } catch { /* try next */ }+  }+  return null;+}+// Chrome for Testing is a ~150 MB download that unpacks to ~600 MB — need headroom.+const CFT_MIN_FREE_MB = 800;+ // Puppeteer's default cache (AD sets no PUPPETEER_CACHE_DIR) → ~/.cache/puppeteer. function cacheDir() {   return process.env.PUPPETEER_CACHE_DIR || path.join(os.homedir(), '.cache', 'puppeteer');@@ -203,7 +216,7 @@ function resolveBrowser() { //   browser: 'auto' | 'chrome' | 'edge' | 'cft' | 'chrome-for-testing'  (or pass executablePath) // 'cft' installs Chrome for Testing in the background if it isn't cached, and pins it // as the default so once it lands every open uses it. Returns a pickSummary.-function setDefaultBrowser({ browser, executablePath } = {}) {+function setDefaultBrowser({ browser, executablePath, install } = {}) {   const b = String(browser || '').toLowerCase().replace(/[\s_-]/g, '');   if (executablePath) {     if (!fileExists(executablePath)) return { ok: false, errorCode: 'browser_not_found', error: `No executable at ${executablePath}.`, ...pickSummary() };@@ -216,12 +229,21 @@ function setDefaultBrowser({ browser, executablePath } = {}) {   }   if (b === 'chrome' || b === 'edge') {     const cand = listSystemBrowsers().find(c => c.kind === b);-    if (!cand) {-      const avail = listSystemBrowsers().map(c => c.kind).join(', ') || 'none';-      return { ok: false, errorCode: 'browser_not_found', error: `No installed ${b} found. Installed system browsers: ${avail}. Use browser:'cft' to fetch Chrome for Testing.`, ...pickSummary() };+    if (cand) {+      writeDefault({ kind: cand.kind, executablePath: cand.executablePath, source: 'system', forced: true, verifiedAt: Date.now() });+      return { ok: true, ...pickSummary() };     }-    writeDefault({ kind: cand.kind, executablePath: cand.executablePath, source: 'system', forced: true, verifiedAt: Date.now() });-    return { ok: true, ...pickSummary() };+    // Not installed. For Chrome we can download+install the REAL browser on request.+    if (b === 'chrome' && install) {+      writeDefault({ kind: 'chrome', executablePath: null, source: 'system', forced: true, pendingInstall: true, verifiedAt: Date.now() });+      installChromeStable(); // background; browser_use polling + readiness track it+      return { ok: true, installing: true, installingChrome: true, ...pickSummary() };+    }+    const avail = listSystemBrowsers().map(c => c.kind).join(', ') || 'none';+    const extra = b === 'chrome'+      ? " Pass {browser:'chrome', install:true} to download & install Google Chrome (~90 MB, user-scoped, no admin prompt), or use browser:'cft' / browser:'edge'."+      : " Edge ships with every Windows PC — if it's genuinely missing, use browser:'chrome' (install:true) or browser:'cft'.";+    return { ok: false, errorCode: 'browser_not_found', error: `No installed ${b} found. Installed system browsers: ${avail}.${extra}`, ...pickSummary() };   }   if (b === 'cft' || b === 'chromefortesting') {     const det = detectChrome();@@ -284,8 +306,20 @@ function installChrome({ onProgress } = {}) {         state.error = 'Could not determine which Chrome-for-Testing build to install (puppeteer.executablePath() gave no build id and resolveBuildId failed — network or a broken puppeteer install).';         return { ok: false, errorCode: state.errorCode, error: state.error };       }+      // Disk-space pre-flight — a CfT download that runs the volume out of space+      // fails deep in the unzip with a cryptic error. Catch it up front with an+      // actionable hint. null free (can't measure) → proceed (don't block).+      const freeMb = diskFreeMb(cacheDir());+      if (freeMb != null && freeMb < CFT_MIN_FREE_MB) {+        state.phase = 'failed';+        state.errorCode = 'chrome_install_no_disk';+        state.error = `Not enough free disk to install Chrome for Testing: ${freeMb} MB free on the drive holding ${cacheDir()}, need ~${CFT_MIN_FREE_MB} MB (150 MB download unpacks to ~600 MB). Free up space, or just install/use Chrome or Edge (Edge already ships with Windows) — that needs no download.`;+        console.error(`[chrome] ${state.error}`);+        return { ok: false, errorCode: state.errorCode, error: state.error, diskFreeMb: freeMb };+      }+       state.buildId = buildId;-      console.log(`[chrome] installing Chrome for Testing ${buildId} (${platform}) into ${cacheDir()} ...`);+      console.log(`[chrome] installing Chrome for Testing ${buildId} (${platform}) into ${cacheDir()} (disk free: ${freeMb == null ? 'unknown' : freeMb + ' MB'}) ...`);        const installed = await install({         browser: Browser.CHROME,@@ -316,10 +350,19 @@ function installChrome({ onProgress } = {}) {       return { ok: true, executablePath: ep, buildId };     } catch (e) {       state.phase = 'failed';-      state.errorCode = state.errorCode || 'chrome_download_failed';-      state.error = (e && e.message) || String(e);+      const msg = (e && e.message) || String(e);+      // Map the common low-level failures to actionable codes so the AI's hint is specific.+      if (!state.errorCode) {+        if (/ENOSPC|no space left|not enough space/i.test(msg)) state.errorCode = 'chrome_install_no_disk';+        else if (/EACCES|EPERM|permission/i.test(msg))          state.errorCode = 'chrome_install_permission';+        else if (/ENOTFOUND|ETIMEDOUT|ECONNRESET|network|getaddrinfo|proxy|tunneling/i.test(msg)) state.errorCode = 'chrome_download_network';+        else state.errorCode = 'chrome_download_failed';+      }+      state.error = state.errorCode === 'chrome_install_no_disk'+        ? `Ran out of disk installing Chrome for Testing (${diskFreeMb(cacheDir())} MB free). Free up space, or use Chrome/Edge (no download). Raw: ${msg}`+        : msg;       state.finishedAt = Date.now();-      console.error(`[chrome] install failed: ${state.error}`);+      console.error(`[chrome] install failed (${state.errorCode}): ${state.error}`);       return { ok: false, errorCode: state.errorCode, error: state.error };     } finally {       _installInFlight = null;@@ -393,12 +436,121 @@ function readiness() {     lastError: state.error,     lastErrorCode: state.errorCode,     cacheDir: cacheDir(),+    diskFreeMb: diskFreeMb(),          // free space on the CfT-cache volume (null = unmeasurable)+    lowDisk: (() => { const f = diskFreeMb(); return f != null && f < CFT_MIN_FREE_MB; })(),+    installingChrome: !!_chromeStableInFlight,   // a real-Google-Chrome install is in flight+    chromeStablePhase: chromeStableState.phase,+    chromeStableError: chromeStableState.error,     puppeteerLoadError: _puppeteerLoadError,   }; } +// ── Real Google Chrome (stable) installer ─────────────────────────────────────+// When the user explicitly wants CHROME (not CfT) on an Edge-only box, fetch Google's+// official offline installer and run it silently. Run as the (non-admin) user, Chrome's+// installer drops a USER-SCOPED install into %LOCALAPPDATA%\Google\Chrome — no UAC —+// which listSystemBrowsers() already finds. An elevated/admin context may install+// machine-wide and could raise a UAC prompt on the desktop (surfaced via the hint).+const chromeStableState = { phase: 'idle', error: null, errorCode: null, startedAt: null, finishedAt: null };+let _chromeStableInFlight = null;+const CHROME_STABLE_URL = 'https://dl.google.com/chrome/install/standalonesetup64.exe';++function _download(url, destPath, redirects = 0) {+  return new Promise((resolve, reject) => {+    if (redirects > 5) return reject(new Error('too many redirects fetching the Chrome installer'));+    const https = require('https');+    const file = fs.createWriteStream(destPath);+    https.get(url, (resp) => {+      if ([301, 302, 303, 307, 308].includes(resp.statusCode) && resp.headers.location) {+        file.close(); try { fs.unlinkSync(destPath); } catch {}+        return resolve(_download(resp.headers.location, destPath, redirects + 1));+      }+      if (resp.statusCode !== 200) { file.close(); try { fs.unlinkSync(destPath); } catch {} return reject(new Error(`HTTP ${resp.statusCode} fetching ${url}`)); }+      resp.pipe(file);+      file.on('finish', () => file.close(() => resolve(destPath)));+      file.on('error', (e) => { try { fs.unlinkSync(destPath); } catch {} reject(e); });+    }).on('error', (e) => { try { fs.unlinkSync(destPath); } catch {} reject(e); });+  });+}++function installChromeStable() {+  if (_chromeStableInFlight) return _chromeStableInFlight;+  _chromeStableInFlight = (async () => {+    chromeStableState.phase = 'installing'; chromeStableState.error = null; chromeStableState.errorCode = null;+    chromeStableState.startedAt = Date.now(); chromeStableState.finishedAt = null;+    try {+      const pre = listSystemBrowsers().find(x => x.kind === 'chrome');+      if (pre) { chromeStableState.phase = 'ready'; chromeStableState.finishedAt = Date.now(); return { ok: true, executablePath: pre.executablePath, alreadyInstalled: true }; }+      if (process.platform !== 'win32') {+        chromeStableState.phase = 'failed'; chromeStableState.errorCode = 'chrome_stable_unsupported_os';+        chromeStableState.error = 'Auto-installing Google Chrome is only wired up for Windows.';+        return { ok: false, errorCode: chromeStableState.errorCode, error: chromeStableState.error };+      }+      const freeMb = diskFreeMb();+      if (freeMb != null && freeMb < 500) {+        chromeStableState.phase = 'failed'; chromeStableState.errorCode = 'chrome_install_no_disk';+        chromeStableState.error = `Not enough disk to install Chrome: ${freeMb} MB free, need ~500 MB.`;+        return { ok: false, errorCode: chromeStableState.errorCode, error: chromeStableState.error, diskFreeMb: freeMb };+      }+      const tmp = path.join(os.tmpdir(), `chrome_installer_${process.pid}.exe`);+      console.log(`[chrome] downloading Google Chrome installer → ${tmp}`);+      await _download(CHROME_STABLE_URL, tmp);+      console.log('[chrome] running Chrome installer silently (/silent /install) ...');+      const { spawn } = require('child_process');+      await new Promise((resolve, reject) => {+        let done = false;+        const child = spawn(tmp, ['/silent', '/install'], { windowsHide: true });+        child.on('error', (e) => { if (!done) { done = true; reject(e); } });+        child.on('exit', () => { if (!done) { done = true; resolve(); } });+        setTimeout(() => { if (!done) { done = true; resolve(); } }, 180000); // installer may background; we poll next+      });+      let found = null;+      for (let i = 0; i < 40; i++) { found = listSystemBrowsers().find(x => x.kind === 'chrome'); if (found) break; await new Promise(r => setTimeout(r, 1500)); }+      try { fs.unlinkSync(tmp); } catch {}+      if (!found) {+        chromeStableState.phase = 'failed'; chromeStableState.errorCode = 'chrome_stable_not_detected';+        chromeStableState.error = 'Ran the Chrome installer but chrome.exe did not appear. A Windows UAC/elevation prompt may be waiting on the user\'s desktop — ask them to accept it — or the install was blocked. pup still works with Edge in the meantime.';+        return { ok: false, errorCode: chromeStableState.errorCode, error: chromeStableState.error };+      }+      chromeStableState.phase = 'ready'; chromeStableState.finishedAt = Date.now();+      console.log(`[chrome] Google Chrome installed at ${found.executablePath}`);+      return { ok: true, executablePath: found.executablePath };+    } catch (e) {+      chromeStableState.phase = 'failed';+      const msg = (e && e.message) || String(e);+      chromeStableState.errorCode = /ENOSPC|space/i.test(msg) ? 'chrome_install_no_disk'+        : /ENOTFOUND|ETIMEDOUT|ECONNRESET|network|proxy|getaddrinfo/i.test(msg) ? 'chrome_download_network'+        : 'chrome_stable_install_failed';+      chromeStableState.error = msg;+      console.error(`[chrome] Chrome stable install failed (${chromeStableState.errorCode}): ${msg}`);+      return { ok: false, errorCode: chromeStableState.errorCode, error: msg };+    } finally { _chromeStableInFlight = null; }+  })();+  return _chromeStableInFlight;+}+function chromeStableStatus() { return { ...chromeStableState, inFlight: !!_chromeStableInFlight }; }++// ── Startup self-warm ─────────────────────────────────────────────────────────+// Called once when the bridge process boots (server.js). Cheap browser detection ++// disk logging so the first open is instant. If the box has NO Chrome/Edge AND no+// cached CfT — the only case that would otherwise force a mid-open download — start+// fetching CfT NOW in the background (guarded on disk) so the user doesn't wait later.+function warmup() {+  try {+    const cands = launchCandidates();+    const free = diskFreeMb();+    console.log(`[warmup] browsers: ${cands.map(c => `${c.kind}(${c.source})`).join(', ') || 'NONE'} | disk free: ${free == null ? '?' : free + 'MB'}`);+    if (!cands.length) {+      if (free != null && free < CFT_MIN_FREE_MB) { console.log(`[warmup] no browser + low disk (${free}MB) — NOT auto-fetching CfT; readiness reports lowDisk`); return; }+      console.log('[warmup] no Chrome/Edge and no cached CfT — background-fetching Chrome for Testing now so the first open is instant');+      ensureChromeReady({ background: true });+    }+  } catch (e) { console.error(`[warmup] ${e && e.message}`); }+}+ module.exports = {   detectChrome, detectSystemBrowser, listSystemBrowsers, launchCandidates, resolveBrowser,-  installChrome, ensureChromeReady, readiness, expectedBuildId, cacheDir,+  installChrome, ensureChromeReady, readiness, expectedBuildId, cacheDir, diskFreeMb,   setDefaultBrowser, readDefault, clearDefault, markVerified, pickSummary,+  installChromeStable, chromeStableStatus, warmup, };

@@ -1544,25 +1544,40 @@ async function getOrLaunchBrowser(profileName, { freshProfile = false, strictPer       });       child.unref(); -      // Wait for Chrome to start and CDP to be ready (30s — Chrome cold start can be slow)+      // Wait for the browser to start and CDP to be ready (30s — cold start can be slow).+      // IMPORTANT (Edge + some Chrome channels): the process we spawned is often just a+      // LAUNCHER that relaunches the real browser onto a DIFFERENT PID and then exits. So+      // we probe CDP FIRST every tick, and on launcher-death we give CDP one last chance+      // before declaring failure — otherwise a perfectly-good Edge reads as "exited+      // immediately". (The old order killed Edge launches dead.)       let connected = false;       let childDied = false;       for (let i = 0; i < 60; i++) {         await new Promise(r => setTimeout(r, 500));-        // Did the child process die unexpectedly?+        // CDP up? Then we're connected regardless of which PID now hosts the browser.+        try {+          const resp = await fetch(`http://127.0.0.1:${debugPort}/json/version`);+          if (resp.ok) { connected = true; break; }+        } catch {}+        // Is the process we spawned still alive?+        let alive = true;         try {           if (process.platform === 'win32') {             const out = execSync(`tasklist /FI "PID eq ${child.pid}" /NH /FO CSV`, { encoding: 'utf8', stdio: ['ignore', 'pipe', 'ignore'] });-            if (!out.includes(`"${child.pid}"`)) { childDied = true; break; }+            alive = out.includes(`"${child.pid}"`);           } else {             process.kill(child.pid, 0); // throws if dead           }-        } catch { childDied = true; break; }--        try {-          const resp = await fetch(`http://127.0.0.1:${debugPort}/json/version`);-          if (resp.ok) { connected = true; break; }-        } catch {}+        } catch { alive = false; }+        if (!alive) {+          // Launcher exited — the browser may be up on another PID. Final CDP grace probe.+          await new Promise(r => setTimeout(r, 700));+          try {+            const resp = await fetch(`http://127.0.0.1:${debugPort}/json/version`);+            if (resp.ok) { connected = true; break; }+          } catch {}+          childDied = true; break;+        }       }        if (!connected) {@@ -1619,7 +1634,13 @@ async function getOrLaunchBrowser(profileName, { freshProfile = false, strictPer       }       if (browser) break;       triedList.push({ kind: cand.kind, source: cand.source, executablePath: cand.executablePath || null, error: lastErr && lastErr.message });-      if (launchList.length > 1) console.log(`[launch] ${cand.kind}(${cand.source}) exhausted ${MAX_ATTEMPTS} attempts — trying next browser`);+      if (launchList.length > 1) {+        console.log(`[launch] ${cand.kind}(${cand.source}) exhausted ${MAX_ATTEMPTS} attempts — trying next browser`);+        // A failed candidate (e.g. an Edge that aborted) can leave SingletonLock /+        // DevToolsActivePort in the shared userDataDir that would poison the NEXT+        // browser. Clear them before the next candidate so the fallback is clean.+        await killChromeHoldingProfile();+      }     }      if (browser && chosen) {@@ -3027,7 +3048,7 @@ const server = http.createServer(async (req, res) => {             V('desktop_record_stop', 'Stop the desktop screen recording; returns the file.', {}, 30, {}),             V('browser_readiness', 'Readiness + which browser pup will drive (installed Chrome/Edge, or cached Chrome for Testing) + the full candidate list and current default. READ-ONLY; never downloads.', {}, 10, {}),             V('browser_prewarm', 'Install Chrome for Testing WITHOUT opening a window, and pin it as the default. Use when you specifically want CfT rather than the machine\'s installed Chrome/Edge.', { wait: 'optional bool — block until installed', setDefault: 'optional bool (default true) — pin CfT as the default' }, 240, {}),-            V('browser_use', 'Pin (or clear) the browser pup drives by default: chrome | edge | cft | auto (or an explicit executablePath). "cft" fetches Chrome for Testing then pins it. Persists across restarts; launch still spawn-verifies + falls back.', { browser: '"chrome" | "edge" | "cft" | "auto"', executablePath: 'optional — pin an exact browser binary' }, 30, {}),+            V('browser_use', 'Pin (or clear) the browser pup drives by default: chrome | edge | cft | auto (or an explicit executablePath). "cft" fetches Chrome for Testing then pins it. With {browser:"chrome", install:true} it DOWNLOADS & INSTALLS real Google Chrome (user-scoped, no admin) on an Edge-only box, then pins it. Persists across restarts; launch still spawn-verifies + falls back.', { browser: '"chrome" | "edge" | "cft" | "auto"', install: 'optional bool — with browser:"chrome", install real Chrome if missing', executablePath: 'optional — pin an exact browser binary' }, 240, {}),             V('browser_describe', 'This list — the bridge\'s verbs + schemas, for AD\'s Verbs tab.', {}, 10, {}),           ] });           return;@@ -3065,7 +3086,19 @@ const server = http.createServer(async (req, res) => {                 });                 return;               }-              // No Chrome/Edge AND no cached CfT — fetch CfT as a last resort, in the background.+              // No Chrome/Edge AND no cached CfT. If the disk is too low to hold CfT,+              // don't kick off a doomed 150 MB download — fail fast with a disk hint.+              if (rd.lowDisk) {+                sendJSON(res, {+                  success: false,+                  errorCode: 'chrome_install_no_disk',+                  readiness: rd,+                  error: `No Chrome/Edge on this machine and only ${rd.diskFreeMb} MB free — not enough to install Chrome for Testing (~800 MB needed).`,+                  _hint: `This box has no Chrome or Edge, and only ${rd.diskFreeMb} MB free disk — too low to download Chrome for Testing (~150 MB download, ~600 MB unpacked). Ask the user to free up disk space, then retry; OR install Edge/Chrome (Edge ships with Windows and needs almost nothing). Do NOT keep retrying the download — it will fail until disk is freed.`,+                });+                return;+              }+              // Otherwise fetch CfT as a last resort, in the background.               if (!rd.installing) chrome.ensureChromeReady({ background: true });               sendJSON(res, {                 success: false,@@ -4224,7 +4257,7 @@ const server = http.createServer(async (req, res) => {           // for Testing in the background if not cached, then pins it. Persists across           // bridge restarts. The launch path still spawn-verifies + falls back, so a           // pinned browser that later breaks won't hard-fail an open.-          const result = chrome.setDefaultBrowser({ browser: args && args.browser, executablePath: args && args.executablePath });+          const result = chrome.setDefaultBrowser({ browser: args && args.browser, executablePath: args && args.executablePath, install: !!(args && args.install) });           const rd = chrome.readiness();           const availTxt = (result.candidates || []).map(c => `${c.kind}(${c.source})`).join(', ') || 'none';           let hint;@@ -4232,6 +4265,8 @@ const server = http.createServer(async (req, res) => {             hint = `${result.error} Available on this machine: ${availTxt}. Use browser_use {browser:"chrome"|"edge"|"cft"|"auto"}.`;           } else if (result.cleared) {             hint = `Default cleared → AUTO. pup will drive the first browser that launches (${availTxt}) and cache it. Next browser_open_window applies it.`;+          } else if (result.installingChrome) {+            hint = `Downloading & installing REAL Google Chrome (~90 MB, user-scoped — no admin prompt in most cases) and pinning it as the default. Poll browser_readiness: watch installingChrome/chromeStablePhase until Chrome appears (browserKind:"chrome", source:"system"). Until then pup uses ${availTxt}. If it stalls, a UAC prompt may be waiting on the user's desktop — ask them to accept it.`;           } else if (result.installing) {             hint = `Pinned Chrome for Testing as the default and started the ~150 MB download in the background. Poll browser_readiness until ready:true — until then pup falls back to installed Chrome/Edge (${availTxt}). Once cached, every open uses CfT.`;           } else {@@ -4694,6 +4729,11 @@ server.listen(PORT, async () => {   console.log(`Puppeteer Bridge running on http://localhost:${PORT}`);   console.log('Multi-session support: sessions are tabs sharing Chrome profiles via userDataDir');   console.log('Endpoints: /health, /command, /launch, /navigate, /reload, /screenshot, /screenshot.png, /errors, /eval, /wait, /status, /close');+  // Self-warm: detect browsers + disk the moment the bridge spawns (right after AD+  // installs/updates it), so the FIRST open is instant. Only fetches CfT if the box+  // has literally no Chrome/Edge and no cached CfT — otherwise it's a cheap no-op.+  try { chrome.warmup(); } catch (e) { console.error('warmup failed:', e.message); }+   // Recover sessions from disk (reconnect to Chrome windows that survived bridge restart)   try {     await recoverSessions();