← Commit history

Third attempt at the once-per-process bug-report invitation, this time with the actual cause. Machine traffic was eating it at TWO layers, each failing silently: AD's /health and /status probes flow through the same sendJSON chokepoint (fixed in 1.9.96 by requiring a verb), and AD ALSO calls pup's declared statusVerb (browser_readiness) through /command on spawn, so it arrived as a real verb and consumed the invite anyway. The orientation invite now fires on the first SUBSTANTIVE verb (an open/drive — the moment John described, 'when typical verbs are being invoked like open browser'), while read-only probes and enumerations neither consume nor carry it. A FAILURE still always carries the invitation regardless of verb, because that is when the evidence exists.

John Lauer ·abbeeed6f4 ·3mo ago ·parent d3cbee9
4 files changed +28−13
adom-bridge-puppeteer-manifest.json+4−4
@@ -1,10 +1,10 @@ {   "manifest_version": 1,   "name": "puppeteer",-  "version": "1.9.96",-  "url": "https://wiki.adom.inc/download/adom/adom-desktop-puppeteer-bridge/1.9.96/adom-bridge-puppeteer-v1.9.96.zip",-  "sha256": "3bdf07e825d90b478e2d8d1b82bfdd8cc27e2185e7631e7f4ef5f28b92e34c56",-  "size": 369765,+  "version": "1.9.97",+  "url": "https://wiki.adom.inc/download/adom/adom-desktop-puppeteer-bridge/1.9.97/adom-bridge-puppeteer-v1.9.97.zip",+  "sha256": "d3ddaed73c878843f245429dbad1b0ff511db69836d97a8e388128a1d27bba8c",+  "size": 370144,   "verbPrefixes": [     "browser_",     "desktop_recorder_",
src/BRIDGE_VERSION+1−1
@@ -1 +1 @@-1.9.96+1.9.97
src/bridge.json+1−1
@@ -2,7 +2,7 @@   "manifest_version": 1,   "name": "puppeteer",   "displayName": "Puppeteer (Chrome for Testing + Native)",-  "version": "1.9.96",+  "version": "1.9.97",   "description": "Drives a browser ALREADY on the machine \u2014 installed Chrome, else Microsoft Edge (every Windows PC ships with Edge) \u2014 launched with a FRESH isolated profile, so the common case has NO ~150 MB Chrome-for-Testing download and it never touches the user's real tabs/logins. Binds its local server to LOOPBACK (127.0.0.1) only, so no Windows Firewall 'allow Node through the firewall' prompt ever pops. Chrome for Testing is fetched only as a LAST RESORT if the machine has no Chromium browser at all. SPAWN-VERIFIED fallback: pup tries each detected browser (Chrome \u2192 Edge \u2192 CfT) and actually launches it, falling through to the next if one won't start (and handling browsers like Edge that relaunch onto another PID), so a corrupt/partial install never hard-fails an open. The browser that launches is cached as the default (persisted across restarts) so it isn't re-probed each time. On spawn the bridge SELF-WARMS: detects browsers + disk, and only if the box has no Chrome/Edge and no cached CfT does it background-fetch CfT so the first open is instant. browser_use pins a specific browser (chrome | edge | cft | auto); {browser:'chrome',install:true} downloads & installs REAL Google Chrome (user-scoped, no admin) on an Edge-only box. browser_readiness (READ-ONLY) reports which browser will be used + the full candidate list + the default + free disk. Every failure returns a specific errorCode + _hint (chrome_install_no_disk, chrome_download_network, chrome_install_permission, chrome_stable_not_detected, \u2026). Launches with FULL browser permissions by default for full debug (strictPermissions:true opts out). Headful automation: open/close windows+tabs, navigate, screenshot, eval JS, record. pup is a GENERIC, non-profile browser only \u2014 every session is a fresh isolated Chrome/Edge process, never the user's real signed-in browser; profile defaults to sessionId. To drive the user's REAL Chrome/Edge (their profile, cookies, SSO), use the Adom browser EXTENSION's nbrowser_* verbs \u2014 a separate bridge, not pup's job. macOS (v1.9.74+): full parity with mac-native mechanics \u2014 background-by-default is the app-level hide (windows stay drivable/screenshottable while hidden), raise/lower map to unhide+activate/hide, browser_alert_window posts a native toast whose click focuses the window, browser_use {browser:'chrome',install:true} installs Chrome from the official dmg, and taskbar identity/badging remains Windows-only.",   "homepage": "https://wiki.adom.inc/adom/adom-desktop",   "author": "Adom Inc.",
src/server.js+22−7
@@ -5674,22 +5674,37 @@ function maybeAttachBugInvite(obj, verb) {   try {     if (!obj || typeof obj !== 'object' || Array.isArray(obj)) return;     if (obj._reportIssues) return;                                   // handler already set one-    // v1.9.95a — ONLY count AI-facing VERB responses. AD probes /health (and /status for the chip)-    // every ~15s and those replies flow through sendJSON too, so without this gate the very first-    // health probe after a spawn consumed the once-per-process invitation and no AI ever saw it-    // (measured: the first real verb after a restart carried nothing). A machine-facing probe is not-    // a caller we can ask for a bug report.+    // v1.9.96a — ONLY count AI-facing SUBSTANTIVE verbs. Two layers of machine traffic were eating+    // the once-per-process invitation before any AI could see it, and each failed SILENTLY (the+    // feature simply never appeared):+    //   1. AD probes /health (+ /status for the bridge chip) every ~15s — those replies flow through+    //      this same sendJSON chokepoint. Excluded by requiring a `verb` at all.+    //   2. AD also calls pup's DECLARED statusVerb (browser_readiness) through /command on spawn, so+    //      it arrives as a real verb and consumed the invite anyway (measured twice: the first verb+    //      after a restart still carried nothing).+    // So the orientation invite now fires on the first SUBSTANTIVE verb — an open/drive, the moment+    // John actually described ("when typical verbs are being invoked like open browser") — while+    // read-only probes and enumerations neither consume nor carry it. Failures still always carry it,+    // whatever the verb, because that is when the evidence exists.     if (!verb) return;+    const PROBE_VERBS = new Set([+      'browser_readiness', 'browser_status', 'browser_describe', 'browser_prewarm',+      'browser_list_windows', 'browser_list_tabs', 'browser_rescan', 'browser_configure',+    ]);+    const isProbe = PROBE_VERBS.has(verb);     let mode = 'on';     try { mode = (pupSettings().reportIssues === 'off') ? 'off' : 'on'; } catch (e) {}     if (mode === 'off') return;     const isError = obj.success === false || !!obj.errorCode || (!!obj.error && obj.error !== '');+    // A FAILURE always earns the invitation, even on a probe — that is the highest-value moment.+    if (isError) { obj._reportIssues = bugReportInvite(true); return; }+    if (isProbe) return;                       // probes: never consume, never carry     _bugInviteCalls++;     const first = !_bugInviteFirstDone;     const periodic = _bugInviteCalls % BUG_INVITE_EVERY === 0;-    if (!isError && !first && !periodic) return;+    if (!first && !periodic) return;     if (first) _bugInviteFirstDone = true;-    obj._reportIssues = bugReportInvite(isError);+    obj._reportIssues = bugReportInvite(false);   } catch (e) { /* never let the invitation break a response */ } }