← Commit history

Cap enum_windows at one call per second no matter how many window opens run concurrently: the fresh-poller sharing window widens to a full second and the birth and re-capture polls slow to 600ms, so the Activity Log can never show same-second enum bursts again.

John Lauer ·a9acdf492b ·2mo ago ·parent b1e85dc
4 files changed +17−10
adom-bridge-puppeteer-manifest.json+4−4
@@ -1,10 +1,10 @@ {   "manifest_version": 1,   "name": "puppeteer",-  "version": "2.0.183",-  "url": "https://wiki.adom.inc/download/adom/pup-bridge/2.0.183/adom-bridge-puppeteer-v2.0.183.zip",-  "sha256": "97c99496ae4f7e34af86c6f872ced0e38a4a3d39105ad1f75cfc85d35ec0444f",-  "size": 921642,+  "version": "2.0.184",+  "url": "https://wiki.adom.inc/download/adom/pup-bridge/2.0.184/adom-bridge-puppeteer-v2.0.184.zip",+  "sha256": "b817faea7afecb8395910bb1b335d4bbd197e30d45b1a31e8ea8de7e1a543089",+  "size": 921882,   "verbPrefixes": [     "browser_",     "desktop_recorder_",
src/BRIDGE_VERSION+1−1
@@ -1 +1 @@-2.0.183+2.0.184
src/bridge.json+1−1
@@ -2,7 +2,7 @@   "manifest_version": 1,   "name": "puppeteer",   "displayName": "Puppeteer (Chrome for Testing + Native)",-  "version": "2.0.183",+  "version": "2.0.184",   "description": "Drives a browser ALREADY on the machine \u2014 installed Chrome, else Microsoft Edge (every Windows PC ships with Edge) \u2014 launched with a FRESH isolated profile, so the common case has NO ~150 MB Chrome-for-Testing download and it never touches the user's real tabs/logins. Binds its local server to LOOPBACK (127.0.0.1) only, so no Windows Firewall 'allow Node through the firewall' prompt ever pops. Chrome for Testing is fetched only as a LAST RESORT if the machine has no Chromium browser at all. SPAWN-VERIFIED fallback: pup tries each detected browser (Chrome \u2192 Edge \u2192 CfT) and actually launches it, falling through to the next if one won't start (and handling browsers like Edge that relaunch onto another PID), so a corrupt/partial install never hard-fails an open. The browser that launches is cached as the default (persisted across restarts) so it isn't re-probed each time. On spawn the bridge SELF-WARMS: detects browsers + disk, and only if the box has no Chrome/Edge and no cached CfT does it background-fetch CfT so the first open is instant. pup_use pins a specific browser (chrome | edge | cft | auto); {browser:'chrome',install:true} downloads & installs REAL Google Chrome (user-scoped, no admin) on an Edge-only box. pup_readiness (READ-ONLY) reports which browser will be used + the full candidate list + the default + free disk. Every failure returns a specific errorCode + _hint (chrome_install_no_disk, chrome_download_network, chrome_install_permission, chrome_stable_not_detected, \u2026). Launches with FULL browser permissions by default for full debug (strictPermissions:true opts out). Headful automation: open/close windows+tabs, navigate, screenshot, eval JS, record. pup is a GENERIC, non-profile browser only \u2014 every session is a fresh isolated Chrome/Edge process, never the user's real signed-in browser; profile defaults to sessionId. To drive the user's REAL Chrome/Edge (their profile, cookies, SSO), use the Adom browser EXTENSION's nbrowser_* verbs \u2014 a separate bridge, not pup's job. macOS (v1.9.74+): full parity with mac-native mechanics \u2014 background-by-default is the app-level hide (windows stay drivable/screenshottable while hidden), raise/lower map to unhide+activate/hide, pup_alert_window posts a native toast whose click focuses the window, pup_use {browser:'chrome',install:true} installs Chrome from the official dmg, and taskbar identity/badging remains Windows-only.",   "homepage": "https://wiki.adom.inc/adom/adom-bridge",   "author": "Adom Inc.",
src/server.js+11−4
@@ -7306,7 +7306,14 @@ const ENUM_CACHE_MS = 1500; // must see a brand-new window), but they can share ONE call with each other: a 250ms freshness // window is far below the ~100ms a window takes to appear, yet collapses simultaneous pollers and // halves each loop's rate. Net: same detection latency, a fraction of the ab log noise.-const ENUM_FRESH_MS = 250;+// v2.0.184 (John's 3rd spam report, screenshot: multiple enum calls in the SAME second): the+// bursts are BIRTH-CAPTURE polls during window opens — and sibling threads on a busy box open+// windows constantly, so "per-open cost" IS the steady-state log noise. 250ms sharing still allowed+// ~4 real calls/second. At 1000ms, every fresh poller shares one snapshot per second, so the ab log+// can never show more than ~1 enum/second no matter how many opens run concurrently. A birth+// set-diff tolerates a <=1s-stale snapshot fine: it just sees the new window one poll later, and+// window creation takes 1-3s anyway.+const ENUM_FRESH_MS = 1000; let _enumInflight = null; let _enumFreshInflight = null; let _enumCache = { at: 0, rows: null };@@ -7572,7 +7579,7 @@ async function resolveSessionHwndByBounds(session, sessionId) {               const moved = rr.filter(r => !hwndOwnedByOtherSession(r.h, sessionId) && _before.has(r.h) && _before.get(r.h) !== `${r.L},${r.T},${r.W},${r.H}`);               if (moved.length === 1) got = moved[0].h;               else if (moved.length > 1) { console.log(`[hwnd] "${sessionId}" re-capture saw ${moved.length} windows move at once — refusing (concurrent motion)`); break; }-              else await new Promise(r => setTimeout(r, 260));+              else await new Promise(r => setTimeout(r, 600));             }             if (!got) console.log(`[hwnd] "${sessionId}" re-capture probe: no unique moved window — leaving bare`);             // restore the ORIGINAL rect exactly (never dump the window at 0,0 — that repositioning@@ -9601,7 +9608,7 @@ async function createPageInNewWindow(browser, profileName) {         // v2.0.172: 20x120ms -> 12x260ms. The window normally appears on round 1-2, so the tail         // rounds were pure ab noise; the total wait (~3.1s) is unchanged and the shared 250ms fresh         // window means concurrent births now cost ONE enum instead of one each.-        for (let i = 0; i < 12 && !capturedHwnd; i++) {+        for (let i = 0; i < 7 && !capturedHwnd; i++) {           const rows = await enumChromeWidgetWindows({ fresh: true });           const fresh2 = rows.filter(r => !beforeHwnds.has(Number(r.h)) && !hwndOwnedByOtherSession(r.h, null));           if (fresh2.length === 1) { capturedHwnd = fresh2[0].h; break; }@@ -9614,7 +9621,7 @@ async function createPageInNewWindow(browser, profileName) {             for (const r of pool) for (const sc of [1, 1.25, 1.5, 1.75, 2]) { const e = Math.abs(r.L - Math.round(birthLeft * sc)); if (e < bestErr) { bestErr = e; best = r.h; } }             capturedHwnd = best; break;           }-          await new Promise(r => setTimeout(r, 260));+          await new Promise(r => setTimeout(r, 600));         }       }     });